YetiForceCompany/YetiForceCRM

View on GitHub
modules/Settings/Notifications/views/Configuration.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Avoid using static access to class 'Vtiger_Watchdog_Model' in method 'process'.
Open

        $viewer->assign('WATCHDOG_MODULE', Vtiger_Watchdog_Model::getInstance($srcModule));

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Vtiger_Watchdog_Model' in method 'process'.
Open

        $modules = Vtiger_Watchdog_Model::getSupportedModules();

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $srcModule = $request->getInteger('srcModule');
        }

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Call to undeclared method \Vtiger_Viewer::assign
Open

        $viewer->assign('SELECTED_MODULE', $srcModule);

Call to undeclared method \Vtiger_Viewer::assign
Open

        $viewer->assign('SUPPORTED_MODULES', $modules);

Call to undeclared method \Vtiger_Viewer::assign
Open

        $viewer->assign('WATCHDOG_MODULE', Vtiger_Watchdog_Model::getInstance($srcModule));

Avoid excessively long class names like Settings_Notifications_Configuration_View. Keep class name length under 40.
Open

class Settings_Notifications_Configuration_View extends Settings_Vtiger_Index_View
{
    /**
     * Function gets module settings.
     *

LongClassName

Since: 2.9

Detects when classes or interfaces are declared with excessively long names.

Example

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Source https://phpmd.org/rules/naming.html#longclassname

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Settings_Notifications_Configuration_View extends Settings_Vtiger_Index_View

The class Settings_Notifications_Configuration_View is not named in CamelCase.
Open

class Settings_Notifications_Configuration_View extends Settings_Vtiger_Index_View
{
    /**
     * Function gets module settings.
     *

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

        if ($request->isEmpty('srcModule')) {

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer = $this->getViewer($request);

Spaces must be used to indent lines; tabs are not allowed
Open

            '~libraries/datatables.net/js/jquery.dataTables.js',

Spaces must be used to indent lines; tabs are not allowed
Open

            '~libraries/datatables.net-bs4/js/dataTables.bootstrap4.js',

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param \App\Request $request

Spaces must be used to indent lines; tabs are not allowed
Open

        }

Spaces must be used to indent lines; tabs are not allowed
Open

        ]));

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Spaces must be used to indent lines; tabs are not allowed
Open

    public function process(App\Request $request)

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

            $srcModule = $request->getInteger('srcModule');

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('WATCHDOG_MODULE', Vtiger_Watchdog_Model::getInstance($srcModule));

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

     * @return array - List of Vtiger_JsScript_Model instances

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('SELECTED_MODULE', $srcModule);

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('SUPPORTED_MODULES', $modules);

Spaces must be used to indent lines; tabs are not allowed
Open

            '~libraries/datatables.net-responsive-bs4/js/responsive.bootstrap4.js'

Spaces must be used to indent lines; tabs are not allowed
Open

     * Function gets module settings.

Spaces must be used to indent lines; tabs are not allowed
Open

        } else {

Spaces must be used to indent lines; tabs are not allowed
Open

     * Function to get the list of Script models to be included.

Spaces must be used to indent lines; tabs are not allowed
Open

    public function getFooterScripts(App\Request $request)

Spaces must be used to indent lines; tabs are not allowed
Open

        return array_merge(parent::getFooterScripts($request), $this->checkAndConvertJsScripts([

Spaces must be used to indent lines; tabs are not allowed
Open

            '~libraries/datatables.net-responsive/js/dataTables.responsive.js',

Spaces must be used to indent lines; tabs are not allowed
Open

        $modules = Vtiger_Watchdog_Model::getSupportedModules();

Spaces must be used to indent lines; tabs are not allowed
Open

            $srcModule = key($modules);

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->view('Configuration.tpl', $request->getModule(false));

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param \App\Request $request

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Spaces must be used to indent lines; tabs are not allowed
Open

            reset($modules);

Spaces must be used to indent lines; tabs are not allowed
Open

            'modules.Settings.' . $request->getModule() . '.resources.Configuration',

Class name "Settings_Notifications_Configuration_View" is not in camel caps format
Open

class Settings_Notifications_Configuration_View extends Settings_Vtiger_Index_View

There are no issues that match your filters.

Category
Status