modules/Settings/Notifications/views/Members.php
Avoid using static access to class 'Vtiger_Watchdog_Model' in method 'addWatchingMembers'. Open
Open
$watchdogModel = Vtiger_Watchdog_Model::getInstance($srcModule);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Watchdog_Model' in method 'exceptions'. Open
Open
$watchdogModel = Vtiger_Watchdog_Model::getInstance($srcModule);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('IS_TO_ADD', true);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('MEMBER', $member);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('SRC_MODULE', $srcModule);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('MEMBERS', $watchdogModel->getWatchingExceptions($member));- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('SRC_MODULE', $srcModule);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('RESTRICT_MEMBERS', $watchdogModel->getWatchingMembers());- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Settings_Notifications_Members_View extends Settings_Vtiger_BasicModal_View- Exclude checks
The class Settings_Notifications_Members_View is not named in CamelCase. Open
Open
class Settings_Notifications_Members_View extends Settings_Vtiger_BasicModal_View
{
use \App\Controller\ExposeMethod;
/**- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
use \App\Controller\ExposeMethod;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function addWatchingMembers(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function downloads settings for exceptions.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->postProcess($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->exposeMethod('addWatchingMembers');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function exceptions(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('SRC_MODULE', $srcModule);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Constructor.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param \App\Request $request- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$mode = $request->getMode();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$srcModule = $request->getInteger('srcModule');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function gets settings.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleName = $request->getModule(false);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->preProcess($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer = $this->getViewer($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function process(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->preProcess($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!empty($mode)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$watchdogModel = Vtiger_Watchdog_Model::getInstance($srcModule);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('RESTRICT_MEMBERS', $watchdogModel->getWatchingMembers());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
parent::__construct();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->exposeMethod('exceptions');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->view('Members.tpl', $moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param \App\Request $request- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('MEMBER', $member);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->addWatchingMembers($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->postProcess($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer = $this->getViewer($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function __construct()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$srcModule = $request->getInteger('srcModule');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function downloads settings for watched members.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('IS_TO_ADD', true);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('SRC_MODULE', $srcModule);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleName = $request->getModule(false);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$member = $request->getByType('member', 'Text');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->invokeExposedMethod($mode, $request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$watchdogModel = Vtiger_Watchdog_Model::getInstance($srcModule);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->view('MembersExceptions.tpl', $moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param \App\Request $request- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('MEMBERS', $watchdogModel->getWatchingExceptions($member));- Exclude checks
Class name "Settings_Notifications_Members_View" is not in camel caps format Open
Open
class Settings_Notifications_Members_View extends Settings_Vtiger_BasicModal_View- Exclude checks