modules/Settings/PDF/views/List.php
The method preProcess has a boolean flag argument $display, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function preProcess(App\Request $request, $display = true)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid using static access to class 'Settings_PDF_Module_Model' in method 'preProcess'. Open
Open
$viewer->assign('SUPPORTED_MODULE_MODELS', Settings_PDF_Module_Model::getSupportedModules());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('SUPPORTED_MODULE_MODELS', Settings_PDF_Module_Model::getSupportedModules());- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Settings_PDF_List_View extends Settings_Vtiger_List_View- Exclude checks
The class Settings_PDF_List_View is not named in CamelCase. Open
Open
class Settings_PDF_List_View extends Settings_Vtiger_List_View
{
public function preProcess(App\Request $request, $display = true)
{
$viewer = $this->getViewer($request);- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer = $this->getViewer($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
parent::preProcess($request, $display);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('SUPPORTED_MODULE_MODELS', Settings_PDF_Module_Model::getSupportedModules());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function preProcess(App\Request $request, $display = true)- Exclude checks
Class name "Settings_PDF_List_View" is not in camel caps format Open
Open
class Settings_PDF_List_View extends Settings_Vtiger_List_View- Exclude checks