modules/Settings/PickListDependency/models/ListView.php
Missing class import via use statement (line '22', column '17'). Open
Open
$query = (new App\Db\Query())->from($module->getBaseTable());- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class '\App\Module' in method 'getBasicListQuery'. Open
Open
$query->where(['tabid' => \App\Module::getModuleId($sourceModule)]);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Call to undeclared method \App\Db\Query::from Open
Open
$query = (new App\Db\Query())->from($module->getBaseTable());- Exclude checks
Avoid excessively long class names like Settings_PickListDependency_ListView_Model. Keep class name length under 40. Open
Open
class Settings_PickListDependency_ListView_Model extends Settings_Vtiger_ListView_Model
{
/** {@inheritdoc} */
public function getBasicListQuery(): App\Db\Query
{- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}Source https://phpmd.org/rules/naming.html#longclassname
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Settings_PickListDependency_ListView_Model extends Settings_Vtiger_ListView_Model- Exclude checks
The class Settings_PickListDependency_ListView_Model is not named in CamelCase. Open
Open
class Settings_PickListDependency_ListView_Model extends Settings_Vtiger_ListView_Model
{
/** {@inheritdoc} */
public function getBasicListQuery(): App\Db\Query
{- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $query;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($sourceModule) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$module = $this->getModule();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$query->where(['tabid' => \App\Module::getModuleId($sourceModule)]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$query = (new App\Db\Query())->from($module->getBaseTable());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getBasicListQuery(): App\Db\Query- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$sourceModule = $this->get('sourceModule');- Exclude checks
Class name "Settings_PickListDependency_ListView_Model" is not in camel caps format Open
Open
class Settings_PickListDependency_ListView_Model extends Settings_Vtiger_ListView_Model- Exclude checks