Method row has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function row(App\Request $request): void
{
$sourceModuleName = $request->getByType('sourceModuleName', \App\Purifier::ALNUM);
$sourceField = $request->getByType('sourceField', \App\Purifier::ALNUM);
$sourceModuleModel = Vtiger_Module_Model::getInstance($sourceModuleName);Function row has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function row(App\Request $request): void
{
$sourceModuleName = $request->getByType('sourceModuleName', \App\Purifier::ALNUM);
$sourceField = $request->getByType('sourceField', \App\Purifier::ALNUM);
$sourceModuleModel = Vtiger_Module_Model::getInstance($sourceModuleName);- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid using static access to class '\Vtiger_Module_Model' in method 'builder'. Open
$sourceModuleModel = \Vtiger_Module_Model::getInstance($sourceModuleName);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method row uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$fieldModel = Vtiger_Field_Model::getInstance($fieldName, $sourceModuleModel);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method row uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$fieldInfo = $request->getForSql('fieldname', false);
[$fieldName, $fieldModuleName, $sourceFieldName] = array_pad(explode(':', $fieldInfo), 3, false);
if (!empty($sourceFieldName)) {
$fieldModel = Vtiger_Field_Model::getInstance($fieldName, Vtiger_Module_Model::getInstance($fieldModuleName));- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'Vtiger_Module_Model' in method 'row'. Open
$sourceModuleModel = Vtiger_Module_Model::getInstance($sourceModuleName);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Module_Model' in method 'row'. Open
$fieldModel = Vtiger_Field_Model::getInstance($fieldName, Vtiger_Module_Model::getInstance($fieldModuleName));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Settings_PickListDependency_Module_Model' in method 'row'. Open
$structure = Settings_PickListDependency_Module_Model::getConditionBuilderStructure($sourceModuleModel, $sourceField);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Field_Model' in method 'row'. Open
$fieldModel = Vtiger_Field_Model::getInstance($fieldName, Vtiger_Module_Model::getInstance($fieldModuleName));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Field_Model' in method 'row'. Open
$fieldModel = Vtiger_Field_Model::getInstance($fieldName, $sourceModuleModel);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method row uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$selectedOperator = $request->getByType('operator', \App\Purifier::ALNUM);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'Settings_PickListDependency_Module_Model' in method 'builder'. Open
$viewer->assign('RECORD_STRUCTURE', Settings_PickListDependency_Module_Model::getConditionBuilderStructure($sourceModuleModel, $sourceField));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Call to undeclared function \array_key_first() Open
$selectedOperator = array_key_first($operators);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('RECORD_STRUCTURE_RELATED_MODULES', []);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('RECORD_STRUCTURE_RELATED_MODULES', []);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('FIELD_INFO', $fieldInfo);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('RECORD_STRUCTURE', Settings_PickListDependency_Module_Model::getConditionBuilderStructure($sourceModuleModel, $sourceField));- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('SELECTED_OPERATOR', $selectedOperator);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('SOURCE_MODULE', $sourceModuleName);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('RECORD_STRUCTURE', $structure);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('ADVANCE_CRITERIA', []);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('OPERATORS', $operators);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('SOURCE_MODULE', $sourceModuleName);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('SELECTED_FIELD_MODEL', $fieldModel);- Exclude checks
Identical blocks of code found in 2 locations. Consider refactoring. Open
if ($request->isEmpty('fieldname')) {
$fieldModel = current(current($structure));
} else {
$fieldInfo = $request->getForSql('fieldname', false);
[$fieldName, $fieldModuleName, $sourceFieldName] = array_pad(explode(':', $fieldInfo), 3, false);- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 118.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Avoid excessively long class names like Settings_PickListDependency_ConditionBuilder_View. Keep class name length under 40. Open
class Settings_PickListDependency_ConditionBuilder_View extends Vtiger_ConditionBuilder_View
{
use \App\Controller\Traits\SettingsPermission;
/**- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}Source https://phpmd.org/rules/naming.html#longclassname
Each class must be in a namespace of at least one level (a top-level vendor name) Open
class Settings_PickListDependency_ConditionBuilder_View extends Vtiger_ConditionBuilder_View- Exclude checks
The class Settings_PickListDependency_ConditionBuilder_View is not named in CamelCase. Open
class Settings_PickListDependency_ConditionBuilder_View extends Vtiger_ConditionBuilder_View
{
use \App\Controller\Traits\SettingsPermission;
/**- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function row(App\Request $request): void- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$sourceField = $request->getByType('sourceField', \App\Purifier::ALNUM);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('FIELD_INFO', $fieldInfo);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$sourceModuleName = $request->getByType('sourceModuleName', \App\Purifier::ALNUM);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
use \App\Controller\Traits\SettingsPermission;- Exclude checks
Line exceeds 120 characters; contains 126 characters Open
$fieldModel = Vtiger_Field_Model::getInstance($fieldName, Vtiger_Module_Model::getInstance($fieldModuleName));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$selectedOperator = array_key_first($operators);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$selectedOperator = $request->getByType('operator', \App\Purifier::ALNUM);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('ADVANCE_CRITERIA', []);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* Display the condition builder panel.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @param App\Request $request- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$fieldModel = Vtiger_Field_Model::getInstance($fieldName, $sourceModuleModel);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($request->isEmpty('operator', true)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$fieldInfo = false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('SELECTED_OPERATOR', $selectedOperator);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
[$fieldName, $fieldModuleName, $sourceFieldName] = array_pad(explode(':', $fieldInfo), 3, false);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('SOURCE_MODULE', $sourceModuleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$fieldModel = Vtiger_Field_Model::getInstance($fieldName, Vtiger_Module_Model::getInstance($fieldModuleName));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer = $this->getViewer($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer = $this->getViewer($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function builder(App\Request $request): void- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$sourceField = $request->getByType('sourceField', \App\Purifier::ALNUM);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->view('ConditionBuilder.tpl', $sourceModuleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$structure = Settings_PickListDependency_Module_Model::getConditionBuilderStructure($sourceModuleModel, $sourceField);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!empty($sourceFieldName)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$sourceModuleModel = Vtiger_Module_Model::getInstance($sourceModuleName);- Exclude checks
Line exceeds 120 characters; contains 126 characters Open
$structure = Settings_PickListDependency_Module_Model::getConditionBuilderStructure($sourceModuleModel, $sourceField);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$sourceModuleModel = \Vtiger_Module_Model::getInstance($sourceModuleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* Display one condition for a field.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('SELECTED_FIELD_MODEL', $fieldModel);- Exclude checks
Line exceeds 120 characters; contains 150 characters Open
$viewer->assign('RECORD_STRUCTURE', Settings_PickListDependency_Module_Model::getConditionBuilderStructure($sourceModuleModel, $sourceField));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @return void- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @param App\Request $request- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$sourceModuleName = $request->getByType('sourceModuleName', \App\Purifier::ALNUM);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($request->isEmpty('fieldname')) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$fieldModel = current(current($structure));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$operators = $fieldModel->getRecordOperators();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('RECORD_STRUCTURE_RELATED_MODULES', []);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->view('ConditionBuilderRow.tpl', $sourceModuleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('RECORD_STRUCTURE', Settings_PickListDependency_Module_Model::getConditionBuilderStructure($sourceModuleModel, $sourceField));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @return void- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$fieldInfo = $request->getForSql('fieldname', false);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('OPERATORS', $operators);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('RECORD_STRUCTURE', $structure);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('SOURCE_MODULE', $sourceModuleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('RECORD_STRUCTURE_RELATED_MODULES', []);- Exclude checks
Class name "Settings_PickListDependency_ConditionBuilder_View" is not in camel caps format Open
class Settings_PickListDependency_ConditionBuilder_View extends Vtiger_ConditionBuilder_View- Exclude checks