modules/Settings/PublicHoliday/views/Configuration.php
Avoid using static access to class 'Settings_PublicHoliday_Module_Model' in method 'process'. Open
Open
$moduleModel = Settings_PublicHoliday_Module_Model::getInstance();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'App\Fields\Date' in method 'list'. Open
Open
$viewer->assign('DATE', $date ? implode(',', App\Fields\Date::formatRangeToDisplay($date)) : '');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid assigning values to variables in if clauses and the like (line '27', column '7'). Open
Open
public function process(App\Request $request)
{
if ($mode = $request->getMode()) {
$this->invokeExposedMethod($mode, $request);
return;- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid using static access to class 'Settings_PublicHoliday_Module_Model' in method 'list'. Open
Open
$moduleModel = Settings_PublicHoliday_Module_Model::getInstance();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('DATE', $date ? implode(',', App\Fields\Date::formatRangeToDisplay($date)) : '');- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('HOLIDAYS', $moduleModel->getHolidaysByRange([]));- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('YEAR', date('Y'));- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('DATE', '');- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('HOLIDAYS', $moduleModel->getHolidaysByRange($date));- Exclude checks
Avoid excessively long class names like Settings_PublicHoliday_Configuration_View. Keep class name length under 40. Open
Open
class Settings_PublicHoliday_Configuration_View extends Settings_Vtiger_Index_View
{
/**
* Constructor.
*/- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}Source https://phpmd.org/rules/naming.html#longclassname
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Settings_PublicHoliday_Configuration_View extends Settings_Vtiger_Index_View- Exclude checks
The class Settings_PublicHoliday_Configuration_View is not named in CamelCase. Open
Open
class Settings_PublicHoliday_Configuration_View extends Settings_Vtiger_Index_View
{
/**
* Constructor.
*/- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function process(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->view('Configuration.tpl', $request->getModule(false));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param \App\Request $request- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function __construct()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param \App\Request $request- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('HOLIDAYS', $moduleModel->getHolidaysByRange([]));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
"modules.Settings.{$request->getModule()}.{$view}",- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getHeaderCss(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function list(App\Request $request): void- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($mode = $request->getMode()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('DATE', '');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
]));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer = $this->getViewer($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Constructor.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->view('ConfigurationItems.tpl', $request->getModule(false));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
parent::__construct();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('YEAR', date('Y'));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Returns view for holiday item list by date filtering.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->exposeMethod('list');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleModel = Settings_PublicHoliday_Module_Model::getInstance();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$date = !$request->isEmpty('date', true) ? $request->getDateRange('date') : [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer = $this->getViewer($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('DATE', $date ? implode(',', App\Fields\Date::formatRangeToDisplay($date)) : '');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleModel = Settings_PublicHoliday_Module_Model::getInstance();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->invokeExposedMethod($mode, $request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('HOLIDAYS', $moduleModel->getHolidaysByRange($date));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return array_merge(parent::getHeaderCss($request), $this->checkAndConvertCssStyles([- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Process.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$view = $request->get('view', App\Purifier::STANDARD);- Exclude checks
Class name "Settings_PublicHoliday_Configuration_View" is not in camel caps format Open
Open
class Settings_PublicHoliday_Configuration_View extends Settings_Vtiger_Index_View- Exclude checks