Method process has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function process(App\Request $request)
    {
        $supportedModules = Settings_RecordNumbering_Module_Model::getSupportedModules();
        $sourceModule = $request->getByType('sourceModule', 2);
        $valueParam = $request->getByType('picklist', \App\Purifier::TEXT);

Function process has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

Open

    public function process(App\Request $request)
    {
        $supportedModules = Settings_RecordNumbering_Module_Model::getSupportedModules();
        $sourceModule = $request->getByType('sourceModule', 2);
        $valueParam = $request->getByType('picklist', \App\Purifier::TEXT);

• Read up
  Read up

Missing class import via use statement (line '29', column '26').

Open

        $valueSequences = (new \App\Db\Query())->select(['prefix' => 'value', 'cur_id'])->from('u_#__modentity_sequences')->where(['tabid' => $moduleModel->getId()])->all();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid using static access to class '\App\Fields\Picklist' in method 'process'.

Open

            foreach (\App\Fields\Picklist::getValues($picklistName[1]) as $value) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\TextParser' in method 'process'.

Open

        if (!empty($picklistName[1]) && !\App\TextParser::isVaribleToParse($valueParam) && $moduleModel->getFieldByName($picklistName[1])) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Module' in method 'process'.

Open

            $defaultModuleModel = $supportedModules[\App\Module::getModuleId($sourceModule)];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Language' in method 'preProcessAjax'.

Open

        $this->pageTitle = \App\Language::translate('LBL_ADVANCED_RECORD_NUMBERING', $request->getModule(false));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'Settings_RecordNumbering_Module_Model' in method 'process'.

Open

        $supportedModules = Settings_RecordNumbering_Module_Model::getSupportedModules();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Vtiger_Module_Model' in method 'process'.

Open

        $moduleModel = \Vtiger_Module_Model::getInstance($sourceModule);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $defaultModuleModel = reset($supportedModules);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Define a constant instead of duplicating this literal "cur_id" 3 times.

Open

        $valueSequences = (new \App\Db\Query())->select(['prefix' => 'value', 'cur_id'])->from('u_#__modentity_sequences')->where(['tabid' => $moduleModel->getId()])->all();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "prefix" 4 times.

Open

        $valueSequences = (new \App\Db\Query())->select(['prefix' => 'value', 'cur_id'])->from('u_#__modentity_sequences')->where(['tabid' => $moduleModel->getId()])->all();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Call to method isVaribleToParse from undeclared class \App\TextParser (Did you mean class \Tests\App\TextParser)

Open

        if (!empty($picklistName[1]) && !\App\TextParser::isVaribleToParse($valueParam) && $moduleModel->getFieldByName($picklistName[1])) {

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Settings_RecordNumbering_Advanced_View->dangerBtn

Open

            $this->dangerBtn = '';

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Settings_RecordNumbering_Advanced_View->successBtn

Open

            $this->successBtn = '';

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::select

Open

        $valueSequences = (new \App\Db\Query())->select(['prefix' => 'value', 'cur_id'])->from('u_#__modentity_sequences')->where(['tabid' => $moduleModel->getId()])->all();

• Exclude checks
  • Disable engine
  • Disable check

Static call to undeclared method \App\Controller\ModalSettings::preProcessAjax

Open

        parent::preProcessAjax($request);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Settings_RecordNumbering_Advanced_View->pageTitle

Open

        $this->pageTitle = \App\Language::translate('LBL_ADVANCED_RECORD_NUMBERING', $request->getModule(false));

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Settings_RecordNumbering_Advanced_View::getViewer

Open

        $viewer = $this->getViewer($request);

• Exclude checks
  • Disable engine
  • Disable check

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class Settings_RecordNumbering_Advanced_View extends \App\Controller\ModalSettings

• Exclude checks
  • Disable engine
  • Disable check

The class Settings_RecordNumbering_Advanced_View is not named in CamelCase.

Open

class Settings_RecordNumbering_Advanced_View extends \App\Controller\ModalSettings
{
    /** {@inheritdoc} */
    public function preProcessAjax(App\Request $request)
    {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class class_name {
}

Spaces must be used to indent lines; tabs are not allowed

Open

        $sourceModule = $request->getByType('sourceModule', 2);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $defaultModuleModel = $supportedModules[\App\Module::getModuleId($sourceModule)];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $valueSequences = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer = $this->getViewer($request);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('SUPPORTED_MODULES', $supportedModules);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $defaultModuleModel = reset($supportedModules);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $valueParam = $request->getByType('picklist', \App\Purifier::TEXT);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                if (!empty($value['prefix'])) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('PICKLISTS_VALUES', $valueSequences);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $moduleModel = \Vtiger_Module_Model::getInstance($sourceModule);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ($sourceModule) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!empty($picklistName[1]) && !\App\TextParser::isVaribleToParse($valueParam) && $moduleModel->getFieldByName($picklistName[1])) {

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 140 characters

Open

        if (!empty($picklistName[1]) && !\App\TextParser::isVaribleToParse($valueParam) && $moduleModel->getFieldByName($picklistName[1])) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /** {@inheritdoc} */

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 173 characters

Open

        $valueSequences = (new \App\Db\Query())->select(['prefix' => 'value', 'cur_id'])->from('u_#__modentity_sequences')->where(['tabid' => $moduleModel->getId()])->all();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $supportedModules = Settings_RecordNumbering_Module_Model::getSupportedModules();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $valueSequences = (new \App\Db\Query())->select(['prefix' => 'value', 'cur_id'])->from('u_#__modentity_sequences')->where(['tabid' => $moduleModel->getId()])->all();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $currentValues = array_column($valueSequences, 'cur_id', 'prefix');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $value['cur_id'] = $currentValues[$value['prefix']] ?? 1;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (empty($valueSequences)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->view('Advanced.tpl', $request->getModule(false));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function preProcessAjax(App\Request $request)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        preg_match('/{{picklist:([a-z0-9_]+)}}/i', $valueParam, $picklistName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $valueSequences[] = $value;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->pageTitle = \App\Language::translate('LBL_ADVANCED_RECORD_NUMBERING', $request->getModule(false));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function process(App\Request $request)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $this->dangerBtn = '';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        parent::preProcessAjax($request);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /** {@inheritdoc} */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            foreach (\App\Fields\Picklist::getValues($picklistName[1]) as $value) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $this->successBtn = '';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('DEFAULT_MODULE_MODEL', $defaultModuleModel);

• Exclude checks
  • Disable engine
  • Disable check

Class name "Settings_RecordNumbering_Advanced_View" is not in camel caps format

Open

class Settings_RecordNumbering_Advanced_View extends \App\Controller\ModalSettings

• Exclude checks
  • Disable engine
  • Disable check