Method process has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function process(App\Request $request)
    {
        $qualifiedModuleName = $request->getModule(false);
        $supportedModules = Settings_RecordNumbering_Module_Model::getSupportedModules();
        $sourceModule = $request->getByType('sourceModule', 2);

Function process has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.

Open

    public function process(App\Request $request)
    {
        $qualifiedModuleName = $request->getModule(false);
        $supportedModules = Settings_RecordNumbering_Module_Model::getSupportedModules();
        $sourceModule = $request->getByType('sourceModule', 2);

• Read up
  Read up

Avoid using static access to class 'App\TextParser' in method 'process'.

Open

        $textParser = App\TextParser::getInstance($defaultModuleModel->getName());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Language' in method 'process'.

Open

                $blockName = \App\Language::translate($blockName, $defaultModuleModel->getName());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'Settings_RecordNumbering_Module_Model' in method 'process'.

Open

        $supportedModules = Settings_RecordNumbering_Module_Model::getSupportedModules();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Module' in method 'process'.

Open

            $defaultModuleModel = $supportedModules[\App\Module::getModuleId($sourceModule)];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Language' in method 'process'.

Open

                    $referenceFields[$blockName][$field['var_value']] = \App\Language::translate($field['label'], $defaultModuleModel->getName());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Fields\Picklist' in method 'process'.

Open

            if (\App\Fields\Picklist::prefixExist($fieldModel->getFieldName())) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $defaultModuleModel = reset($supportedModules);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Call to method getInstance from undeclared class \App\TextParser (Did you mean class \Tests\App\TextParser)

Open

        $textParser = App\TextParser::getInstance($defaultModuleModel->getName());

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('SUPPORTED_MODULES', $supportedModules);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('DEFAULT_MODULE_MODEL', $defaultModuleModel);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('PICKLISTS', $picklistFields);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('IS_AJAX', $request->isAjax());

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('REFERENCE_FIELDS', $referenceFields);

• Exclude checks
  • Disable engine
  • Disable check

Avoid excessively long class names like Settings_RecordNumbering_CustomRecordNumbering_View. Keep class name length under 40.

Open

class Settings_RecordNumbering_CustomRecordNumbering_View extends Settings_Vtiger_Index_View
{
    /** {@inheritdoc} */
    protected $pageTitle = 'LBL_CUSTOMIZE_RECORD_NUMBERING';

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class Settings_RecordNumbering_CustomRecordNumbering_View extends Settings_Vtiger_Index_View

• Exclude checks
  • Disable engine
  • Disable check

The class Settings_RecordNumbering_CustomRecordNumbering_View is not named in CamelCase.

Open

class Settings_RecordNumbering_CustomRecordNumbering_View extends Settings_Vtiger_Index_View
{
    /** {@inheritdoc} */
    protected $pageTitle = 'LBL_CUSTOMIZE_RECORD_NUMBERING';

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class class_name {
}

Spaces must be used to indent lines; tabs are not allowed

Open

                $picklistFields[$fieldModel->getName()] = $fieldModel;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'libraries.clipboard.dist.clipboard',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $picklistFields = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $textParser = App\TextParser::getInstance($defaultModuleModel->getName());

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    protected $pageTitle = 'LBL_CUSTOMIZE_RECORD_NUMBERING';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        foreach ($textParser->getRelatedVariable('string') as $modules) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('REFERENCE_FIELDS', $referenceFields);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('IS_AJAX', $request->isAjax());

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ($sourceModule) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $defaultModuleModel = $supportedModules[\App\Module::getModuleId($sourceModule)];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        foreach ($picklistsModels as $fieldModel) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('DEFAULT_MODULE_MODEL', $defaultModuleModel);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $referenceFields = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                foreach ($fields as $field) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return array_merge(parent::getFooterScripts($request), $this->checkAndConvertJsScripts([

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $sourceModule = $request->getByType('sourceModule', 2);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        ]));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer = $this->getViewer($request);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /** {@inheritdoc} */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $defaultModuleModel = reset($supportedModules);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            foreach ($modules as $blockName => $fields) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'modules.Settings.Vtiger.resources.Edit',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $qualifiedModuleName = $request->getModule(false);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $referenceFields[$blockName][$field['var_value']] = \App\Language::translate($field['label'], $defaultModuleModel->getName());

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->view('CustomRecordNumbering.tpl', $qualifiedModuleName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $supportedModules = Settings_RecordNumbering_Module_Model::getSupportedModules();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function process(App\Request $request)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function getFooterScripts(App\Request $request)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $blockName = \App\Language::translate($blockName, $defaultModuleModel->getName());

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('SUPPORTED_MODULES', $supportedModules);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('PICKLISTS', $picklistFields);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /** {@inheritdoc} */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $picklistsModels = $defaultModuleModel->getFieldsByType(['picklist']);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if (\App\Fields\Picklist::prefixExist($fieldModel->getFieldName())) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /** {@inheritdoc} */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        } else {

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 146 characters

Open

                    $referenceFields[$blockName][$field['var_value']] = \App\Language::translate($field['label'], $defaultModuleModel->getName());

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                }

• Exclude checks
  • Disable engine
  • Disable check

Class name "Settings_RecordNumbering_CustomRecordNumbering_View" is not in camel caps format

Open

class Settings_RecordNumbering_CustomRecordNumbering_View extends Settings_Vtiger_Index_View

• Exclude checks
  • Disable engine
  • Disable check