Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Settings/Roles/views/Edit.php

Summary

Maintainability
A
1 hr
Test Coverage
F
0%

Method process has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function process(App\Request $request)
    {
        $viewer = $this->getViewer($request);
        $moduleName = $request->getModule();
        $qualifiedModuleName = $request->getModule(false);
Severity: Minor
Found in modules/Settings/Roles/views/Edit.php - About 1 hr to fix

    Missing class import via use statement (line '30', column '23').
    Open

                $recordModel = new Settings_Roles_Record_Model();
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class 'Settings_Profiles_Record_Model' in method 'process'.
    Open

            $viewer->assign('ALL_PROFILES', Settings_Profiles_Record_Model::getAll());
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            $parentRoleId = $request->getByType('parent_roleid', 'Alnum');
            $recordModel = new Settings_Roles_Record_Model();
            $recordModel->setParent(Settings_Roles_Record_Model::getInstanceById($parentRoleId));
            $roleDirectlyRelated = true;
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class 'Settings_Roles_Record_Model' in method 'process'.
    Open

                $recordModel = Settings_Roles_Record_Model::getInstanceById($record);
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Settings_Roles_Record_Model' in method 'process'.
    Open

                $recordModel->setParent(Settings_Roles_Record_Model::getInstanceById($parentRoleId));
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Define a constant instead of duplicating this literal "Alnum" 3 times.
    Open

            $record = $request->getByType('record', 'Alnum');
    Severity: Critical
    Found in modules/Settings/Roles/views/Edit.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('ALL_PROFILES', Settings_Profiles_Record_Model::getAll());
    Severity: Critical
    Found in modules/Settings/Roles/views/Edit.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('PROFILE_DIRECTLY_RELATED_TO_ROLE', $roleDirectlyRelated);
    Severity: Critical
    Found in modules/Settings/Roles/views/Edit.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('MODULE', $moduleName);
    Severity: Critical
    Found in modules/Settings/Roles/views/Edit.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

                $viewer->assign('PROFILE_ID', $profileId);
    Severity: Critical
    Found in modules/Settings/Roles/views/Edit.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('TYPE', $request->getByType('type', 'Alnum'));
    Severity: Critical
    Found in modules/Settings/Roles/views/Edit.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('RECORD_ID', $record);
    Severity: Critical
    Found in modules/Settings/Roles/views/Edit.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('ROLE_USERS', $recordModel->getUsers());
    Severity: Critical
    Found in modules/Settings/Roles/views/Edit.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('RECORD_MODEL', $recordModel);
    Severity: Critical
    Found in modules/Settings/Roles/views/Edit.php by phan

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class Settings_Roles_Edit_View extends Settings_Roles_Index_View
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    The class Settings_Roles_Edit_View is not named in CamelCase.
    Open

    class Settings_Roles_Edit_View extends Settings_Roles_Index_View
{
    /**
     * Process.
     *
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer = $this->getViewer($request);
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Process.
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $viewer->assign('PROFILE_ID', $profileId);
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $moduleName = $request->getModule();
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty($record)) {
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $record = $request->getByType('record', 'Alnum');
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $parentRoleId = $request->getByType('parent_roleid', 'Alnum');
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $recordModel = new Settings_Roles_Record_Model();
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $roleDirectlyRelated = true;
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('RECORD_ID', $record);
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('RECORD_MODEL', $recordModel);
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function process(App\Request $request)
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $recordModel = Settings_Roles_Record_Model::getInstanceById($record);
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $roleDirectlyRelated = true;
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('ALL_PROFILES', Settings_Profiles_Record_Model::getAll());
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $profileId = $recordModel->getDirectlyRelatedProfileId();
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $roleDirectlyRelated = false;
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($profileId) {
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('ROLE_USERS', $recordModel->getUsers());
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->view('EditView.tpl', $qualifiedModuleName);
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            } else {
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param \App\Request $request
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('PROFILE_DIRECTLY_RELATED_TO_ROLE', $roleDirectlyRelated);
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $qualifiedModuleName = $request->getModule(false);
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $recordModel->setParent(Settings_Roles_Record_Model::getInstanceById($parentRoleId));
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('MODULE', $moduleName);
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('TYPE', $request->getByType('type', 'Alnum'));
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    Class name "Settings_Roles_Edit_View" is not in camel caps format
    Open

    class Settings_Roles_Edit_View extends Settings_Roles_Index_View
    Severity: Minor
    Found in modules/Settings/Roles/views/Edit.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status