YetiForceCompany/YetiForceCRM

View on GitHub
modules/Settings/SlaPolicy/models/Module.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Define a constant instead of duplicating this literal "ServiceContracts" 5 times.
Open

        'operational_hours' => ['LBL_OPERATIONAL_HOURS', 'ServiceContracts'],

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Settings_SlaPolicy_Module_Model extends Settings_Vtiger_Module_Model

The class Settings_SlaPolicy_Module_Model is not named in CamelCase.
Open

class Settings_SlaPolicy_Module_Model extends Settings_Vtiger_Module_Model
{
    /**
     * Base table.
     *

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

     * Base index.

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

        'tabid' => 'LBL_SOURCE_MODULE',

Spaces must be used to indent lines; tabs are not allowed
Open

        'resolve_time' => ['LBL_RESOLVE_TIME', 'ServiceContracts'],

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

        'business_hours' => ['LBL_BUSINESS_HOURS', 'ServiceContracts']

Spaces must be used to indent lines; tabs are not allowed
Open

    public function getDefaultUrl()

Spaces must be used to indent lines; tabs are not allowed
Open

     * @var string

Spaces must be used to indent lines; tabs are not allowed
Open

     * List fields.

Spaces must be used to indent lines; tabs are not allowed
Open

    public $name = 'SlaPolicy';

Spaces must be used to indent lines; tabs are not allowed
Open

     * Base table.

Spaces must be used to indent lines; tabs are not allowed
Open

    public $baseTable = 's_#__sla_policy';

Spaces must be used to indent lines; tabs are not allowed
Open

     * @var string

Spaces must be used to indent lines; tabs are not allowed
Open

     * Get edit record url.

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

    public $listFields = [

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

        'idle_time' => ['LBL_IDLE_TIME', 'ServiceContracts'],

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

        return 'index.php?module=SlaPolicy&parent=Settings&view=Edit';

Spaces must be used to indent lines; tabs are not allowed
Open

        'name' => 'LBL_NAME',

Spaces must be used to indent lines; tabs are not allowed
Open

        'operational_hours' => ['LBL_OPERATIONAL_HOURS', 'ServiceContracts'],

Spaces must be used to indent lines; tabs are not allowed
Open

     * Module name.

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

    ];

Spaces must be used to indent lines; tabs are not allowed
Open

        return 'index.php?module=SlaPolicy&parent=Settings&view=List';

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Spaces must be used to indent lines; tabs are not allowed
Open

    public $baseIndex = 'id';

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

     * @var string

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param int $recordId

Spaces must be used to indent lines; tabs are not allowed
Open

     * @var array

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Spaces must be used to indent lines; tabs are not allowed
Open

     * @return string

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

        'reaction_time' => ['LBL_REACTION_TIME', 'ServiceContracts'],

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

    public function getCreateRecordUrl()

Spaces must be used to indent lines; tabs are not allowed
Open

    public function getEditRecordUrl(int $recordId)

Spaces must be used to indent lines; tabs are not allowed
Open

        return 'index.php?module=SlaPolicy&parent=Settings&view=Edit&record=' . $recordId;

Class name "Settings_SlaPolicy_Module_Model" is not in camel caps format
Open

class Settings_SlaPolicy_Module_Model extends Settings_Vtiger_Module_Model

There are no issues that match your filters.

Category
Status