YetiForceCompany/YetiForceCRM

Method process has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function process(App\Request $request)
    {
        $viewer = $this->getViewer($request);
        $moduleName = $request->getModule();
        $qualifiedModuleName = $request->getModule(false);

Avoid using static access to class '\App\Module' in method 'process'.

Open

        $sourceModuleName = $tabId ? \App\Module::getModuleName($tabId) : 'HelpDesk';

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'Settings_SlaPolicy_Record_Model' in method 'process'.

Open

            $recordModel = Settings_SlaPolicy_Record_Model::getInstanceById($record);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'Settings_SlaPolicy_Record_Model' in method 'process'.

Open

        $recordModel = Settings_SlaPolicy_Record_Model::getCleanInstance();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'Vtiger_Module_Model' in method 'process'.

Open

                $recordStructureModulesField[$relatedModuleName][$referenceField->getFieldName()] = Vtiger_RecordStructure_Model::getInstanceForModule(Vtiger_Module_Model::getInstance($relatedModuleName))->getStructure();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'Vtiger_Module_Model' in method 'process'.

Open

        $sourceModuleModel = Vtiger_Module_Model::getInstance($sourceModuleName);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Json' in method 'process'.

Open

        $viewer->assign('ADVANCE_CRITERIA', \App\Json::decode($recordModel->get('conditions')));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Call to deprecated function \Vtiger_Field_Model::getFieldName() defined at /code/modules/Vtiger/models/Field.php:203

Open

                $recordStructureModulesField[$relatedModuleName][$referenceField->getFieldName()] = Vtiger_RecordStructure_Model::getInstanceForModule(Vtiger_Module_Model::getInstance($relatedModuleName))->getStructure();

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('RECORD_ID', $record);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('QUALIFIED_MODULE', $qualifiedModuleName);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('SOURCE_MODULE', $sourceModuleName);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('ADVANCE_CRITERIA', \App\Json::decode($recordModel->get('conditions')));

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('RECORD', $recordModel);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('RECORD_STRUCTURE_RELATED_MODULES', $recordStructureModulesField);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('MODULE', $moduleName);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('RECORD_STRUCTURE', Vtiger_RecordStructure_Model::getInstanceForModule($sourceModuleModel)->getStructure());

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('CURRENTDATE', date('Y-n-j'));

• Exclude checks
  • Disable engine
  • Disable check

Avoid excessively long variable names like $recordStructureModulesField. Keep variable name length under 20.

Open

        $recordStructureModulesField = [];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class Settings_SlaPolicy_Conditions_View extends Settings_Vtiger_Index_View

• Exclude checks
  • Disable engine
  • Disable check

The class Settings_SlaPolicy_Conditions_View is not named in CamelCase.

Open

class Settings_SlaPolicy_Conditions_View extends Settings_Vtiger_Index_View
{
    /**
     * Process.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class class_name {
}

The closing brace for the class must go on the next line after the body

Open

}

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Process.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function process(App\Request $request)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $qualifiedModuleName = $request->getModule(false);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('SOURCE_MODULE', $sourceModuleName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $recordStructureModulesField = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('ADVANCE_CRITERIA', \App\Json::decode($recordModel->get('conditions')));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('RECORD_STRUCTURE', Vtiger_RecordStructure_Model::getInstanceForModule($sourceModuleModel)->getStructure());

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $record = $request->getByType('record', 'Alnum');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $recordModel = Settings_SlaPolicy_Record_Model::getInstanceById($record);

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 132 characters

Open

        $viewer->assign('RECORD_STRUCTURE', Vtiger_RecordStructure_Model::getInstanceForModule($sourceModuleModel)->getStructure());

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $moduleName = $request->getModule();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('RECORD_STRUCTURE_RELATED_MODULES', $recordStructureModulesField);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $recordModel = Settings_SlaPolicy_Record_Model::getCleanInstance();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!empty($record)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $tabId = $recordModel->get('tabid');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $recordStructureModulesField[$relatedModuleName][$referenceField->getFieldName()] = Vtiger_RecordStructure_Model::getInstanceForModule(Vtiger_Module_Model::getInstance($relatedModuleName))->getStructure();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('RECORD_ID', $record);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            foreach ($referenceField->getReferenceList() as $relatedModuleName) {

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 221 characters

Open

                $recordStructureModulesField[$relatedModuleName][$referenceField->getFieldName()] = Vtiger_RecordStructure_Model::getInstanceForModule(Vtiger_Module_Model::getInstance($relatedModuleName))->getStructure();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('MODULE', $moduleName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param \App\Request $request

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        foreach ($sourceModuleModel->getFieldsByReference() as $referenceField) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer = $this->getViewer($request);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $sourceModuleName = $tabId ? \App\Module::getModuleName($tabId) : 'HelpDesk';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $sourceModuleModel = Vtiger_Module_Model::getInstance($sourceModuleName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('CURRENTDATE', date('Y-n-j'));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('RECORD', $recordModel);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('QUALIFIED_MODULE', $qualifiedModuleName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->view('ConditionBuilder.tpl', $qualifiedModuleName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Class name "Settings_SlaPolicy_Conditions_View" is not in camel caps format

Open

class Settings_SlaPolicy_Conditions_View extends Settings_Vtiger_Index_View

• Exclude checks
  • Disable engine
  • Disable check