modules/Settings/TreesManager/models/ListView.php
Avoid using static access to class '\App\Module' in method 'loadListViewCondition'. Open
Open
$listQuery->where(['tabid' => \App\Module::getModuleId($sourceModule)]);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Call to undeclared method \App\Db\Query::where Open
Open
$listQuery->where(['tabid' => \App\Module::getModuleId($sourceModule)]);- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Settings_TreesManager_ListView_Model extends Settings_Vtiger_ListView_Model- Exclude checks
The class Settings_TreesManager_ListView_Model is not named in CamelCase. Open
Open
class Settings_TreesManager_ListView_Model extends Settings_Vtiger_ListView_Model
{
/** {@inheritdoc} */
public function loadListViewCondition(): App\Db\Query
{- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function loadListViewCondition(): App\Db\Query- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $listQuery;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$listQuery->where(['tabid' => \App\Module::getModuleId($sourceModule)]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$listQuery = $this->getBasicListQuery();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!empty($sourceModule)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$sourceModule = $this->get('sourceModule');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Class name "Settings_TreesManager_ListView_Model" is not in camel caps format Open
Open
class Settings_TreesManager_ListView_Model extends Settings_Vtiger_ListView_Model- Exclude checks