YetiForceCompany/YetiForceCRM

Method process has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function process(App\Request $request)
    {
        $viewer = $this->getViewer($request);
        $moduleName = $request->getModule();
        $qualifiedModuleName = $request->getModule(false);

Avoid using static access to class 'Settings_TreesManager_Record_Model' in method 'process'.

Open

            $recordModel = Settings_TreesManager_Record_Model::getInstanceById($record);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Json' in method 'process'.

Open

        $viewer->assign('TREE', \App\Json::encode($tree));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $recordModel = Settings_TreesManager_Record_Model::getCleanInstance();
            $viewer->assign('MODE', '');
            $recordModel->set('lastId', 0);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class 'Settings_TreesManager_Record_Model' in method 'process'.

Open

            $recordModel = Settings_TreesManager_Record_Model::getCleanInstance();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Call to undeclared method \Vtiger_Viewer::assign

Open

            $viewer->assign('MODE', '');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('RECORD_ID', $record);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('MODULE', $moduleName);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('TREE', \App\Json::encode($tree));

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('ACCESS', $access);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

            $viewer->assign('MODE', 'edit');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('RECORD_MODEL', $recordModel);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('QUALIFIED_MODULE', $qualifiedModuleName);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('LAST_ID', $recordModel->get('lastId'));

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('SOURCE_MODULE', $sourceModuleId);

• Exclude checks
  • Disable engine
  • Disable check

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class Settings_TreesManager_Edit_View extends Settings_Vtiger_Index_View

• Exclude checks
  • Disable engine
  • Disable check

The class Settings_TreesManager_Edit_View is not named in CamelCase.

Open

class Settings_TreesManager_Edit_View extends Settings_Vtiger_Index_View
{
    /** {@inheritdoc} */
    public function process(App\Request $request)
    {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class class_name {
}

Spaces must be used to indent lines; tabs are not allowed

Open

    /** {@inheritdoc} */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer = $this->getViewer($request);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function process(App\Request $request)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $access = 1;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /** {@inheritdoc} */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('TREE', \App\Json::encode($tree));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $moduleName = $request->getModule();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $sourceModuleId = $recordModel->get('tabid');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $viewer->assign('MODE', 'edit');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $recordModel = Settings_TreesManager_Record_Model::getCleanInstance();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            '~libraries/jstree/dist/jstree.js',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            "modules.Settings.{$request->getModule()}.resources.Edit",

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('SOURCE_MODULE', $sourceModuleId);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('MODULE', $moduleName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('ACCESS', $access);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        ]));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->view('EditView.tpl', $qualifiedModuleName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return array_merge(parent::getFooterScripts($request), $this->checkAndConvertJsScripts([

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $recordModel->set('lastId', 0);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function getHeaderCss(App\Request $request)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $recordModel = Settings_TreesManager_Record_Model::getInstanceById($record);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('RECORD_ID', $record);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $access = $recordModel->get('access');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $tree = $recordModel->getTree();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $qualifiedModuleName = $request->getModule(false);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $record = $request->getInteger('record');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $sourceModuleId = '';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $viewer->assign('MODE', '');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function getFooterScripts(App\Request $request)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!empty($record)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('RECORD_MODEL', $recordModel);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('QUALIFIED_MODULE', $qualifiedModuleName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /** {@inheritdoc} */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        ]), parent::getHeaderCss($request));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('LAST_ID', $recordModel->get('lastId'));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return array_merge($this->checkAndConvertCssStyles([

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            '~libraries/jstree-bootstrap-theme/dist/themes/proton/style.css',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Class name "Settings_TreesManager_Edit_View" is not in camel caps format

Open

class Settings_TreesManager_Edit_View extends Settings_Vtiger_Index_View

• Exclude checks
  • Disable engine
  • Disable check