Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Settings/TreesManager/views/List.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

The method preProcess has a boolean flag argument $display, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function preProcess(App\Request $request, $display = true)
Severity: Minor
Found in modules/Settings/TreesManager/views/List.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Call to undeclared method \Vtiger_Viewer::assign
Open

        $viewer->assign('SUPPORTED_MODULE_MODELS', Settings_TreesManager_Module_Model::getInstance('Settings:TreesManager')->getSupportedModules());
Severity: Critical
Found in modules/Settings/TreesManager/views/List.php by phan

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Settings_TreesManager_List_View extends Settings_Vtiger_List_View
Severity: Minor
Found in modules/Settings/TreesManager/views/List.php by phpcodesniffer

The class Settings_TreesManager_List_View is not named in CamelCase.
Open

class Settings_TreesManager_List_View extends Settings_Vtiger_List_View
{
    /** {@inheritdoc} */
    public function preProcess(App\Request $request, $display = true)
    {
Severity: Minor
Found in modules/Settings/TreesManager/views/List.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

        parent::preProcess($request, $display);
Severity: Minor
Found in modules/Settings/TreesManager/views/List.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Settings/TreesManager/views/List.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer = $this->getViewer($request);
Severity: Minor
Found in modules/Settings/TreesManager/views/List.php by phpcodesniffer

Line exceeds 120 characters; contains 148 characters
Open

        $viewer->assign('SUPPORTED_MODULE_MODELS', Settings_TreesManager_Module_Model::getInstance('Settings:TreesManager')->getSupportedModules());
Severity: Minor
Found in modules/Settings/TreesManager/views/List.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function preProcess(App\Request $request, $display = true)
Severity: Minor
Found in modules/Settings/TreesManager/views/List.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Settings/TreesManager/views/List.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('SUPPORTED_MODULE_MODELS', Settings_TreesManager_Module_Model::getInstance('Settings:TreesManager')->getSupportedModules());
Severity: Minor
Found in modules/Settings/TreesManager/views/List.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Settings/TreesManager/views/List.php by phpcodesniffer

Class name "Settings_TreesManager_List_View" is not in camel caps format
Open

class Settings_TreesManager_List_View extends Settings_Vtiger_List_View
Severity: Minor
Found in modules/Settings/TreesManager/views/List.php by phpcodesniffer

There are no issues that match your filters.

Category
Status