modules/Settings/Updates/models/Module.php
Missing class import via use statement (line '13', column '15'). Open
Open
return (new App\Db\Query())->from('yetiforce_updates')->orderBy(['id' => SORT_DESC])->all();- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Call to undeclared method \App\Db\Query::from Open
Open
return (new App\Db\Query())->from('yetiforce_updates')->orderBy(['id' => SORT_DESC])->all();- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Settings_Updates_Module_Model extends Settings_Vtiger_Module_Model- Exclude checks
The class Settings_Updates_Module_Model is not named in CamelCase. Open
Open
class Settings_Updates_Module_Model extends Settings_Vtiger_Module_Model
{
public static function getUpdates()
{
return (new App\Db\Query())->from('yetiforce_updates')->orderBy(['id' => SORT_DESC])->all();- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
public static function getUpdates()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return (new App\Db\Query())->from('yetiforce_updates')->orderBy(['id' => SORT_DESC])->all();- Exclude checks
Class name "Settings_Updates_Module_Model" is not in camel caps format Open
Open
class Settings_Updates_Module_Model extends Settings_Vtiger_Module_Model- Exclude checks