Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Settings/Users/views/Locks.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Avoid using static access to class 'Settings_Users_Module_Model' in method 'process'.
Open

        $moduleModel = Settings_Users_Module_Model::getInstance();
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Property \Settings_Users_Locks_View->pageTitle has undeclared type \type
Open

    protected $pageTitle = 'LBL_LOCKS';
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phan

Call to undeclared method \Vtiger_Viewer::assign
Open

        $viewer->assign('MODULE', $moduleName);
Severity: Critical
Found in modules/Settings/Users/views/Locks.php by phan

Call to undeclared method \Vtiger_Viewer::assign
Open

        $viewer->assign('QUALIFIED_MODULE', $qualifiedModuleName);
Severity: Critical
Found in modules/Settings/Users/views/Locks.php by phan

Assigning string to property but \Settings_Users_Locks_View->pageTitle is \type
Open

    protected $pageTitle = 'LBL_LOCKS';
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phan

Call to undeclared method \Vtiger_Viewer::assign
Open

        $viewer->assign('LOCKS', $moduleModel->getLocks());
Severity: Critical
Found in modules/Settings/Users/views/Locks.php by phan

Call to undeclared method \Vtiger_Viewer::assign
Open

        $viewer->assign('MODULE_MODEL', $moduleModel);
Severity: Critical
Found in modules/Settings/Users/views/Locks.php by phan

Call to undeclared method \Vtiger_Viewer::assign
Open

        $viewer->assign('LOCKS_TYPE', $moduleModel->getLocksTypes());
Severity: Critical
Found in modules/Settings/Users/views/Locks.php by phan

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Settings_Users_Locks_View extends Settings_Vtiger_Index_View
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

The class Settings_Users_Locks_View is not named in CamelCase.
Open

class Settings_Users_Locks_View extends Settings_Vtiger_Index_View
{
    /**
     * Page title.
     *
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

     *
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            "modules.Settings.{$request->getModule()}.resources.Locks",
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer = $this->getViewer($request);
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('MODULE', $moduleName);
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        ]));
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('LOCKS', $moduleModel->getLocks());
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * Page title.
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $moduleModel = Settings_Users_Module_Model::getInstance();
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('LOCKS_TYPE', $moduleModel->getLocksTypes());
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    protected $pageTitle = 'LBL_LOCKS';
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $qualifiedModuleName = $request->getModule(false);
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('MODULE_MODEL', $moduleModel);
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $moduleName = $request->getModule();
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @var type
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function process(App\Request $request)
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('QUALIFIED_MODULE', $qualifiedModuleName);
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->view('Locks.tpl', $qualifiedModuleName);
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return array_merge(parent::getFooterScripts($request), $this->checkAndConvertJsScripts([
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function getFooterScripts(App\Request $request)
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

Class name "Settings_Users_Locks_View" is not in camel caps format
Open

class Settings_Users_Locks_View extends Settings_Vtiger_Index_View
Severity: Minor
Found in modules/Settings/Users/views/Locks.php by phpcodesniffer

There are no issues that match your filters.

Category
Status