modules/Settings/Vtiger/models/Record.php
Avoid using static access to class '\App\Purifier' in method 'getDisplayValue'. Open
Open
return \App\Purifier::encodeHtml($this->get($key));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Link_Model' in method 'getRecordLinks'. Open
Open
$links[] = Vtiger_Link_Model::getInstanceFromValues($recordLink);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
abstract class Settings_Vtiger_Record_Model extends App\Base- Exclude checks
The class Settings_Vtiger_Record_Model is not named in CamelCase. Open
Open
abstract class Settings_Vtiger_Record_Model extends App\Base
{
/**
* Record ID.
*- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Record name.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $key- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
abstract public function getName();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getRecordLinks(): array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$links[] = Vtiger_Link_Model::getInstanceFromValues($recordLink);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getDisplayValue(string $key)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
abstract public function getId();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return int- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return mixed- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Get record links.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Record ID.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return Vtiger_Link_Model[]- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $links;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Get display value.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return \App\Purifier::encodeHtml($this->get($key));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$recordLinks = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$links = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($recordLinks as $recordLink) {- Exclude checks
Class name "Settings_Vtiger_Record_Model" is not in camel caps format Open
Open
abstract class Settings_Vtiger_Record_Model extends App\Base- Exclude checks