Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Settings/Vtiger/views/List.php

Summary

Maintainability
B
4 hrs
Test Coverage
F
0%

Method initializeListViewContents has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function initializeListViewContents(App\Request $request, Vtiger_Viewer $viewer)
    {
        $qualifiedModuleName = $request->getModule(false);
        $pageNumber = $request->getInteger('page');
        $orderBy = $request->getForSql('orderby');
Severity: Major
Found in modules/Settings/Vtiger/views/List.php - About 3 hrs to fix

    Function initializeListViewContents has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public function initializeListViewContents(App\Request $request, Vtiger_Viewer $viewer)
    {
        $qualifiedModuleName = $request->getModule(false);
        $pageNumber = $request->getInteger('page');
        $orderBy = $request->getForSql('orderby');
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method initializeListViewContents() has an NPath complexity of 12288. The configured NPath complexity threshold is 200.
    Open

        public function initializeListViewContents(App\Request $request, Vtiger_Viewer $viewer)
    {
        $qualifiedModuleName = $request->getModule(false);
        $pageNumber = $request->getInteger('page');
        $orderBy = $request->getForSql('orderby');
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
    function bar() {
        // lots of complicated code
    }
}

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method initializeListViewContents() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
    Open

        public function initializeListViewContents(App\Request $request, Vtiger_Viewer $viewer)
    {
        $qualifiedModuleName = $request->getModule(false);
        $pageNumber = $request->getInteger('page');
        $orderBy = $request->getForSql('orderby');
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Missing class import via use statement (line '77', column '22').
    Open

            $pagingModel = new Vtiger_Paging_Model();
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The method preProcess has a boolean flag argument $display, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function preProcess(App\Request $request, $display = true)
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method initializeListViewContents uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            $nextSortOrder = 'ASC';
            $sortImage = 'fas fa-chevron-up';
        }
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class 'Settings_Vtiger_ListView_Model' in method 'initializeListViewContents'.
    Open

                $this->listViewModel = Settings_Vtiger_ListView_Model::getInstance($qualifiedModuleName);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Define a constant instead of duplicating this literal "sourceModule" 5 times.
    Open

            if (!$request->isEmpty('sourceModule')) {
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "forModule" 3 times.
    Open

            if (!$request->isEmpty('forModule')) {
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "search_key" 3 times.
    Open

            $searchKey = $request->isEmpty('search_key') ? false : $request->getByType('search_key', 'Alnum');
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('LISTVIEW_LINKS', $this->listViewLinks);
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('PAGE_NUMBER', $pageNumber);
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('PAGE_COUNT', $pageCount);
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('START_PAGIN_FROM', $startPaginFrom);
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by phan

    Reference to undeclared property \Settings_Vtiger_List_View->listViewCount
    Open

            $totalCount = $this->listViewCount;
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

                $viewer->assign('SEARCH_PARAMS', $searchParams);
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('LISTVIEW_ENTRIES', $this->listViewEntries);
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by phan

    Argument 1 (var) is false but \count() takes \Countable|array
    Open

            $noOfEntries = \count($this->listViewEntries);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('SORT_IMAGE', $sortImage);
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

                $viewer->assign('SOURCE_MODULE', $sourceModule);
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by phan

    Assigning array to property but \Settings_Vtiger_List_View->listViewHeaders is false
    Open

                $this->listViewHeaders = $model->getListViewHeaders();
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phan

    Reference to undeclared property \Settings_Vtiger_List_View->listViewLinks
    Open

                $this->listViewLinks = $model->getListViewLinks();
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phan

    Reference to undeclared property \Settings_Vtiger_List_View->listViewCount
    Open

                $this->listViewCount = $model->getListViewCount();
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phan

    Return type of getFooterScripts() is undeclared type \App\Controller\View\Vtiger_JsScript_Model[]
    Open

        public function getFooterScripts(App\Request $request)
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('NEXT_SORT_ORDER', $nextSortOrder);
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by phan

    Reference to undeclared property \Settings_Vtiger_List_View->listViewLinks
    Open

            $viewer->assign('LISTVIEW_LINKS', $this->listViewLinks);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('LISTVIEW_ENTRIES_COUNT', $noOfEntries);
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by phan

    Reference to undeclared property \Settings_Vtiger_List_View->listViewLinks
    Open

            if (!isset($this->listViewLinks)) {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('MODULE_MODEL', $model->getModule());
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by phan

    Reference to undeclared property \Settings_Vtiger_List_View->listViewCount
    Open

            if (!isset($this->listViewCount)) {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('LISTVIEW_HEADERS', $this->listViewHeaders);
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('SORT_ORDER', $sortOrder);
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('ORDER_BY', $orderBy);
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by phan

    Assigning \Settings_Vtiger_Record_Model[] to property but \Settings_Vtiger_List_View->listViewEntries is false
    Open

                $this->listViewEntries = $model->getListViewEntries($pagingModel);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('PAGING_MODEL', $pagingModel);
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('COLUMN_NAME', $orderBy);
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by phan

    Saw unextractable annotation for comment '* @return <array> - List of Vtiger_JsScript_Model instances'</array>
    Open

         * @return <Array> - List of Vtiger_JsScript_Model instances
    Severity: Info
    Found in modules/Settings/Vtiger/views/List.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('LISTVIEW_COUNT', $totalCount);
    Severity: Critical
    Found in modules/Settings/Vtiger/views/List.php by phan

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class Settings_Vtiger_List_View extends Settings_Vtiger_Index_View
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    The class Settings_Vtiger_List_View is not named in CamelCase.
    Open

    class Settings_Vtiger_List_View extends Settings_Vtiger_Index_View
{
    protected $listViewEntries = false;
    protected $listViewHeaders = false;
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @var Settings_Vtiger_ListView_Model
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->view('ListViewHeader.tpl', $request->getModule(false));
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->view('ListViewContents.tpl', $request->getModule(false));
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty($searchParams)) {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!$this->listViewHeaders) {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $this->listViewEntries = $model->getListViewEntries($pagingModel);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('PAGE_NUMBER', $pageNumber);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Function to initialize the required data in smarty to display the List View Contents.
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $viewer->assign('SEARCH_PARAMS', $searchParams);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!isset($this->listViewLinks)) {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('LISTVIEW_HEADERS', $this->listViewHeaders);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $viewer->assign('SOURCE_MODULE', $sourceModule);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function process(App\Request $request)
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $searchKey = $request->isEmpty('search_key') ? false : $request->getByType('search_key', 'Alnum');
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $sourceModule = $request->getByType('forModule', 1);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function preProcess(App\Request $request, $display = true)
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $this->initializeListViewContents($request, $viewer);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $sourceModule = $request->getByType('sourceModule', 2);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $this->initializeListViewContents($request, $viewer);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param Vtiger_Viewer $viewer
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $searchValue = $request->getByType('search_value', 'Text');
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!$this->listViewModel) {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty($orderBy)) {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $sourceModule = $request->getByType('sourceModule', 2);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer = $this->getViewer($request);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer = $this->getViewer($request);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $orderBy = $request->getForSql('orderby');
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!$this->listViewEntries) {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public $listViewModel;
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('PAGING_MODEL', $pagingModel);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('ORDER_BY', $orderBy);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $sortOrder = $request->getForSql('sortorder');
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $model->set('searchParams', $searchParams);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $this->listViewHeaders = $model->getListViewHeaders();
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('LISTVIEW_LINKS', $this->listViewLinks);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('LISTVIEW_ENTRIES_COUNT', $noOfEntries);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $searchParams = $request->getArray('searchParams', 'Text');
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (empty($pageNumber)) {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $model = $this->listViewModel;
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $pagingModel->set('page', $pageNumber);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $model->set('search_key', $searchKey);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('MODULE_MODEL', $model->getModule());
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('LISTVIEW_ENTRIES', $this->listViewEntries);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $nextSortOrder = 'DESC';
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $sortImage = 'fas fa-chevron-down';
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $sortImage = 'fas fa-chevron-up';
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!$request->isEmpty('sourceModule')) {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $pagingModel->set('totalCount', (int) $totalCount);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $moduleName = $request->getModule();
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                "modules.$moduleName.resources.ListSearch",
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        protected $listViewEntries = false;
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * List view model instance.
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function initializeListViewContents(App\Request $request, Vtiger_Viewer $viewer)
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $qualifiedModuleName = $request->getModule(false);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ('ASC' === $sortOrder) {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!$request->isEmpty('sourceModule')) {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $pageNumber = 1;
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $pagingModel = new Vtiger_Paging_Model();
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $model->set('orderby', $orderBy);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('SORT_ORDER', $sortOrder);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('NEXT_SORT_ORDER', $nextSortOrder);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('COLUMN_NAME', $orderBy);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $this->listViewCount = $model->getListViewCount();
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $pageCount = $pagingModel->getPageCount();
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ]));
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty($searchKey) && !empty($searchValue)) {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!$request->isEmpty('forModule')) {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $pageNumber = $request->getInteger('page');
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('SORT_IMAGE', $sortImage);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            parent::preProcess($request, false);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $nextSortOrder = 'ASC';
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $model->set('search_value', $searchValue);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $totalCount = $this->listViewCount;
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return array_merge(parent::getFooterScripts($request), $this->checkAndConvertJsScripts([
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Function to get the list of Script models to be included.
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        protected $listViewHeaders = false;
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param \App\Request  $request
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $model->set('sourceModule', $sourceModule);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $noOfEntries = \count($this->listViewEntries);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $startPaginFrom = $pagingModel->getStartPagingFrom();
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('PAGE_COUNT', $pageCount);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            } else {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $this->listViewModel = Settings_Vtiger_ListView_Model::getInstance($qualifiedModuleName);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $model->set('sortorder', $sortOrder);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $model->set('forModule', $sourceModule);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $this->listViewLinks = $model->getListViewLinks();
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('START_PAGIN_FROM', $startPaginFrom);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'modules.Settings.Vtiger.resources.List',
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return <Array> - List of Vtiger_JsScript_Model instances
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'modules.Vtiger.resources.List',
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                "modules.Settings.Vtiger.resources.$moduleName",
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('LISTVIEW_COUNT', $totalCount);
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param \App\Request $request
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                "modules.Settings.$moduleName.resources.List",
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getFooterScripts(App\Request $request)
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!isset($this->listViewCount)) {
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'modules.Vtiger.resources.ListSearch',
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    Class name "Settings_Vtiger_List_View" is not in camel caps format
    Open

    class Settings_Vtiger_List_View extends Settings_Vtiger_Index_View
    Severity: Minor
    Found in modules/Settings/Vtiger/views/List.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status