Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Settings/Wapro/models/Activation.php

Summary

Maintainability
B
4 hrs
Test Coverage
F
0%

Method activate has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function activate(): bool
    {
        $importer = new \App\Db\Importers\Base();
        $db = \App\Db::getInstance();
        if (!$db->isTableExists(\App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME)) {
Severity: Major
Found in modules/Settings/Wapro/models/Activation.php - About 2 hrs to fix

    Function activate has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function activate(): bool
    {
        $importer = new \App\Db\Importers\Base();
        $db = \App\Db::getInstance();
        if (!$db->isTableExists(\App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME)) {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function check has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function check(): bool
    {
        $db = \App\Db::getInstance();
        $check = $db->isTableExists(\App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME) && $db->isTableExists(\App\Integrations\Wapro::LOG_TABLE_NAME);
        if ($check) {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing class import via use statement (line '90', column '18').
    Open

                $check = (new \App\Db\Query())->from('vtiger_field')->where(['tabid' => $moduleId, 'fieldname' => $field[0]])->exists();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '39', column '19').
    Open

                    $check = (new \App\Db\Query())->from('vtiger_field')->where(['tabid' => \App\Module::getModuleId($field[1]), 'fieldname' => $field[0]])->exists();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '62', column '19').
    Open

            $importer = new \App\Db\Importers\Base();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '49', column '17').
    Open

                $cron = (new \App\Db\Query())->from('vtiger_cron_task')->where(['name' => 'LBL_INTEGRATION_WAPRO', 'handler_class' => 'Vtiger_IntegrationWapro_Cron'])->one();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '139', column '16').
    Open

            $cron = (new \App\Db\Query())->from('vtiger_cron_task')->where(['name' => 'LBL_INTEGRATION_WAPRO', 'handler_class' => 'Vtiger_IntegrationWapro_Cron'])->one();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '97', column '26').
    Open

                    $fieldInstance = new Vtiger_Field_Model();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class '\App\Module' in method 'check'.
    Open

                    $check = (new \App\Db\Query())->from('vtiger_field')->where(['tabid' => \App\Module::getModuleId($field[1]), 'fieldname' => $field[0]])->exists();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Db' in method 'activate'.
    Open

            $db = \App\Db::getInstance();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\vtlib\Cron' in method 'activateCron'.
    Open

                \vtlib\Cron::register('LBL_INTEGRATION_WAPRO', 'Vtiger_IntegrationWapro_Cron', 900, 'Vtiger', 1);
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Cron' in method 'activateCron'.
    Open

                \App\Cron::updateStatus(\App\Cron::STATUS_ENABLED, 'LBL_INTEGRATION_WAPRO');
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'vtlib\Block' in method 'activate'.
    Open

                    $blockModel = vtlib\Block::getInstance($field[2], $field[1]);
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'vtlib\Block' in method 'activate'.
    Open

                        $blocks = vtlib\Block::getAllForModule(vtlib\Module::getInstance($field[1]));
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Vtiger_Inventory_Model' in method 'activateInventory'.
    Open

            $inventory = Vtiger_Inventory_Model::getInstance('FInvoice');
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Module' in method 'activate'.
    Open

                $moduleId = \App\Module::getModuleId($field[1]);
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Db' in method 'check'.
    Open

            $db = \App\Db::getInstance();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'vtlib\Module' in method 'activate'.
    Open

                        $blocks = vtlib\Block::getAllForModule(vtlib\Module::getInstance($field[1]));
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method activate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                    } else {
                    $status = false;
                }
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Define a constant instead of duplicating this literal "LBL_INTEGRATION_WAPRO" 4 times.
    Open

                $cron = (new \App\Db\Query())->from('vtiger_cron_task')->where(['name' => 'LBL_INTEGRATION_WAPRO', 'handler_class' => 'Vtiger_IntegrationWapro_Cron'])->one();
    Severity: Critical
    Found in modules/Settings/Wapro/models/Activation.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "Vtiger_IntegrationWapro_Cron" 3 times.
    Open

                $cron = (new \App\Db\Query())->from('vtiger_cron_task')->where(['name' => 'LBL_INTEGRATION_WAPRO', 'handler_class' => 'Vtiger_IntegrationWapro_Cron'])->one();
    Severity: Critical
    Found in modules/Settings/Wapro/models/Activation.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "LBL_CUSTOM_INFORMATION" 4 times.
    Open

            ['wapro_id', 'BankAccounts', 'LBL_CUSTOM_INFORMATION'],
    Severity: Critical
    Found in modules/Settings/Wapro/models/Activation.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "FInvoice" 3 times.
    Open

            ['wapro_id', 'FInvoice', 'LBL_CUSTOM_INFORMATION'],
    Severity: Critical
    Found in modules/Settings/Wapro/models/Activation.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "tabid" 3 times.
    Open

                    $check = (new \App\Db\Query())->from('vtiger_field')->where(['tabid' => \App\Module::getModuleId($field[1]), 'fieldname' => $field[0]])->exists();
    Severity: Critical
    Found in modules/Settings/Wapro/models/Activation.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "wapro_id" 7 times.
    Open

            ['wapro_id', 'MultiCompany', 'LBL_SYSTEM_INFORMATION'],
    Severity: Critical
    Found in modules/Settings/Wapro/models/Activation.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "crmid" 4 times.
    Open

                    'crmid' => $importer->integer(10)->notNull(),
    Severity: Critical
    Found in modules/Settings/Wapro/models/Activation.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Call to method notNull from undeclared class \yii\db\ColumnSchemaBuilder (Did you mean class \App\Db\Drivers\Mysql\ColumnSchemaBuilder or class \App\Db\Drivers\Pgsql\ColumnSchemaBuilder)
    Open

                    'wtable' => $importer->stringType('50')->notNull(),
    Severity: Critical
    Found in modules/Settings/Wapro/models/Activation.php by phan

    Call to method notNull from undeclared class \yii\db\ColumnSchemaBuilder (Did you mean class \App\Db\Drivers\Mysql\ColumnSchemaBuilder or class \App\Db\Drivers\Pgsql\ColumnSchemaBuilder)
    Open

                    'time' => $importer->dateTime()->notNull(),
    Severity: Critical
    Found in modules/Settings/Wapro/models/Activation.php by phan

    Call to undeclared method \App\Db\Query::from
    Open

                $check = (new \App\Db\Query())->from('vtiger_field')->where(['tabid' => $moduleId, 'fieldname' => $field[0]])->exists();
    Severity: Critical
    Found in modules/Settings/Wapro/models/Activation.php by phan

    Call to undeclared method \App\Db\Query::from
    Open

            $cron = (new \App\Db\Query())->from('vtiger_cron_task')->where(['name' => 'LBL_INTEGRATION_WAPRO', 'handler_class' => 'Vtiger_IntegrationWapro_Cron'])->one();
    Severity: Critical
    Found in modules/Settings/Wapro/models/Activation.php by phan

    Call to method notNull from undeclared class \yii\db\ColumnSchemaBuilder (Did you mean class \App\Db\Drivers\Mysql\ColumnSchemaBuilder or class \App\Db\Drivers\Pgsql\ColumnSchemaBuilder)
    Open

                    'crmid' => $importer->integer(10)->notNull(),
    Severity: Critical
    Found in modules/Settings/Wapro/models/Activation.php by phan

    Call to undeclared method \App\Db::createCommand
    Open

                $db->createCommand()->createIndex(\App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME . '_crmid_idx', \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, 'crmid', true)->execute();
    Severity: Critical
    Found in modules/Settings/Wapro/models/Activation.php by phan

    Call to undeclared method \App\Db::createCommand
    Open

                $db->createCommand()->createIndex(\App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME . '_wapro_idx', \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, 'wtable,wid')->execute();
    Severity: Critical
    Found in modules/Settings/Wapro/models/Activation.php by phan

    Call to undeclared method \App\Db\Query::from
    Open

                    $check = (new \App\Db\Query())->from('vtiger_field')->where(['tabid' => \App\Module::getModuleId($field[1]), 'fieldname' => $field[0]])->exists();
    Severity: Critical
    Found in modules/Settings/Wapro/models/Activation.php by phan

    Call to method notNull from undeclared class \yii\db\ColumnSchemaBuilder (Did you mean class \App\Db\Drivers\Mysql\ColumnSchemaBuilder or class \App\Db\Drivers\Pgsql\ColumnSchemaBuilder)
    Open

                    'wid' => $importer->integer(10)->notNull(),
    Severity: Critical
    Found in modules/Settings/Wapro/models/Activation.php by phan

    Call to method notNull from undeclared class \yii\db\ColumnSchemaBuilder (Did you mean class \App\Db\Drivers\Mysql\ColumnSchemaBuilder or class \App\Db\Drivers\Pgsql\ColumnSchemaBuilder)
    Open

                        ->set('columntype', $importer->integer(10)->notNull())
    Severity: Critical
    Found in modules/Settings/Wapro/models/Activation.php by phan

    Argument 1 (length) is '50' but \App\Db\Importers\Base::stringType() takes int defined at /code/app/Db/Importers/Base.php:141
    Open

                    'wtable' => $importer->stringType('50')->notNull(),
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phan

    Call to undeclared method \App\Db\Query::from
    Open

                $cron = (new \App\Db\Query())->from('vtiger_cron_task')->where(['name' => 'LBL_INTEGRATION_WAPRO', 'handler_class' => 'Vtiger_IntegrationWapro_Cron'])->one();
    Severity: Critical
    Found in modules/Settings/Wapro/models/Activation.php by phan

    Call to undeclared method \App\Db::createCommand
    Open

                $db->createCommand()->addForeignKey(
    Severity: Critical
    Found in modules/Settings/Wapro/models/Activation.php by phan

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class Settings_Wapro_Activation_Model
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

            $db = \App\Db::getInstance();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

            $db = \App\Db::getInstance();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    The class Settings_Wapro_Activation_Model is not named in CamelCase.
    Open

    class Settings_Wapro_Activation_Model
{
    /** @var array Map relation table name */
    private const FIELDS = [
        ['wapro_id', 'MultiCompany', 'LBL_SYSTEM_INFORMATION'],
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Only one argument is allowed per line in a multi-line function call
    Open

                    'fk_1_' . \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, 'crmid', 'vtiger_crmentity', 'crmid', 'CASCADE', 'RESTRICT'
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Only one argument is allowed per line in a multi-line function call
    Open

                    'fk_1_' . \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, 'crmid', 'vtiger_crmentity', 'crmid', 'CASCADE', 'RESTRICT'
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Only one argument is allowed per line in a multi-line function call
    Open

                    'fk_1_' . \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, 'crmid', 'vtiger_crmentity', 'crmid', 'CASCADE', 'RESTRICT'
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Only one argument is allowed per line in a multi-line function call
    Open

                    'fk_1_' . \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, 'crmid', 'vtiger_crmentity', 'crmid', 'CASCADE', 'RESTRICT'
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Only one argument is allowed per line in a multi-line function call
    Open

                    'fk_1_' . \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, 'crmid', 'vtiger_crmentity', 'crmid', 'CASCADE', 'RESTRICT'
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Only one argument is allowed per line in a multi-line function call
    Open

                    'fk_1_' . \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, 'crmid', 'vtiger_crmentity', 'crmid', 'CASCADE', 'RESTRICT'
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $check = (new \App\Db\Query())->from('vtiger_field')->where(['tabid' => \App\Module::getModuleId($field[1]), 'fieldname' => $field[0]])->exists();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Activate integration, requires creation of additional integration data.
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $importer = new \App\Db\Importers\Base();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $db = \App\Db::getInstance();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'id' => $importer->primaryKeyUnsigned(),
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ]);
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Activate integration in inventory.
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (empty($cron)) {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (1 != $cron['status']) {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ['wapro_id', 'BankAccounts', 'LBL_CUSTOM_INFORMATION'],
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Line exceeds 120 characters; contains 170 characters
    Open

                $cron = (new \App\Db\Query())->from('vtiger_cron_task')->where(['name' => 'LBL_INTEGRATION_WAPRO', 'handler_class' => 'Vtiger_IntegrationWapro_Cron'])->one();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $db->createCommand()->addForeignKey(
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Line exceeds 120 characters; contains 132 characters
    Open

                $check = (new \App\Db\Query())->from('vtiger_field')->where(['tabid' => $moduleId, 'fieldname' => $field[0]])->exists();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $fieldModel->setDefaultDataConfig();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Line exceeds 120 characters; contains 148 characters
    Open

            $check = $db->isTableExists(\App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME) && $db->isTableExists(\App\Integrations\Wapro::LOG_TABLE_NAME);
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                foreach (self::FIELDS as $field) {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        ->set('table', $db->quoteSql(\App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME))
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    } else {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ['wapro_id', 'Contacts', 'LBL_CUSTOM_INFORMATION'],
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $check = $cron && 1 == $cron['status'];
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return $check;
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return bool
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $db->createTable(\App\Integrations\Wapro::LOG_TABLE_NAME, [
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'time' => $importer->dateTime()->notNull(),
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'message' => $importer->stringType(255),
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $blocks = vtlib\Block::getAllForModule(vtlib\Module::getInstance($field[1]));
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        ->set('label', 'FL_WAPRO_ID')
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ['wapro_id', 'FInvoice', 'LBL_CUSTOM_INFORMATION'],
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ['wapro_id', 'FCorectingInvoice', 'LBL_CUSTOM_INFORMATION'],
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Line exceeds 120 characters; contains 162 characters
    Open

                    $check = (new \App\Db\Query())->from('vtiger_field')->where(['tabid' => \App\Module::getModuleId($field[1]), 'fieldname' => $field[0]])->exists();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $db->createCommand()->createIndex(\App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME . '_crmid_idx', \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, 'crmid', true)->execute();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            foreach (self::FIELDS as $field) {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        ->set('columntype', $importer->integer(10)->notNull())
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        ];
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public static function check(): bool
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($check) {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if (!$check) {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($check) {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $db->createTable(\App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, [
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Line exceeds 120 characters; contains 184 characters
    Open

                $db->createCommand()->createIndex(\App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME . '_wapro_idx', \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, 'wtable,wid')->execute();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $fieldInstance = new Vtiger_Field_Model();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        ->set('column', 'wid')
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $status = false;
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return $status ?? false;
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ['wapro_id', 'MultiCompany', 'LBL_SYSTEM_INFORMATION'],
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $cron = (new \App\Db\Query())->from('vtiger_cron_task')->where(['name' => 'LBL_INTEGRATION_WAPRO', 'handler_class' => 'Vtiger_IntegrationWapro_Cron'])->one();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!$db->isTableExists(\App\Integrations\Wapro::LOG_TABLE_NAME)) {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $status = true;
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if (!$check) {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        ->set('uitype', 1)
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $status = true;
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Activate integration in cron.
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                )->execute();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'category' => $importer->stringType(100),
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $blockModel = current($blocks);
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if ($fieldInstance->save($blockModel)) {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** @var array Map relation table name */
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return bool
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public static function activate(): bool
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if (!$blockModel) {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return void
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $cron = (new \App\Db\Query())->from('vtiger_cron_task')->where(['name' => 'LBL_INTEGRATION_WAPRO', 'handler_class' => 'Vtiger_IntegrationWapro_Cron'])->one();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $fieldInstance->set('name', $field[0])
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            self::activateCron();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $inventory = Vtiger_Inventory_Model::getInstance('FInvoice');
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                \App\Cron::updateStatus(\App\Cron::STATUS_ENABLED, 'LBL_INTEGRATION_WAPRO');
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        private const FIELDS = [
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'error' => $importer->boolean(),
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $check = (new \App\Db\Query())->from('vtiger_field')->where(['tabid' => $moduleId, 'fieldname' => $field[0]])->exists();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        ->set('tabid', $moduleId)
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            self::activateInventory();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $check = Vtiger_Inventory_Model::getInstance('FInvoice')->isField('discount_aggreg');
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $db->createCommand()->createIndex(\App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME . '_wapro_idx', \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, 'wtable,wid')->execute();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return void
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        private static function activateCron(): void
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                \vtlib\Cron::register('LBL_INTEGRATION_WAPRO', 'Vtiger_IntegrationWapro_Cron', 900, 'Vtiger', 1);
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ]);
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        private static function activateInventory(): void
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $inventory->saveField($fieldModel);
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ['wapro_id', 'Accounts', 'LBL_ADVANCED_BLOCK'],
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ['wapro_id', 'Products', 'LBL_PRODUCT_INFORMATION'],
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $db = \App\Db::getInstance();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!$db->isTableExists(\App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME)) {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'crmid' => $importer->integer(10)->notNull(),
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Line exceeds 120 characters; contains 183 characters
    Open

                    'fk_1_' . \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, 'crmid', 'vtiger_crmentity', 'crmid', 'CASCADE', 'RESTRICT'
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'trace' => $importer->text(),
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        ->set('displaytype', 9)
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Check if the functionality has been activated.
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $check = $db->isTableExists(\App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME) && $db->isTableExists(\App\Integrations\Wapro::LOG_TABLE_NAME);
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'wtable' => $importer->stringType('50')->notNull(),
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $fieldModel = $inventory->getFieldCleanInstance('DiscountAggregation');
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Line exceeds 120 characters; contains 166 characters
    Open

            $cron = (new \App\Db\Query())->from('vtiger_cron_task')->where(['name' => 'LBL_INTEGRATION_WAPRO', 'handler_class' => 'Vtiger_IntegrationWapro_Cron'])->one();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        break;
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($check) {
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'wid' => $importer->integer(10)->notNull(),
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Line exceeds 120 characters; contains 185 characters
    Open

                $db->createCommand()->createIndex(\App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME . '_crmid_idx', \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, 'crmid', true)->execute();
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'fk_1_' . \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, \App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME, 'crmid', 'vtiger_crmentity', 'crmid', 'CASCADE', 'RESTRICT'
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $status = true;
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $moduleId = \App\Module::getModuleId($field[1]);
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $blockModel = vtlib\Block::getInstance($field[2], $field[1]);
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        ->set('typeofdata', 'I~O');
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    Class name "Settings_Wapro_Activation_Model" is not in camel caps format
    Open

    class Settings_Wapro_Activation_Model
    Severity: Minor
    Found in modules/Settings/Wapro/models/Activation.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status