modules/Settings/Wapro/views/ListSynchronizerModal.php
Missing class import via use statement (line '35', column '38'). Open
Open
$viewer->assign('WAPRO_MODEL', new App\Integrations\Wapro($request->getInteger('id')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Call to undeclared method \Settings_Wapro_ListSynchronizerModal_View::getViewer
Open
Open
$viewer = $this->getViewer($request);
- Exclude checks
Avoid excessively long class names like Settings_Wapro_ListSynchronizerModal_View. Keep class name length under 40. Open
Open
class Settings_Wapro_ListSynchronizerModal_View extends \App\Controller\ModalSettings
{
/** {@inheritdoc} */
protected $pageTitle = 'LBL_SYNCHRONIZER_LIST';
- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}
Source https://phpmd.org/rules/naming.html#longclassname
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Settings_Wapro_ListSynchronizerModal_View extends \App\Controller\ModalSettings
- Exclude checks
The class Settings_Wapro_ListSynchronizerModal_View is not named in CamelCase. Open
Open
class Settings_Wapro_ListSynchronizerModal_View extends \App\Controller\ModalSettings
{
/** {@inheritdoc} */
protected $pageTitle = 'LBL_SYNCHRONIZER_LIST';
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}
Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $modalIcon = 'fas fa-list';
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer = $this->getViewer($request);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
protected $pageTitle = 'LBL_SYNCHRONIZER_LIST';
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function process(App\Request $request)
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $showFooter = false;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('WAPRO_MODEL', new App\Integrations\Wapro($request->getInteger('id')));
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $modalSize = 'modal-lg';
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->view('ListSynchronizerModal.tpl', $request->getModule(false));
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */
- Exclude checks
Class name "Settings_Wapro_ListSynchronizerModal_View" is not in camel caps format Open
Open
class Settings_Wapro_ListSynchronizerModal_View extends \App\Controller\ModalSettings
- Exclude checks