YetiForceCompany/YetiForceCRM

View on GitHub
modules/Settings/Wapro/views/ListSynchronizerModal.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Missing class import via use statement (line '35', column '38').
Open

        $viewer->assign('WAPRO_MODEL', new App\Integrations\Wapro($request->getInteger('id')));

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Call to undeclared method \Settings_Wapro_ListSynchronizerModal_View::getViewer
Open

        $viewer = $this->getViewer($request);

Avoid excessively long class names like Settings_Wapro_ListSynchronizerModal_View. Keep class name length under 40.
Open

class Settings_Wapro_ListSynchronizerModal_View extends \App\Controller\ModalSettings
{
    /** {@inheritdoc} */
    protected $pageTitle = 'LBL_SYNCHRONIZER_LIST';

LongClassName

Since: 2.9

Detects when classes or interfaces are declared with excessively long names.

Example

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Source https://phpmd.org/rules/naming.html#longclassname

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Settings_Wapro_ListSynchronizerModal_View extends \App\Controller\ModalSettings

The class Settings_Wapro_ListSynchronizerModal_View is not named in CamelCase.
Open

class Settings_Wapro_ListSynchronizerModal_View extends \App\Controller\ModalSettings
{
    /** {@inheritdoc} */
    protected $pageTitle = 'LBL_SYNCHRONIZER_LIST';

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

    public $modalIcon = 'fas fa-list';

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer = $this->getViewer($request);

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

    protected $pageTitle = 'LBL_SYNCHRONIZER_LIST';

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

    public function process(App\Request $request)

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

    public $showFooter = false;

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('WAPRO_MODEL', new App\Integrations\Wapro($request->getInteger('id')));

Spaces must be used to indent lines; tabs are not allowed
Open

    public $modalSize = 'modal-lg';

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->view('ListSynchronizerModal.tpl', $request->getModule(false));

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Class name "Settings_Wapro_ListSynchronizerModal_View" is not in camel caps format
Open

class Settings_Wapro_ListSynchronizerModal_View extends \App\Controller\ModalSettings

There are no issues that match your filters.

Category
Status