Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Avoid using static access to class 'Settings_Vtiger_Module_Model' in method 'process'.
Open

        $moduleInstance = Settings_Vtiger_Module_Model::getInstance('Settings:WebserviceUsers');
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Settings_WebserviceUsers_Record_Model' in method 'process'.
Open

        $recordModel = Settings_WebserviceUsers_Record_Model::getInstanceById($request->getInteger('record', ''), $container);
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to undeclared method \Settings_WebserviceUsers_HistoryAccessActivity_View::getViewer
Open

        $viewer = $this->getViewer($request);
Severity: Critical
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phan

Argument 2 (value) is '' but \App\Request::getInteger() takes int defined at /code/app/Request.php:200
Open

        $recordModel = Settings_WebserviceUsers_Record_Model::getInstanceById($request->getInteger('record', ''), $container);
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phan

Reference to undeclared property \Settings_Vtiger_Module_Model->typeApi
Open

        $moduleInstance->typeApi = $container;
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phan

Call to undeclared method \Settings_Vtiger_Module_Model::getService
Open

        $viewer->assign('TABLE_COLUMNS', $moduleInstance->getService()->columnsToShow);
Severity: Critical
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phan

Avoid excessively long class names like Settings_WebserviceUsers_HistoryAccessActivity_View. Keep class name length under 40.
Open

class Settings_WebserviceUsers_HistoryAccessActivity_View extends \App\Controller\ModalSettings
{
    /** {@inheritdoc} */
    public $modalSize = 'modal-full';
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpmd

LongClassName

Since: 2.9

Detects when classes or interfaces are declared with excessively long names.

Example

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Source https://phpmd.org/rules/naming.html#longclassname

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Settings_WebserviceUsers_HistoryAccessActivity_View extends \App\Controller\ModalSettings
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

The class Settings_WebserviceUsers_HistoryAccessActivity_View is not named in CamelCase.
Open

class Settings_WebserviceUsers_HistoryAccessActivity_View extends \App\Controller\ModalSettings
{
    /** {@inheritdoc} */
    public $modalSize = 'modal-full';
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc}  */
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $pageTitle = 'LBL_HISTORY_ACTIVITY';
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $recordModel = Settings_WebserviceUsers_Record_Model::getInstanceById($request->getInteger('record', ''), $container);
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer = $this->getViewer($request);
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $moduleInstance = Settings_Vtiger_Module_Model::getInstance('Settings:WebserviceUsers');
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Line exceeds 120 characters; contains 126 characters
Open

        $recordModel = Settings_WebserviceUsers_Record_Model::getInstanceById($request->getInteger('record', ''), $container);
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $qualifiedModuleName = $request->getModule(false);
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('HISTORY_ACTIVITY_ENTRIES', $recordModel->getUserHistoryAccessActivity($container));
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $container = $request->getByType('typeApi', 'Alnum');
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $modalSize = 'modal-full';
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $modalIcon = 'yfi yfi-login-history';
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $showFooter = false;
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $moduleInstance->typeApi = $container;
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('TABLE_COLUMNS', $moduleInstance->getService()->columnsToShow);
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->view('HistoryAccessActivity.tpl', $qualifiedModuleName);
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function process(App\Request $request)
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

Class name "Settings_WebserviceUsers_HistoryAccessActivity_View" is not in camel caps format
Open

class Settings_WebserviceUsers_HistoryAccessActivity_View extends \App\Controller\ModalSettings
Severity: Minor
Found in modules/Settings/WebserviceUsers/views/HistoryAccessActivity.php by phpcodesniffer

There are no issues that match your filters.

Category
Status