modules/Settings/WidgetsManagement/views/WidgetListModal.php
Missing class import via use statement (line '37', column '33'). Open
Open
$widgetsManagementModel = new Settings_WidgetsManagement_Module_Model();- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Call to undeclared method \Settings_WidgetsManagement_WidgetListModal_View::getViewer Open
Open
$viewer = $this->getViewer($request);- Exclude checks
Avoid excessively long class names like Settings_WidgetsManagement_WidgetListModal_View. Keep class name length under 40. Open
Open
class Settings_WidgetsManagement_WidgetListModal_View extends \App\Controller\ModalSettings
{
/** {@inheritdoc} */
public $modalIcon = 'adminIcon-widgets-configuration';
- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}Source https://phpmd.org/rules/naming.html#longclassname
Avoid excessively long variable names like $widgetsManagementModel. Keep variable name length under 20. Open
Open
$widgetsManagementModel = new Settings_WidgetsManagement_Module_Model();- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}Source https://phpmd.org/rules/naming.html#longvariable
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Settings_WidgetsManagement_WidgetListModal_View extends \App\Controller\ModalSettings- Exclude checks
The class Settings_WidgetsManagement_WidgetListModal_View is not named in CamelCase. Open
Open
class Settings_WidgetsManagement_WidgetListModal_View extends \App\Controller\ModalSettings
{
/** {@inheritdoc} */
public $modalIcon = 'adminIcon-widgets-configuration';
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function process(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $modalSize = 'modal-md';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$blockId = $request->getInteger('blockId');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->view('WidgetListModal.tpl', $qualifiedModuleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$widgets = $widgetsManagementModel->getPredefinedWidgetsByBlock($blockId);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$qualifiedModuleName = $request->getModule(false);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $successBtn = 'BTN_NEXT';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('WIDGETS', $widgets);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $modalIcon = 'adminIcon-widgets-configuration';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
protected $pageTitle = 'LBL_CREATE_CUSTOM_FIELD';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$widgetsManagementModel = new Settings_WidgetsManagement_Module_Model();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer = $this->getViewer($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $successBtnIcon = 'fas fa-caret-right';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Class name "Settings_WidgetsManagement_WidgetListModal_View" is not in camel caps format Open
Open
class Settings_WidgetsManagement_WidgetListModal_View extends \App\Controller\ModalSettings- Exclude checks