Method getListViewEntries has 54 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function getListViewEntries($pagingModel)
    {
        $module = $this->getModule();
        $moduleName = $module->getName();
        $parentModuleName = $module->getParentName();

Function getListViewEntries has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.

Open

    public function getListViewEntries($pagingModel)
    {
        $module = $this->getModule();
        $moduleName = $module->getName();
        $parentModuleName = $module->getParentName();

• Read up
  Read up

Missing class import via use statement (line '96', column '17').

Open

        $query = (new App\Db\Query())->from($module->baseTable);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '39', column '21').

Open

        $listQuery = (new App\Db\Query())->select($listFields)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid using static access to class '\App\Language' in method 'getListViewEntries'.

Open

            $row['module_name'] = \App\Language::translate($row['module_name'], $row['module_name']);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Language' in method 'getListViewEntries'.

Open

            $row['execution_condition'] = \App\Language::translate($record->executionConditionAsLabel($row['execution_condition']), 'Settings:Workflows');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Language' in method 'getListViewEntries'.

Open

            $row['summary'] = \App\Language::translate($row['summary'], 'Settings:Workflows');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method getListViewEntries uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $pagingModel->set('nextPageExists', false);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class 'Vtiger_Loader' in method 'getListViewEntries'.

Open

        $recordModelClass = Vtiger_Loader::getComponentClassName('Model', 'Record', $qualifiedModuleName);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Define a constant instead of duplicating this literal "module_name" 5 times.

Open

            $listQuery->where(['module_name' => $sourceModule]);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Call to undeclared method \App\Db\Query::select

Open

        $listQuery = (new App\Db\Query())->select($listFields)

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

        $query = (new App\Db\Query())->from($module->baseTable);

• Exclude checks
  • Disable engine
  • Disable check

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class Settings_Workflows_ListView_Model extends Settings_Vtiger_ListView_Model

• Exclude checks
  • Disable engine
  • Disable check

The class Settings_Workflows_ListView_Model is not named in CamelCase.

Open

class Settings_Workflows_ListView_Model extends Settings_Vtiger_ListView_Model
{
    /**
     * Function to get the list view entries.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class class_name {
}

Spaces must be used for alignment; tabs are not allowed

Open

        return $query->count();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used for alignment; tabs are not allowed

Open

    /**     * *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used for alignment; tabs are not allowed

Open

        $module = $this->getModule();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used for alignment; tabs are not allowed

Open

        if ($sourceModule) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used for alignment; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used for alignment; tabs are not allowed

Open

     * Function which will get the list view count.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used for alignment; tabs are not allowed

Open

    public function getListViewCount()

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used for alignment; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used for alignment; tabs are not allowed

Open

        $query = (new App\Db\Query())->from($module->baseTable);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used for alignment; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used for alignment; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used for alignment; tabs are not allowed

Open

     * @return int number of records

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used for alignment; tabs are not allowed

Open

            $query->where(['module_name' => $sourceModule]);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used for alignment; tabs are not allowed

Open

        $sourceModule = $this->get('sourceModule');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used for alignment; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param Vtiger_Paging_Model $pagingModel

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $listQuery->orderBy(sprintf('%s %s', $orderBy, $this->getForSql('sortorder')));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Function to get the list view entries.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $row['module_name'] = \App\Language::translate($row['module_name'], $row['module_name']);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $row['all_tasks'] = \count($taskList);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ->from($module->baseTable);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $moduleName = $module->getName();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $parentModuleName = $module->getParentName();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $listFields[] = $module->baseIndex;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $listQuery->where(['module_name' => $sourceModule]);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $pageLimit = $pagingModel->getPageLimit();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $row['summary'] = \App\Language::translate($row['summary'], 'Settings:Workflows');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $listQuery = (new App\Db\Query())->select($listFields)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $workflowModel = $record->getInstance($row['workflow_id']);

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 154 characters

Open

            $row['execution_condition'] = \App\Language::translate($record->executionConditionAsLabel($row['execution_condition']), 'Settings:Workflows');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @return array Associative array of record id mapped to Vtiger_Record_Model instance

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!empty($parentModuleName)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        unset($listFields['all_tasks'], $listFields['active_tasks']);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!empty($sourceModule)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $orderBy = $this->getForSql('orderby');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!empty($orderBy)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $module = $this->getModule();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $recordModelClass = Vtiger_Loader::getComponentClassName('Model', 'Record', $qualifiedModuleName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $sourceModule = $this->get('sourceModule');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $record = new $recordModelClass();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $taskList = $workflowModel->getTasks(false);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $listFields = $module->listFields;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        while ($row = $dataReader->read()) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $qualifiedModuleName = $moduleName;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function getListViewEntries($pagingModel)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $qualifiedModuleName = $parentModuleName . ':' . $qualifiedModuleName;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $listFields = array_keys($listFields);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $startIndex = $pagingModel->getStartIndex();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $row['execution_condition'] = \App\Language::translate($record->executionConditionAsLabel($row['execution_condition']), 'Settings:Workflows');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $dataReader = $listQuery->createCommand()->query();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $listViewRecordModels = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $listQuery->limit($pageLimit + 1)->offset($startIndex);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            foreach ($taskList as $taskRecord) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $pagingModel->calculatePageRange($dataReader->count());

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $pagingModel->set('nextPageExists', true);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return $listViewRecordModels;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $activeCount = 0;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $record->setData($row);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $dataReader->close();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**     * *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                if ($taskRecord->isActive() && $taskRecord->isEditable()) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ($dataReader->count() > $pageLimit) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $pagingModel->set('nextPageExists', false);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            array_pop($listViewRecordModels);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $listViewRecordModels[$record->getId()] = $record;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $row['active_tasks'] = $activeCount;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    ++$activeCount;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Class name "Settings_Workflows_ListView_Model" is not in camel caps format

Open

class Settings_Workflows_ListView_Model extends Settings_Vtiger_ListView_Model

• Exclude checks
  • Disable engine
  • Disable check