Method process has 43 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function process(App\Request $request)
    {
        try {
            $orderId = $message = '';
            $responseType = 'success';

Function process has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.

Open

    public function process(App\Request $request)
    {
        try {
            $orderId = $message = '';
            $responseType = 'success';

• Read up
  Read up

The method process() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.

Open

    public function process(App\Request $request)
    {
        try {
            $orderId = $message = '';
            $responseType = 'success';

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Missing class import via use statement (line '63', column '19').

Open

        $response = new Vtiger_Response();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '43', column '16').

Open

                    throw new \App\Exceptions\AppException('LBL_NOT_FILLED_MANDATORY_FIELDS');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '37', column '17').

Open

                        throw new \App\Exceptions\AppException('ERR_PLEASE_USE_LATIN_CHARACTERS');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '30', column '17').

Open

            $order = new \App\YetiForce\Order();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '48', column '15').

Open

                throw new \App\Exceptions\AppException($error);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid assigning values to variables in if clauses and the like (line '47', column '8').

Open

    public function process(App\Request $request)
    {
        try {
            $orderId = $message = '';
            $responseType = 'success';

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

                } else {
                    throw new \App\Exceptions\AppException('LBL_NOT_FILLED_MANDATORY_FIELDS');
                }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid unused local variables such as '$mas'.

Open

                    if ($value && preg_match('/[^A-Za-zÀ-ž\W\d\s]+/u', (string) $value, $mas)) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Call to method send from undeclared class \App\YetiForce\Order

Open

            $result = $order->send();

• Exclude checks
  • Disable engine
  • Disable check

Call to method getId from undeclared class \App\YetiForce\Order

Open

                $orderId = $order->getId();

• Exclude checks
  • Disable engine
  • Disable check

Call to method getError from undeclared class \App\YetiForce\Order

Open

            if ($error = $order->getError()) {

• Exclude checks
  • Disable engine
  • Disable check

Call to method set from undeclared class \App\YetiForce\Order

Open

                    $order->set($fieldName, $field->getDBValue($value));

• Exclude checks
  • Disable engine
  • Disable check

Call to method setPackageId from undeclared class \App\YetiForce\Order

Open

            $order->setPackageId($request->getByType('packageId', \App\Purifier::ALNUM2));

• Exclude checks
  • Disable engine
  • Disable check

Call to method getFieldInstances from undeclared class \App\YetiForce\Order

Open

            foreach ($order->getFieldInstances() as $field) {

• Exclude checks
  • Disable engine
  • Disable check

Call to method __construct from undeclared class \App\YetiForce\Order

Open

            $order = new \App\YetiForce\Order();

• Exclude checks
  • Disable engine
  • Disable check

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                if ($request->has($fieldName) && !$request->isEmpty($fieldName)) {
                    $value = $request->getRaw($fieldName);
                    if ($value && preg_match('/[^A-Za-zÀ-ž\W\d\s]+/u', (string) $value, $mas)) {
                        throw new \App\Exceptions\AppException('ERR_PLEASE_USE_LATIN_CHARACTERS');
                    }

• Read up
  Read up

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class Settings_YetiForce_Buy_Action extends Settings_Vtiger_Save_Action

• Exclude checks
  • Disable engine
  • Disable check

The class Settings_YetiForce_Buy_Action is not named in CamelCase.

Open

class Settings_YetiForce_Buy_Action extends Settings_Vtiger_Save_Action
{
    /**
     * Process user request.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class class_name {
}

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $value = $request->getRaw($fieldName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $order->set($fieldName, $field->getDBValue($value));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $responseType = 'error';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                if ($request->has($fieldName) && !$request->isEmpty($fieldName)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $result = $order->send();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $order->setPackageId($request->getByType('packageId', \App\Purifier::ALNUM2));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Process user request.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $order = new \App\YetiForce\Order();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            foreach ($order->getFieldInstances() as $field) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $field->getUITypeModel()->validate($value, true);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param \App\Request $request

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $fieldName = $field->getName();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $responseType = 'error';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $value = $request->getByType($fieldName, $field->get('purifyType'));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $result = false;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    if ($value && preg_match('/[^A-Za-zÀ-ž\W\d\s]+/u', (string) $value, $mas)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    throw new \App\Exceptions\AppException('LBL_NOT_FILLED_MANDATORY_FIELDS');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if ($error = $order->getError()) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $message = $e->getDisplayMessage();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $message = $e->getMessage();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $response = new Vtiger_Response();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $responseType = 'success';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                throw new \App\Exceptions\AppException($error);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $response->setResult([

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'message' => $message ?? '',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if ($result) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $orderId = $order->getId();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'orderId' => $orderId

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $response->emit();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @throws \App\Exceptions\NoPermitted

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function process(App\Request $request)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        } catch (\Throwable $e) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                        throw new \App\Exceptions\AppException('ERR_PLEASE_USE_LATIN_CHARACTERS');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        } catch (\App\Exceptions\AppException $e) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $result = false;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        try {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $orderId = $message = '';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'type' => $responseType,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'success' => $result ?? false,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        ]);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Class name "Settings_YetiForce_Buy_Action" is not in camel caps format

Open

class Settings_YetiForce_Buy_Action extends Settings_Vtiger_Save_Action

• Exclude checks
  • Disable engine
  • Disable check