Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Settings/YetiForce/views/BuyModal.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Missing class import via use statement (line '56', column '39').
Open

        $viewer->assign('FORM_FIELDS', (new \App\YetiForce\Order())->getFieldInstances());
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class '\App\YetiForce\Shop' in method 'process'.
Open

        $viewer->assign('PAYPAL_URL', \App\YetiForce\Shop::getPaypalUrl());
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Settings_Companies_Record_Model' in method 'process'.
Open

        $viewer->assign('RECORD', Settings_Companies_Record_Model::getInstance());
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Language' in method 'preProcessAjax'.
Open

        $this->pageTitle = \App\Language::translate('LBL_BUY', $qualifiedModuleName);
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\YetiForce\Shop' in method 'process'.
Open

        $product = \App\YetiForce\Shop::getProduct($request->getByType('product', \App\Purifier::ALNUM2), $productId);
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to method getProduct from undeclared class \App\YetiForce\Shop
Open

        $product = \App\YetiForce\Shop::getProduct($request->getByType('product', \App\Purifier::ALNUM2), $productId);
Severity: Critical
Found in modules/Settings/YetiForce/views/BuyModal.php by phan

Call to method __construct from undeclared class \App\YetiForce\Order
Open

        $viewer->assign('FORM_FIELDS', (new \App\YetiForce\Order())->getFieldInstances());
Severity: Critical
Found in modules/Settings/YetiForce/views/BuyModal.php by phan

Call to undeclared method \Settings_YetiForce_BuyModal_View::getViewer
Open

        $viewer = $this->getViewer($request);
Severity: Critical
Found in modules/Settings/YetiForce/views/BuyModal.php by phan

Static call to undeclared method \App\Controller\ModalSettings::preProcessAjax
Open

        parent::preProcessAjax($request);
Severity: Critical
Found in modules/Settings/YetiForce/views/BuyModal.php by phan

Call to method getPaypalUrl from undeclared class \App\YetiForce\Shop
Open

        $viewer->assign('PAYPAL_URL', \App\YetiForce\Shop::getPaypalUrl());
Severity: Critical
Found in modules/Settings/YetiForce/views/BuyModal.php by phan

Reference to undeclared property \Settings_YetiForce_BuyModal_View->pageTitle
Open

        $this->pageTitle = \App\Language::translate('LBL_BUY', $qualifiedModuleName);
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phan

Reference to undeclared property \Settings_YetiForce_BuyModal_View->modalIcon
Open

        $this->modalIcon = 'yfi-marketplace';
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phan

Call to method getFieldInstances from undeclared class \App\YetiForce\Order
Open

        $viewer->assign('FORM_FIELDS', (new \App\YetiForce\Order())->getFieldInstances());
Severity: Critical
Found in modules/Settings/YetiForce/views/BuyModal.php by phan

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Settings_YetiForce_BuyModal_View extends \App\Controller\ModalSettings
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

The class Settings_YetiForce_BuyModal_View is not named in CamelCase.
Open

class Settings_YetiForce_BuyModal_View extends \App\Controller\ModalSettings
{
    /** {@inheritdoc} */
    public $successBtn = 'LBL_SHOP_PROCEED_TO_CHECKOUT';
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer = $this->getViewer($request);
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->view('BuyModal.tpl', $qualifiedModuleName);
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $this->modalIcon = 'yfi-marketplace';
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $this->pageTitle = \App\Language::translate('LBL_BUY', $qualifiedModuleName);
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $successBtn = 'LBL_SHOP_PROCEED_TO_CHECKOUT';
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('RECORD', Settings_Companies_Record_Model::getInstance());
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('VARIABLE', $product->getVariable());
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $successBtnIcon = 'far fa-credit-card';
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     *
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $qualifiedModuleName = $request->getModule(false);
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $product = \App\YetiForce\Shop::getProduct($request->getByType('product', \App\Purifier::ALNUM2), $productId);
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('PAYPAL_URL', \App\YetiForce\Shop::getPaypalUrl());
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function process(App\Request $request): void
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('MODULE', $qualifiedModuleName);
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('PRODUCT', $product);
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * Header class.
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $headerClass = 'modal-header-xl';
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @var string
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $productId = $request->isEmpty('productId') ? '' : $request->getByType('productId', \App\Purifier::ALNUM2);
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('IMAGE', $product->getImage());
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $qualifiedModuleName = $request->getModule(false);
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function preProcessAjax(App\Request $request): void
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        parent::preProcessAjax($request);
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('FORM_FIELDS', (new \App\YetiForce\Order())->getFieldInstances());
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

Class name "Settings_YetiForce_BuyModal_View" is not in camel caps format
Open

class Settings_YetiForce_BuyModal_View extends \App\Controller\ModalSettings
Severity: Minor
Found in modules/Settings/YetiForce/views/BuyModal.php by phpcodesniffer

There are no issues that match your filters.

Category
Status