Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Users/files/MultiImage.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Missing class import via use statement (line '28', column '14').
Open

            throw new \App\Exceptions\NoPermitted('LBL_PERMISSION_DENIED', 406);
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class '\App\Field' in method 'getCheckPermission'.
Open

        if (!$request->has('record') || ('imagename' !== $fieldName && (!\App\Privilege::isPermitted('Users', 'DetailView', $request->getInteger('record')) || !\App\Field::getFieldPermission('Users', $fieldName)))) {
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Privilege' in method 'getCheckPermission'.
Open

        if (!$request->has('record') || ('imagename' !== $fieldName && (!\App\Privilege::isPermitted('Users', 'DetailView', $request->getInteger('record')) || !\App\Field::getFieldPermission('Users', $fieldName)))) {
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Users_MultiImage_File extends Vtiger_MultiImage_File
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

The class Users_MultiImage_File is not named in CamelCase.
Open

class Users_MultiImage_File extends Vtiger_MultiImage_File
{
    /**
     * Checking permission in get method.
     *
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

The 'getCheckPermission()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getCheckPermission(App\Request $request)
    {
        $fieldName = $request->getByType('field', 2);
        if (!$request->has('record') || ('imagename' !== $fieldName && (!\App\Privilege::isPermitted('Users', 'DetailView', $request->getInteger('record')) || !\App\Field::getFieldPermission('Users', $fieldName)))) {
            throw new \App\Exceptions\NoPermitted('LBL_PERMISSION_DENIED', 406);
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

Spaces must be used to indent lines; tabs are not allowed
Open

        $fieldName = $request->getByType('field', 2);
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @return bool
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     *
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @throws \App\Exceptions\NoPermitted
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function getCheckPermission(App\Request $request)
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

Line exceeds 120 characters; contains 216 characters
Open

        if (!$request->has('record') || ('imagename' !== $fieldName && (!\App\Privilege::isPermitted('Users', 'DetailView', $request->getInteger('record')) || !\App\Field::getFieldPermission('Users', $fieldName)))) {
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return true;
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * Checking permission in get method.
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     *
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     *
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param \App\Request $request
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        if (!$request->has('record') || ('imagename' !== $fieldName && (!\App\Privilege::isPermitted('Users', 'DetailView', $request->getInteger('record')) || !\App\Field::getFieldPermission('Users', $fieldName)))) {
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            throw new \App\Exceptions\NoPermitted('LBL_PERMISSION_DENIED', 406);
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

Class name "Users_MultiImage_File" is not in camel caps format
Open

class Users_MultiImage_File extends Vtiger_MultiImage_File
Severity: Minor
Found in modules/Users/files/MultiImage.php by phpcodesniffer

There are no issues that match your filters.

Category
Status