Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Users/models/Picklist.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Missing class import via use statement (line '20', column '14').
Open

            throw new \App\Exceptions\Security('ERR_ILLEGAL_FIELD_VALUE||' . $this->getFieldModel()->getFieldName() . '||' . $this->getFieldModel()->getModuleName(), 406);
Severity: Minor
Found in modules/Users/models/Picklist.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method setValueFromRequest has a boolean flag argument $requestFieldName, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function setValueFromRequest(App\Request $request, Vtiger_Record_Model $recordModel, $requestFieldName = false)
Severity: Minor
Found in modules/Users/models/Picklist.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid using static access to class '\App\User' in method 'setValueFromRequest'.
Open

        $currentModel = \App\User::getCurrentUserModel();
Severity: Minor
Found in modules/Users/models/Picklist.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to method getCurrentUserModel from undeclared class \App\User (Did you mean class \Tests\App\User)
Open

        $currentModel = \App\User::getCurrentUserModel();
Severity: Critical
Found in modules/Users/models/Picklist.php by phan

Call to deprecated function \Vtiger_Field_Model::getFieldName() defined at /code/modules/Vtiger/models/Field.php:203
Open

            throw new \App\Exceptions\Security('ERR_ILLEGAL_FIELD_VALUE||' . $this->getFieldModel()->getFieldName() . '||' . $this->getFieldModel()->getModuleName(), 406);
Severity: Minor
Found in modules/Users/models/Picklist.php by phan

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Users_Picklist_UIType extends Vtiger_Picklist_UIType
Severity: Minor
Found in modules/Users/models/Picklist.php by phpcodesniffer

The class Users_Picklist_UIType is not named in CamelCase.
Open

class Users_Picklist_UIType extends Vtiger_Picklist_UIType
{
    /** {@inheritdoc} */
    public function setValueFromRequest(App\Request $request, Vtiger_Record_Model $recordModel, $requestFieldName = false)
    {
Severity: Minor
Found in modules/Users/models/Picklist.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Line exceeds 120 characters; contains 122 characters
Open

    public function setValueFromRequest(App\Request $request, Vtiger_Record_Model $recordModel, $requestFieldName = false)
Severity: Minor
Found in modules/Users/models/Picklist.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function setValueFromRequest(App\Request $request, Vtiger_Record_Model $recordModel, $requestFieldName = false)
Severity: Minor
Found in modules/Users/models/Picklist.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Users/models/Picklist.php by phpcodesniffer

Line exceeds 120 characters; contains 141 characters
Open

        if (115 === $this->getFieldModel()->getUIType() && (!$currentModel->isAdmin() || $currentModel->getId() === $recordModel->getId())) {
Severity: Minor
Found in modules/Users/models/Picklist.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $currentModel = \App\User::getCurrentUserModel();
Severity: Minor
Found in modules/Users/models/Picklist.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Users/models/Picklist.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            throw new \App\Exceptions\Security('ERR_ILLEGAL_FIELD_VALUE||' . $this->getFieldModel()->getFieldName() . '||' . $this->getFieldModel()->getModuleName(), 406);
Severity: Minor
Found in modules/Users/models/Picklist.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/Users/models/Picklist.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        if (115 === $this->getFieldModel()->getUIType() && (!$currentModel->isAdmin() || $currentModel->getId() === $recordModel->getId())) {
Severity: Minor
Found in modules/Users/models/Picklist.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        parent::setValueFromRequest($request, $recordModel, $requestFieldName);
Severity: Minor
Found in modules/Users/models/Picklist.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Users/models/Picklist.php by phpcodesniffer

Line exceeds 120 characters; contains 171 characters
Open

            throw new \App\Exceptions\Security('ERR_ILLEGAL_FIELD_VALUE||' . $this->getFieldModel()->getFieldName() . '||' . $this->getFieldModel()->getModuleName(), 406);
Severity: Minor
Found in modules/Users/models/Picklist.php by phpcodesniffer

Class name "Users_Picklist_UIType" is not in camel caps format
Open

class Users_Picklist_UIType extends Vtiger_Picklist_UIType
Severity: Minor
Found in modules/Users/models/Picklist.php by phpcodesniffer

There are no issues that match your filters.

Category
Status