Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Users/views/Detail.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Avoid using static access to class 'Vtiger_Record_Model' in method 'process'.
Open

        $recordModel = !empty($this->record) ? $this->record->getRecord() : Vtiger_Record_Model::getInstanceById($request->getInteger('record'), $request->getModule());
Severity: Minor
Found in modules/Users/views/Detail.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Json' in method 'process'.
Open

        $viewer->assign('DAY_STARTS', \App\Json::encode($dayStartPicklistValues));
Severity: Minor
Found in modules/Users/views/Detail.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Class extends undeclared class \Vtiger_Detail_View
Open

class Users_Detail_View extends Vtiger_Detail_View
Severity: Critical
Found in modules/Users/views/Detail.php by phan

Reference to undeclared property \Users_Detail_View->record
Open

        $recordModel = !empty($this->record) ? $this->record->getRecord() : Vtiger_Record_Model::getInstanceById($request->getInteger('record'), $request->getModule());
Severity: Minor
Found in modules/Users/views/Detail.php by phan

Call to undeclared method \Users_Detail_View::getViewer
Open

        $viewer = $this->getViewer($request);
Severity: Critical
Found in modules/Users/views/Detail.php by phan

Call to undeclared method \Vtiger_Record_Model::getDayStartsPicklistValues
Open

        $dayStartPicklistValues = $recordModel->getDayStartsPicklistValues();
Severity: Critical
Found in modules/Users/views/Detail.php by phan

Reference to undeclared class \Vtiger_Detail_View
Open

        return parent::process($request);
Severity: Critical
Found in modules/Users/views/Detail.php by phan

Avoid excessively long variable names like $dayStartPicklistValues. Keep variable name length under 20.
Open

        $dayStartPicklistValues = $recordModel->getDayStartsPicklistValues();
Severity: Minor
Found in modules/Users/views/Detail.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Users_Detail_View extends Vtiger_Detail_View
Severity: Minor
Found in modules/Users/views/Detail.php by phpcodesniffer

The class Users_Detail_View is not named in CamelCase.
Open

class Users_Detail_View extends Vtiger_Detail_View
{
    /** {@inheritdoc} */
    public function isAjaxEnabled($recordModel)
    {
Severity: Minor
Found in modules/Users/views/Detail.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

        $dayStartPicklistValues = $recordModel->getDayStartsPicklistValues();
Severity: Minor
Found in modules/Users/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Users/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Users/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Users/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function isAjaxEnabled($recordModel)
Severity: Minor
Found in modules/Users/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Users/views/Detail.php by phpcodesniffer

Line exceeds 120 characters; contains 168 characters
Open

        $recordModel = !empty($this->record) ? $this->record->getRecord() : Vtiger_Record_Model::getInstanceById($request->getInteger('record'), $request->getModule());
Severity: Minor
Found in modules/Users/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('DAY_STARTS', \App\Json::encode($dayStartPicklistValues));
Severity: Minor
Found in modules/Users/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function process(App\Request $request)
Severity: Minor
Found in modules/Users/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Users/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return false;
Severity: Minor
Found in modules/Users/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Users/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $recordModel = !empty($this->record) ? $this->record->getRecord() : Vtiger_Record_Model::getInstanceById($request->getInteger('record'), $request->getModule());
Severity: Minor
Found in modules/Users/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer = $this->getViewer($request);
Severity: Minor
Found in modules/Users/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return parent::process($request);
Severity: Minor
Found in modules/Users/views/Detail.php by phpcodesniffer

Class name "Users_Detail_View" is not in camel caps format
Open

class Users_Detail_View extends Vtiger_Detail_View
Severity: Minor
Found in modules/Users/views/Detail.php by phpcodesniffer

There are no issues that match your filters.

Category
Status