YetiForceCompany/YetiForceCRM

View on GitHub
modules/Users/views/NoAccessModal.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '46', column '14').
Open

            throw new \App\Exceptions\AppException('LBL_PERMISSION_DENIED');
Severity: Minor
Found in modules/Users/views/NoAccessModal.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'App\YetiForce\Register' in method 'checkPermission'.
Open

        if (App\YetiForce\Register::isPreRegistered() || \App\User::getCurrentUserModel()->isAdmin()) {
Severity: Minor
Found in modules/Users/views/NoAccessModal.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Class extends undeclared class \App\Controller\Modal
Open

class Users_NoAccessModal_View extends \App\Controller\Modal
Severity: Critical
Found in modules/Users/views/NoAccessModal.php by phan

Call to method getCurrentUserModel from undeclared class \App\User (Did you mean class \Tests\App\User)
Open

        if (App\YetiForce\Register::isPreRegistered() || \App\User::getCurrentUserModel()->isAdmin()) {
Severity: Critical
Found in modules/Users/views/NoAccessModal.php by phan

Call to undeclared method \Users_NoAccessModal_View::getViewer
Open

        $viewer = $this->getViewer($request);
Severity: Critical
Found in modules/Users/views/NoAccessModal.php by phan

Call to method isPreRegistered from undeclared class \App\YetiForce\Register
Open

        if (App\YetiForce\Register::isPreRegistered() || \App\User::getCurrentUserModel()->isAdmin()) {
Severity: Critical
Found in modules/Users/views/NoAccessModal.php by phan

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Users_NoAccessModal_View extends \App\Controller\Modal

The class Users_NoAccessModal_View is not named in CamelCase.
Open

class Users_NoAccessModal_View extends \App\Controller\Modal
{
    /**
     * Event parameters.
     */
Severity: Minor
Found in modules/Users/views/NoAccessModal.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

     * Event parameters.

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

    public function checkPermission(App\Request $request): void

Spaces must be used to indent lines; tabs are not allowed
Open

        'execution' => 'constant',

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Spaces must be used to indent lines; tabs are not allowed
Open

        }

Spaces must be used to indent lines; tabs are not allowed
Open

    public $modalSize = 'modal-lg';

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

    public const MODAL_EVENT = [

Spaces must be used to indent lines; tabs are not allowed
Open

        'priority' => 10,

Spaces must be used to indent lines; tabs are not allowed
Open

    /** @inheritdoc  */

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

    /** @inheritdoc  */

Spaces must be used to indent lines; tabs are not allowed
Open

        if (App\YetiForce\Register::isPreRegistered() || \App\User::getCurrentUserModel()->isAdmin()) {

Spaces must be used to indent lines; tabs are not allowed
Open

        'name' => 'NoAccessModal',

Spaces must be used to indent lines; tabs are not allowed
Open

            throw new \App\Exceptions\AppException('LBL_PERMISSION_DENIED');

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

        'type' => 'modal',

Spaces must be used to indent lines; tabs are not allowed
Open

    ];

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer = $this->getViewer($request);

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->view('Modals/NoAccessModal.tpl', $request->getModule(false));

Spaces must be used to indent lines; tabs are not allowed
Open

    public $modalIcon = 'fas fa-radiation-alt';

Spaces must be used to indent lines; tabs are not allowed
Open

    public $showFooter = false;

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

    public function process(App\Request $request): void

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

        'url' => 'index.php?module=Users&view=NoAccessModal',

Spaces must be used to indent lines; tabs are not allowed
Open

    public $pageTitle = 'LBL_NO_ACCESS_TITLE';

Spaces must be used to indent lines; tabs are not allowed
Open

    public $lockExit = true;

Class name "Users_NoAccessModal_View" is not in camel caps format
Open

class Users_NoAccessModal_View extends \App\Controller\Modal

There are no issues that match your filters.

Category
Status