Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Vendors/models/Module.php

Summary

Maintainability
A
55 mins
Test Coverage
F
0%

Missing class import via use statement (line '23', column '21').
Open

            $subQuery = (new App\Db\Query())
Severity: Minor
Found in modules/Vendors/models/Module.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid unused parameters such as '$field'.
Open

    public function getQueryByModuleField($sourceModule, $field, $record, App\QueryGenerator $queryGenerator)
Severity: Minor
Found in modules/Vendors/models/Module.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Call to method addNativeCondition from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
Open

            $queryGenerator->addNativeCondition(['not in', 'vtiger_vendor.vendorid', $subQuery]);
Severity: Critical
Found in modules/Vendors/models/Module.php by phan

Call to undeclared method \App\Db\Query::select
Open

            $subQuery = (new App\Db\Query())
Severity: Critical
Found in modules/Vendors/models/Module.php by phan

Parameter $queryGenerator has undeclared type \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
Open

    public function getQueryByModuleField($sourceModule, $field, $record, App\QueryGenerator $queryGenerator)
Severity: Minor
Found in modules/Vendors/models/Module.php by phan

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/**
 * Vendors module model Class.
 *
Severity: Minor
Found in modules/Vendors/models/Module.php and 1 other location - About 55 mins to fix
modules/Competition/models/Module.php on lines 1..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Vendors_Module_Model extends Vtiger_Module_Model
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

The class Vendors_Module_Model is not named in CamelCase.
Open

class Vendors_Module_Model extends Vtiger_Module_Model
{
    /**
     * Function to get list view query for popup window.
     *
Severity: Minor
Found in modules/Vendors/models/Module.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param string              $field          parent fieldname
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $queryGenerator->addNativeCondition(['not in', 'vtiger_vendor.vendorid', $subQuery]);
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     *
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        if ('Campaigns' == $sourceModule) {
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $subQuery = (new App\Db\Query())
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                ->select(['crmid'])
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param \App\QueryGenerator $queryGenerator
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param string              $record         parent id
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                ->from('vtiger_campaign_records')
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * Function to get list view query for popup window.
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param string              $sourceModule   Parent module
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                ->where(['campaignid' => $record]);
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function getQueryByModuleField($sourceModule, $field, $record, App\QueryGenerator $queryGenerator)
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

Class name "Vendors_Module_Model" is not in camel caps format
Open

class Vendors_Module_Model extends Vtiger_Module_Model
Severity: Minor
Found in modules/Vendors/models/Module.php by phpcodesniffer

There are no issues that match your filters.

Category
Status