YetiForceCompany/YetiForceCRM

View on GitHub
modules/Vtiger/actions/MassSave.php

Summary

Maintainability
A
1 hr
Test Coverage
F
0%

Function getRecordModelsFromRequest has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function getRecordModelsFromRequest(App\Request $request)
    {
        $moduleName = $request->getModule();
        $moduleModel = Vtiger_Module_Model::getInstance($moduleName);
        $recordIds = Vtiger_Mass_Action::getRecordsListFromRequest($request);
Severity: Minor
Found in modules/Vtiger/actions/MassSave.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '25', column '14').
Open

            throw new \App\Exceptions\NoPermitted('LBL_PERMISSION_DENIED', 406);
Severity: Minor
Found in modules/Vtiger/actions/MassSave.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '41', column '19').
Open

        $response = new Vtiger_Response();
Severity: Minor
Found in modules/Vtiger/actions/MassSave.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'Vtiger_Record_Model' in method 'getRecordModelsFromRequest'.
Open

            $recordModel = Vtiger_Record_Model::getInstanceById($recordId, $moduleModel);
Severity: Minor
Found in modules/Vtiger/actions/MassSave.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $allRecordSave = false;
            }
Severity: Minor
Found in modules/Vtiger/actions/MassSave.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'Vtiger_Mass_Action' in method 'getRecordModelsFromRequest'.
Open

        $recordIds = Vtiger_Mass_Action::getRecordsListFromRequest($request);
Severity: Minor
Found in modules/Vtiger/actions/MassSave.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Vtiger_Module_Model' in method 'getRecordModelsFromRequest'.
Open

        $moduleModel = Vtiger_Module_Model::getInstance($moduleName);
Severity: Minor
Found in modules/Vtiger/actions/MassSave.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Users_Privileges_Model' in method 'checkPermission'.
Open

        $userPriviligesModel = Users_Privileges_Model::getCurrentUserPrivilegesModel();
Severity: Minor
Found in modules/Vtiger/actions/MassSave.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to undeclared method \Vtiger_Base_UIType::setValueFromMassEdit
Open

                    if (!method_exists($fieldUiTypeModel, 'setValueFromMassEdit') || !$fieldUiTypeModel->setValueFromMassEdit($request, $recordModel)) {
Severity: Critical
Found in modules/Vtiger/actions/MassSave.php by phan

Argument 2 (module) is \Vtiger_Module_Model|\vtlib\Module|\vtlib\ModuleBasic but \Vtiger_Record_Model::getInstanceById() takes string defined at /code/modules/Vtiger/models/Record.php:763
Open

            $recordModel = Vtiger_Record_Model::getInstanceById($recordId, $moduleModel);
Severity: Minor
Found in modules/Vtiger/actions/MassSave.php by phan

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Vtiger_MassSave_Action extends Vtiger_Mass_Action

The class Vtiger_MassSave_Action is not named in CamelCase.
Open

class Vtiger_MassSave_Action extends Vtiger_Mass_Action
{
    /**
     * Function to check permission.
     *
Severity: Minor
Found in modules/Vtiger/actions/MassSave.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

        $recordModels = $this->getRecordModelsFromRequest($request);

Spaces must be used to indent lines; tabs are not allowed
Open

        }

Spaces must be used to indent lines; tabs are not allowed
Open

        foreach ($recordModels as $recordModel) {

Spaces must be used to indent lines; tabs are not allowed
Open

            if (false !== $recordModel) {

Spaces must be used to indent lines; tabs are not allowed
Open

        }

Spaces must be used to indent lines; tabs are not allowed
Open

                $recordModels[$recordId] = false;

Spaces must be used to indent lines; tabs are not allowed
Open

                    $fieldUiTypeModel = $fieldModel->getUITypeModel();

Spaces must be used to indent lines; tabs are not allowed
Open

    public function checkPermission(App\Request $request)

Spaces must be used to indent lines; tabs are not allowed
Open

    public function process(App\Request $request)

Spaces must be used to indent lines; tabs are not allowed
Open

            }

Spaces must be used to indent lines; tabs are not allowed
Open

        $response = new Vtiger_Response();

Spaces must be used to indent lines; tabs are not allowed
Open

        $moduleModel = Vtiger_Module_Model::getInstance($moduleName);

Spaces must be used to indent lines; tabs are not allowed
Open

        $recordModels = [];

Spaces must be used to indent lines; tabs are not allowed
Open

                if ($fieldModel->isWritable() && $request->has($fieldName)) {

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

            }

Spaces must be used to indent lines; tabs are not allowed
Open

        $allRecordSave = true;

Spaces must be used to indent lines; tabs are not allowed
Open

                $allRecordSave = false;

Spaces must be used to indent lines; tabs are not allowed
Open

        $response->setResult($allRecordSave);

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

        $response->emit();

Spaces must be used to indent lines; tabs are not allowed
Open

    public function getRecordModelsFromRequest(App\Request $request)

Spaces must be used to indent lines; tabs are not allowed
Open

        $recordIds = Vtiger_Mass_Action::getRecordsListFromRequest($request);

Spaces must be used to indent lines; tabs are not allowed
Open

        return $recordModels;

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

                unset($recordModel);

Spaces must be used to indent lines; tabs are not allowed
Open

     * @return Vtiger_Record_Model[] - List of Vtiger_Record_Model instances

Spaces must be used to indent lines; tabs are not allowed
Open

        $moduleName = $request->getModule();

Spaces must be used to indent lines; tabs are not allowed
Open

                    if (!method_exists($fieldUiTypeModel, 'setValueFromMassEdit') || !$fieldUiTypeModel->setValueFromMassEdit($request, $recordModel)) {

Spaces must be used to indent lines; tabs are not allowed
Open

                }

Spaces must be used to indent lines; tabs are not allowed
Open

        $userPriviligesModel = Users_Privileges_Model::getCurrentUserPrivilegesModel();

Spaces must be used to indent lines; tabs are not allowed
Open

                $recordModel->save();

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

                    }

Spaces must be used to indent lines; tabs are not allowed
Open

     * @throws \App\Exceptions\NoPermitted

Spaces must be used to indent lines; tabs are not allowed
Open

     * Function to get the record model based on the request parameters.

Spaces must be used to indent lines; tabs are not allowed
Open

        $fieldModelList = $moduleModel->getFields();

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

     * Function to check permission.

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

            } else {

Spaces must be used to indent lines; tabs are not allowed
Open

                continue;

Spaces must be used to indent lines; tabs are not allowed
Open

                $recordModels[$recordId] = $recordModel;

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

        foreach ($recordIds as $recordId) {

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param \App\Request $request

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param \App\Request $request

Spaces must be used to indent lines; tabs are not allowed
Open

            $recordModel = Vtiger_Record_Model::getInstanceById($recordId, $moduleModel);

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Line exceeds 120 characters; contains 152 characters
Open

                    if (!method_exists($fieldUiTypeModel, 'setValueFromMassEdit') || !$fieldUiTypeModel->setValueFromMassEdit($request, $recordModel)) {

Spaces must be used to indent lines; tabs are not allowed
Open

                        $fieldUiTypeModel->setValueFromRequest($request, $recordModel);

Spaces must be used to indent lines; tabs are not allowed
Open

        if (!$userPriviligesModel->hasModuleActionPermission($request->getModule(), 'MassEdit')) {

Spaces must be used to indent lines; tabs are not allowed
Open

            throw new \App\Exceptions\NoPermitted('LBL_PERMISSION_DENIED', 406);

Spaces must be used to indent lines; tabs are not allowed
Open

        }

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

            if (!$recordModel->isEditable()) {

Spaces must be used to indent lines; tabs are not allowed
Open

            }

Spaces must be used to indent lines; tabs are not allowed
Open

            foreach ($fieldModelList as $fieldName => $fieldModel) {

Class name "Vtiger_MassSave_Action" is not in camel caps format
Open

class Vtiger_MassSave_Action extends Vtiger_Mass_Action

There are no issues that match your filters.

Category
Status