modules/Vtiger/actions/NoteBook.php
Avoid using undefined variables such as '$dataValue' which will lead to PHP notices. Open
Open
$dataValue['contents'] = $request->getByType('notePadContent', 'Text');- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$dataValue' which will lead to PHP notices. Open
Open
$dataValue['lastSavedOn'] = date('Y-m-d H:i:s');- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$dataValue' which will lead to PHP notices. Open
Open
$data = \App\Json::encode((object) $dataValue);- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Missing class import via use statement (line '57', column '19'). Open
Open
$response = new Vtiger_Response();- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '27', column '14'). Open
Open
throw new \App\Exceptions\NoPermittedForAdmin('LBL_PERMISSION_DENIED');- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class '\App\Json' in method 'noteBookCreate'. Open
Open
$data = \App\Json::encode((object) $dataValue);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Json' in method 'noteBookCreate'. Open
Open
$size = \App\Json::encode(['width' => $request->getInteger('width'), 'height' => $request->getInteger('height')]);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Users_Record_Model' in method 'checkPermission'. Open
Open
$currentUserModel = Users_Record_Model::getCurrentUserModel();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Db' in method 'noteBookCreate'. Open
Open
$db = \App\Db::getInstance();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid unused parameters such as '$request'. Open
Open
public function checkPermission(App\Request $request)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Variable $dataValue was undeclared, but array fields are being added to it. Open
Open
$dataValue['contents'] = $request->getByType('notePadContent', 'Text');- Exclude checks
Call to undeclared method \App\Db::createCommand Open
Open
$db->createCommand()- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Vtiger_NoteBook_Action extends \App\Controller\Action- Exclude checks
Avoid variables with short names like $db. Configured minimum length is 3. Open
Open
$db = \App\Db::getInstance();- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
The class Vtiger_NoteBook_Action is not named in CamelCase. Open
Open
class Vtiger_NoteBook_Action extends \App\Controller\Action
{
use \App\Controller\ExposeMethod;
/**- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
$currentUserModel = Users_Record_Model::getCurrentUserModel();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function noteBookCreate(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$size = \App\Json::encode(['width' => $request->getInteger('width'), 'height' => $request->getInteger('height')]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->exposeMethod('noteBookCreate');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function checkPermission(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @throws \App\Exceptions\NoPermittedForAdmin- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function __construct()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$dataValue['contents'] = $request->getByType('notePadContent', 'Text');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param \App\Request $request- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!$currentUserModel->isAdminUser()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
throw new \App\Exceptions\NoPermittedForAdmin('LBL_PERMISSION_DENIED');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
parent::__construct();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$response = new Vtiger_Response();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to check permission.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$result['widgetId'] = $db->getLastInsertID('vtiger_module_dashboard_id_seq');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->insert('vtiger_module_dashboard', [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$dataValue['lastSavedOn'] = date('Y-m-d H:i:s');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$data = \App\Json::encode((object) $dataValue);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'blockid' => $request->getInteger('blockid'),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$db->createCommand()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'isdefault' => $request->getInteger('isdefault'),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
use \App\Controller\ExposeMethod;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$db = \App\Db::getInstance();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'filterid' => 0,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkid' => $request->getInteger('linkId'),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'data' => $data,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$result = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$response->setResult($result);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'title' => $request->getByType('notePadName', 'Text'),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'size' => $size,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$result['success'] = true;- Exclude checks
Line exceeds 120 characters; contains 122 characters Open
Open
$size = \App\Json::encode(['width' => $request->getInteger('width'), 'height' => $request->getInteger('height')]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
])->execute();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$response->emit();- Exclude checks
Class name "Vtiger_NoteBook_Action" is not in camel caps format Open
Open
class Vtiger_NoteBook_Action extends \App\Controller\Action- Exclude checks