Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Vtiger/actions/Workflow.php

Summary

Maintainability
B
4 hrs
Test Coverage
F
0%

Consider simplifying this complex logical expression.
Open

        if ($request->isEmpty('record', true)
        || (!$recordModel = Vtiger_Record_Model::getInstanceById($request->getInteger('record'), $request->getModule()))
        || !$recordModel->isPermitted('WorkflowTrigger')
        || !$recordModel->isPermitted('DetailView')
        || (!$recordModel->isPermitted('EditView') || ($recordModel->isPermitted('EditView') && !$recordModel->isPermitted('WorkflowTriggerWhenRecordIsBlocked') && !$recordModel->isBlocked()))) {
Severity: Critical
Found in modules/Vtiger/actions/Workflow.php - About 1 hr to fix

    Missing class import via use statement (line '29', column '14').
    Open

                throw new \App\Exceptions\NoPermittedToRecord('ERR_NO_PERMISSIONS_FOR_THE_RECORD', 406);
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '45', column '19').
    Open

            $response = new Vtiger_Response();
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid assigning values to variables in if clauses and the like (line '25', column '8').
    Open

        public function checkPermission(App\Request $request)
    {
        if ($request->isEmpty('record', true)
        || (!$recordModel = Vtiger_Record_Model::getInstanceById($request->getInteger('record'), $request->getModule()))
        || !$recordModel->isPermitted('WorkflowTrigger')
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid using static access to class 'Vtiger_Record_Model' in method 'checkPermission'.
    Open

            || (!$recordModel = Vtiger_Record_Model::getInstanceById($request->getInteger('record'), $request->getModule()))
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Vtiger_WorkflowTrigger_Model' in method 'execute'.
    Open

            \Vtiger_WorkflowTrigger_Model::execute($moduleName, $record, $user, $tasks);
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Define a constant instead of duplicating this literal "record" 3 times.
    Open

            if ($request->isEmpty('record', true)
    Severity: Critical
    Found in modules/Vtiger/actions/Workflow.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        public function checkPermission(App\Request $request)
    {
        if ($request->isEmpty('record', true)
        || (!$recordModel = Vtiger_Record_Model::getInstanceById($request->getInteger('record'), $request->getModule()))
        || !$recordModel->isPermitted('WorkflowTrigger')
    Severity: Major
    Found in modules/Vtiger/actions/Workflow.php and 1 other location - About 2 hrs to fix
    modules/Vtiger/views/WorkflowTrigger.php on lines 14..23

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 137.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class Vtiger_Workflow_Action extends \App\Controller\Action
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    The class Vtiger_Workflow_Action is not named in CamelCase.
    Open

    class Vtiger_Workflow_Action extends \App\Controller\Action
{
    use \App\Controller\ExposeMethod;

    public function __construct()
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $this->exposeMethod('execute');
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            || (!$recordModel = Vtiger_Record_Model::getInstanceById($request->getInteger('record'), $request->getModule()))
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Line exceeds 120 characters; contains 195 characters
    Open

            || (!$recordModel->isPermitted('EditView') || ($recordModel->isPermitted('EditView') && !$recordModel->isPermitted('WorkflowTriggerWhenRecordIsBlocked') && !$recordModel->isBlocked()))) {
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        use \App\Controller\ExposeMethod;
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                throw new \App\Exceptions\NoPermittedToRecord('ERR_NO_PERMISSIONS_FOR_THE_RECORD', 406);
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($request->isEmpty('record', true)
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $user = $request->getInteger('user');
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $tasks = $request->getArray('tasks', 'Integer');
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function __construct()
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $response = new Vtiger_Response();
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $record = $request->getInteger('record');
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param App\Request $request
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $response->emit();
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            parent::__construct();
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function checkPermission(App\Request $request)
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            || !$recordModel->isPermitted('WorkflowTrigger')
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function execute(App\Request $request)
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $response->setResult(true);
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            || (!$recordModel->isPermitted('EditView') || ($recordModel->isPermitted('EditView') && !$recordModel->isPermitted('WorkflowTriggerWhenRecordIsBlocked') && !$recordModel->isBlocked()))) {
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Execute workflow.
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            \Vtiger_WorkflowTrigger_Model::execute($moduleName, $record, $user, $tasks);
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            || !$recordModel->isPermitted('DetailView')
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $moduleName = $request->getModule();
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    Class name "Vtiger_Workflow_Action" is not in camel caps format
    Open

    class Vtiger_Workflow_Action extends \App\Controller\Action
    Severity: Minor
    Found in modules/Vtiger/actions/Workflow.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status