YetiForceCompany/YetiForceCRM

View on GitHub
modules/Vtiger/crons/BatchMethods.php

Summary

Maintainability
A
1 hr
Test Coverage
C
73%

Function process has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function process()
    {
        $query = (new \App\Db\Query())->from('s_#__batchmethod')->limit(10);
        while ($rows = $query->all()) {
            foreach ($rows as $row) {
Severity: Minor
Found in modules/Vtiger/crons/BatchMethods.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '25', column '28').
Open

                    $methodInstance = new \App\BatchMethod($row, false);
Severity: Minor
Found in modules/Vtiger/crons/BatchMethods.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '20', column '17').
Open

        $query = (new \App\Db\Query())->from('s_#__batchmethod')->limit(10);
Severity: Minor
Found in modules/Vtiger/crons/BatchMethods.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class '\App\Log' in method 'process'.
Open

                    \App\Log::error("Batch method error: Method: {$row['method']} | ID: {$row['id']} \n{$th->__toString()}", 'BatchMethods');
Severity: Minor
Found in modules/Vtiger/crons/BatchMethods.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to undeclared method \App\Db\Query::from
Open

        $query = (new \App\Db\Query())->from('s_#__batchmethod')->limit(10);
Severity: Critical
Found in modules/Vtiger/crons/BatchMethods.php by phan

Call to method error from undeclared class \App\Log
Open

                    \App\Log::error("Batch method error: Method: {$row['method']} | ID: {$row['id']} \n{$th->__toString()}", 'BatchMethods');
Severity: Critical
Found in modules/Vtiger/crons/BatchMethods.php by phan

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Vtiger_BatchMethods_Cron extends \App\CronHandler

The class Vtiger_BatchMethods_Cron is not named in CamelCase.
Open

class Vtiger_BatchMethods_Cron extends \App\CronHandler
{
    /** {@inheritdoc} */
    public function process()
    {
Severity: Minor
Found in modules/Vtiger/crons/BatchMethods.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

            foreach ($rows as $row) {

Spaces must be used to indent lines; tabs are not allowed
Open

                    throw $th;

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

                return;

Spaces must be used to indent lines; tabs are not allowed
Open

                    if ($methodInstance->isCompleted()) {

Spaces must be used to indent lines; tabs are not allowed
Open

    public function process()

Line exceeds 120 characters; contains 141 characters
Open

                    \App\Log::error("Batch method error: Method: {$row['method']} | ID: {$row['id']} \n{$th->__toString()}", 'BatchMethods');

Spaces must be used to indent lines; tabs are not allowed
Open

                $this->updateLastActionTime();

Spaces must be used to indent lines; tabs are not allowed
Open

                        $methodInstance->delete();

Spaces must be used to indent lines; tabs are not allowed
Open

                    $methodInstance->execute();

Spaces must be used to indent lines; tabs are not allowed
Open

        }

Spaces must be used to indent lines; tabs are not allowed
Open

        while ($rows = $query->all()) {

Spaces must be used to indent lines; tabs are not allowed
Open

                try {

Spaces must be used to indent lines; tabs are not allowed
Open

                } catch (\Throwable $th) {

Spaces must be used to indent lines; tabs are not allowed
Open

            }

Spaces must be used to indent lines; tabs are not allowed
Open

            }

Spaces must be used to indent lines; tabs are not allowed
Open

                    $methodInstance = new \App\BatchMethod($row, false);

Spaces must be used to indent lines; tabs are not allowed
Open

                    }

Spaces must be used to indent lines; tabs are not allowed
Open

                    \App\Log::error("Batch method error: Method: {$row['method']} | ID: {$row['id']} \n{$th->__toString()}", 'BatchMethods');

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

                    unset($methodInstance);

Spaces must be used to indent lines; tabs are not allowed
Open

            if ($this->checkTimeout()) {

Spaces must be used to indent lines; tabs are not allowed
Open

        $query = (new \App\Db\Query())->from('s_#__batchmethod')->limit(10);

Spaces must be used to indent lines; tabs are not allowed
Open

                }

Class name "Vtiger_BatchMethods_Cron" is not in camel caps format
Open

class Vtiger_BatchMethods_Cron extends \App\CronHandler

There are no issues that match your filters.

Category
Status