YetiForceCompany/YetiForceCRM

View on GitHub
modules/Vtiger/crons/Mailer.php

Summary

Maintainability
A
45 mins
Test Coverage
F
38%

Function process has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function process()
    {
        $limit = (int) App\Config::performance('CRON_MAX_NUMBERS_SENDING_MAILS', 1000);
        $query = (new \App\Db\Query())->from('s_#__mail_queue')->where(['status' => 1])->orderBy(['priority' => SORT_DESC, 'id' => SORT_ASC])->limit(20);
        $db = \App\Db::getInstance('admin');
Severity: Minor
Found in modules/Vtiger/crons/Mailer.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '21', column '17').
Open

        $query = (new \App\Db\Query())->from('s_#__mail_queue')->where(['status' => 1])->orderBy(['priority' => SORT_DESC, 'id' => SORT_ASC])->limit(20);
Severity: Minor
Found in modules/Vtiger/crons/Mailer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'App\Config' in method 'process'.
Open

        $limit = (int) App\Config::performance('CRON_MAX_NUMBERS_SENDING_MAILS', 1000);
Severity: Minor
Found in modules/Vtiger/crons/Mailer.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Db' in method 'process'.
Open

        $db = \App\Db::getInstance('admin');
Severity: Minor
Found in modules/Vtiger/crons/Mailer.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Mailer' in method 'process'.
Open

                \App\Mailer::sendByRowQueue($row);
Severity: Minor
Found in modules/Vtiger/crons/Mailer.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to undeclared method \App\Db\Query::from
Open

        $query = (new \App\Db\Query())->from('s_#__mail_queue')->where(['status' => 1])->orderBy(['priority' => SORT_DESC, 'id' => SORT_ASC])->limit(20);
Severity: Critical
Found in modules/Vtiger/crons/Mailer.php by phan

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Vtiger_Mailer_Cron extends \App\CronHandler

Avoid variables with short names like $db. Configured minimum length is 3.
Open

        $db = \App\Db::getInstance('admin');
Severity: Minor
Found in modules/Vtiger/crons/Mailer.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The class Vtiger_Mailer_Cron is not named in CamelCase.
Open

class Vtiger_Mailer_Cron extends \App\CronHandler
{
    /** {@inheritdoc} */
    public function process()
    {
Severity: Minor
Found in modules/Vtiger/crons/Mailer.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

        foreach ($query->batch(20, $db) as $rows) {

Spaces must be used to indent lines; tabs are not allowed
Open

            }

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

                \App\Mailer::sendByRowQueue($row);

Spaces must be used to indent lines; tabs are not allowed
Open

            }

Spaces must be used to indent lines; tabs are not allowed
Open

        $limit = (int) App\Config::performance('CRON_MAX_NUMBERS_SENDING_MAILS', 1000);

Spaces must be used to indent lines; tabs are not allowed
Open

        $query = (new \App\Db\Query())->from('s_#__mail_queue')->where(['status' => 1])->orderBy(['priority' => SORT_DESC, 'id' => SORT_ASC])->limit(20);

Line exceeds 120 characters; contains 153 characters
Open

        $query = (new \App\Db\Query())->from('s_#__mail_queue')->where(['status' => 1])->orderBy(['priority' => SORT_DESC, 'id' => SORT_ASC])->limit(20);

Spaces must be used to indent lines; tabs are not allowed
Open

                --$limit;

Spaces must be used to indent lines; tabs are not allowed
Open

                return;

Spaces must be used to indent lines; tabs are not allowed
Open

                }

Spaces must be used to indent lines; tabs are not allowed
Open

            $this->updateLastActionTime();

Spaces must be used to indent lines; tabs are not allowed
Open

                    return;

Spaces must be used to indent lines; tabs are not allowed
Open

    public function process()

Spaces must be used to indent lines; tabs are not allowed
Open

            foreach ($rows as $row) {

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

        $db = \App\Db::getInstance('admin');

Spaces must be used to indent lines; tabs are not allowed
Open

                if (0 >= $limit) {

Spaces must be used to indent lines; tabs are not allowed
Open

            if ($this->checkTimeout()) {

Spaces must be used to indent lines; tabs are not allowed
Open

        }

Class name "Vtiger_Mailer_Cron" is not in camel caps format
Open

class Vtiger_Mailer_Cron extends \App\CronHandler

There are no issues that match your filters.

Category
Status