YetiForceCompany/YetiForceCRM

Method process has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function process(App\Request $request)
    {
        $currentUser = Users_Record_Model::getCurrentUserModel();
        $viewer = $this->getViewer($request);
        $moduleName = $request->getModule();

Missing class import via use statement (line '30', column '22').

Open

        $pagingModel = new Vtiger_Paging_Model();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid using static access to class 'Settings_WidgetsManagement_Module_Model' in method 'process'.

Open

            $owner = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'Vtiger_Widget_Model' in method 'process'.

Open

        $widget = Vtiger_Widget_Model::getInstance($linkId, $currentUser->getId());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'Vtiger_Module_Model' in method 'process'.

Open

        $moduleModel = Vtiger_Module_Model::getInstance($moduleName);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Config' in method 'process'.

Open

        $href_max_length = \App\Config::main('href_max_length');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Config' in method 'process'.

Open

        $title_max_length = \App\Config::main('title_max_length');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $owner = $request->getByType('owner', 2);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $viewer->view('dashboards/AssignedProjectsTasks.tpl', $moduleName);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class 'Users_Record_Model' in method 'process'.

Open

        $currentUser = Users_Record_Model::getCurrentUserModel();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('MODULE_NAME', $moduleName);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('USER_CONDITIONS', ['condition' => ['<', 'targetenddate', $currentDate]]);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('PROJECTSTASKS', $projectsTasks);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('HREFNAMELENGTH', $href_max_length);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('CURRENTUSER', $currentUser);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('NODATAMSGLABLE', 'LBL_NO_OVERDUE_ACTIVITIES');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('OWNER', $owner);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('SOURCE_MODULE', 'ProjectTask');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('WIDGET', $widget);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Module_Model::getAssignedProjectsTasks

Open

        $projectsTasks = (false === $owner) ? [] : $moduleModel->getAssignedProjectsTasks('overdue', $pagingModel, $owner);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('NAMELENGTH', $title_max_length);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('DATA', $data);

• Exclude checks
  • Disable engine
  • Disable check

Call to method getInstance from undeclared class \Vtiger_Widget_Model

Open

        $widget = Vtiger_Widget_Model::getInstance($linkId, $currentUser->getId());

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('PAGING_MODEL', $pagingModel);

• Exclude checks
  • Disable engine
  • Disable check

Avoid excessively long class names like Vtiger_AssignedOverdueProjectsTasks_Dashboard. Keep class name length under 40.

Open

class Vtiger_AssignedOverdueProjectsTasks_Dashboard extends Vtiger_IndexAjax_View
{
    public function process(App\Request $request)
    {
        $currentUser = Users_Record_Model::getCurrentUserModel();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class Vtiger_AssignedOverdueProjectsTasks_Dashboard extends Vtiger_IndexAjax_View

• Exclude checks
  • Disable engine
  • Disable check

The class Vtiger_AssignedOverdueProjectsTasks_Dashboard is not named in CamelCase.

Open

class Vtiger_AssignedOverdueProjectsTasks_Dashboard extends Vtiger_IndexAjax_View
{
    public function process(App\Request $request)
    {
        $currentUser = Users_Record_Model::getCurrentUserModel();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class class_name {
}

Spaces must be used to indent lines; tabs are not allowed

Open

        $currentUser = Users_Record_Model::getCurrentUserModel();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function process(App\Request $request)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $page = $request->getInteger('page');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $data = $request->getAll();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('PAGING_MODEL', $pagingModel);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('CURRENTUSER', $currentUser);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('NAMELENGTH', $title_max_length);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $viewer->view('dashboards/AssignedProjectsTasksContents.tpl', $moduleName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $moduleName = $request->getModule();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $moduleModel = Vtiger_Module_Model::getInstance($moduleName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('MODULE_NAME', $moduleName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('PROJECTSTASKS', $projectsTasks);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer = $this->getViewer($request);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!$request->has('owner')) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $pagingModel = new Vtiger_Paging_Model();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $currentDate = date('Y-m-d');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $owner = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget);

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 123 characters

Open

        $projectsTasks = (false === $owner) ? [] : $moduleModel->getAssignedProjectsTasks('overdue', $pagingModel, $owner);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('OWNER', $owner);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $pagingModel->set('limit', (int) $widget->get('limit'));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $widget = Vtiger_Widget_Model::getInstance($linkId, $currentUser->getId());

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('DATA', $data);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $pagingModel->set('page', $page);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('SOURCE_MODULE', 'ProjectTask');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('WIDGET', $widget);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('NODATAMSGLABLE', 'LBL_NO_OVERDUE_ACTIVITIES');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('USER_CONDITIONS', ['condition' => ['<', 'targetenddate', $currentDate]]);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $linkId = $request->getInteger('linkid');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $projectsTasks = (false === $owner) ? [] : $moduleModel->getAssignedProjectsTasks('overdue', $pagingModel, $owner);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ($request->has('content')) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $owner = $request->getByType('owner', 2);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $title_max_length = \App\Config::main('title_max_length');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $href_max_length = \App\Config::main('href_max_length');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('HREFNAMELENGTH', $href_max_length);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $viewer->view('dashboards/AssignedProjectsTasks.tpl', $moduleName);

• Exclude checks
  • Disable engine
  • Disable check

Class name "Vtiger_AssignedOverdueProjectsTasks_Dashboard" is not in camel caps format

Open

class Vtiger_AssignedOverdueProjectsTasks_Dashboard extends Vtiger_IndexAjax_View

• Exclude checks
  • Disable engine
  • Disable check

The variable $title_max_length is not named in camelCase.

Open

    public function process(App\Request $request)
    {
        $currentUser = Users_Record_Model::getCurrentUserModel();
        $viewer = $this->getViewer($request);
        $moduleName = $request->getModule();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $title_max_length is not named in camelCase.

Open

    public function process(App\Request $request)
    {
        $currentUser = Users_Record_Model::getCurrentUserModel();
        $viewer = $this->getViewer($request);
        $moduleName = $request->getModule();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $href_max_length is not named in camelCase.

Open

    public function process(App\Request $request)
    {
        $currentUser = Users_Record_Model::getCurrentUserModel();
        $viewer = $this->getViewer($request);
        $moduleName = $request->getModule();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $href_max_length is not named in camelCase.

Open

    public function process(App\Request $request)
    {
        $currentUser = Users_Record_Model::getCurrentUserModel();
        $viewer = $this->getViewer($request);
        $moduleName = $request->getModule();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}