YetiForceCompany/YetiForceCRM

View on GitHub
modules/Vtiger/dashboards/CreatedNotMineActivitiesModel.php

Summary

Maintainability
A
2 hrs
Test Coverage
F
0%

Method getFieldInstanceByName has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getFieldInstanceByName($name)
    {
        if (!isset($this->customFields[$name])) {
            return parent::getFieldInstanceByName($name);
        }
Severity: Minor
Found in modules/Vtiger/dashboards/CreatedNotMineActivitiesModel.php - About 1 hr to fix

    Function getFieldInstanceByName has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getFieldInstanceByName($name)
        {
            if (!isset($this->customFields[$name])) {
                return parent::getFieldInstanceByName($name);
            }
    Severity: Minor
    Found in modules/Vtiger/dashboards/CreatedNotMineActivitiesModel.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function setDataFromRequest has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function setDataFromRequest(App\Request $request)
        {
            parent::setDataFromRequest($request);
            foreach ($this->customFields as $fieldName => $fieldInfo) {
                if ($request->has($fieldName)) {
    Severity: Minor
    Found in modules/Vtiger/dashboards/CreatedNotMineActivitiesModel.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid using static access to class '\App\Json' in method 'setDataFromRequest'.
    Open

                    $owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Json' in method 'setDataFromRequest'.
    Open

                            $this->set('owners', \App\Json::encode($owners));

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Json' in method 'getFieldInstanceByName'.
    Open

                    $value = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Language' in method 'getFieldInstanceByName'.
    Open

                        $params['picklistValues'][$key] = \App\Language::translate($label, $moduleName);

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Vtiger_Field_Model' in method 'getFieldInstanceByName'.
    Open

            return \Vtiger_Field_Model::init($moduleName, $params, $name);

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Language' in method 'getFieldInstanceByName'.
    Open

                        $params['picklistValues'][$key] = \App\Language::translate($label, $moduleName);

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Json' in method 'getFieldInstanceByName'.
    Open

                    $owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Json' in method 'setDataFromRequest'.
    Open

                            $this->set('owners', \App\Json::encode($owners));

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Define a constant instead of duplicating this literal "default_owner" 3 times.
    Open

            'default_owner' => ['label' => 'LBL_DEFAULT_FILTER', 'purifyType' => \App\Purifier::STANDARD],

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
      prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
      execute('action1');
      release('action1');
    }
    

    Compliant Solution

    ACTION_1 = 'action1';
    
    function run() {
      prepare(ACTION_1);
      execute(ACTION_1);
      release(ACTION_1);
    }
    

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "owners" 8 times.
    Open

                    $value = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
      prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
      execute('action1');
      release('action1');
    }
    

    Compliant Solution

    ACTION_1 = 'action1';
    
    function run() {
      prepare(ACTION_1);
      execute(ACTION_1);
      release(ACTION_1);
    }
    

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "purifyType" 4 times.
    Open

            'default_owner' => ['label' => 'LBL_DEFAULT_FILTER', 'purifyType' => \App\Purifier::STANDARD],

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
      prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
      execute('action1');
      release('action1');
    }
    

    Compliant Solution

    ACTION_1 = 'action1';
    
    function run() {
      prepare(ACTION_1);
      execute(ACTION_1);
      release(ACTION_1);
    }
    

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "owners_all" 3 times.
    Open

            'owners_all' => ['label' => 'LBL_FILTERS_AVAILABLE', 'purifyType' => \App\Purifier::STANDARD]

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
      prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
      execute('action1');
      release('action1');
    }
    

    Compliant Solution

    ACTION_1 = 'action1';
    
    function run() {
      prepare(ACTION_1);
      execute(ACTION_1);
      release(ACTION_1);
    }
    

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "label" 5 times.
    Open

            'default_owner' => ['label' => 'LBL_DEFAULT_FILTER', 'purifyType' => \App\Purifier::STANDARD],

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
      prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
      execute('action1');
      release('action1');
    }
    

    Compliant Solution

    ACTION_1 = 'action1';
    
    function run() {
      prepare(ACTION_1);
      execute(ACTION_1);
      release(ACTION_1);
    }
    

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Reference to undeclared property \Vtiger_CreatedNotMineActivitiesModel_Dashboard->editFields
    Open

            return $this->editFields + $this->customFields + [

    Call to undeclared method \Vtiger_CreatedNotMineActivitiesModel_Dashboard::get
    Open

                    $value = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];

    Call to undeclared method \Vtiger_CreatedNotMineActivitiesModel_Dashboard::get
    Open

                    $owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];

    Call to undeclared method \Vtiger_CreatedNotMineActivitiesModel_Dashboard::set
    Open

                            $this->set('owners', \App\Json::encode($owners));

    Reference to undeclared class \Vtiger_Widget_Model
    Open

                return parent::getFieldInstanceByName($name);

    Reference to undeclared class \Vtiger_Widget_Model
    Open

            parent::setDataFromRequest($request);

    Call to undeclared method \Vtiger_CreatedNotMineActivitiesModel_Dashboard::set
    Open

                            $this->set('owners', \App\Json::encode($owners));

    Class extends undeclared class \Vtiger_Widget_Model
    Open

    class Vtiger_CreatedNotMineActivitiesModel_Dashboard extends Vtiger_Widget_Model

    Call to undeclared method \Vtiger_CreatedNotMineActivitiesModel_Dashboard::get
    Open

                    $owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];

    Avoid excessively long class names like Vtiger_CreatedNotMineActivitiesModel_Dashboard. Keep class name length under 40.
    Open

    class Vtiger_CreatedNotMineActivitiesModel_Dashboard extends Vtiger_Widget_Model
    {
        /** {@inheritdoc} */
        public $customFields = [
            'default_owner' => ['label' => 'LBL_DEFAULT_FILTER', 'purifyType' => \App\Purifier::STANDARD],

    LongClassName

    Since: 2.9

    Detects when classes or interfaces are declared with excessively long names.

    Example

    class ATooLongClassNameThatHintsAtADesignProblem {
    
    }
    
    interface ATooLongInterfaceNameThatHintsAtADesignProblem {
    
    }

    Source https://phpmd.org/rules/naming.html#longclassname

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class Vtiger_CreatedNotMineActivitiesModel_Dashboard extends Vtiger_Widget_Model

    The class Vtiger_CreatedNotMineActivitiesModel_Dashboard is not named in CamelCase.
    Open

    class Vtiger_CreatedNotMineActivitiesModel_Dashboard extends Vtiger_Widget_Model
    {
        /** {@inheritdoc} */
        public $customFields = [
            'default_owner' => ['label' => 'LBL_DEFAULT_FILTER', 'purifyType' => \App\Purifier::STANDARD],

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
    }

    Source

    Terminating statement must be on a line by itself
    Open

                        default: break;

    The DEFAULT body must start on the line following the statement
    Open

                default: break;

    Terminating statement must be on a line by itself
    Open

                default: break;

    The DEFAULT body must start on the line following the statement
    Open

                        default: break;

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ];

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getEditFields(): array

    Spaces must be used to indent lines; tabs are not allowed
    Open

                case 'default_owner':

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'limit' => ['label' => 'LBL_NUMBER_OF_RECORDS_DISPLAYED', 'purifyType' => \App\Purifier::INTEGER]

    Spaces must be used to indent lines; tabs are not allowed
    Open

                return parent::getFieldInstanceByName($name);

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $params['typeofdata'] = 'V~M';

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ];

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    foreach ($picklistValue as $key => $label) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $params['picklistValues'][$key] = \App\Language::translate($label, $moduleName);

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!isset($this->customFields[$name])) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

            switch ($name) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return $this->editFields + $this->customFields + [

    Spaces must be used to indent lines; tabs are not allowed
    Open

            'default_owner' => ['label' => 'LBL_DEFAULT_FILTER', 'purifyType' => \App\Purifier::STANDARD],

    Spaces must be used to indent lines; tabs are not allowed
    Open

        ];

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getFieldInstanceByName($name)

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'label' => $this->getEditFields()[$name]['label'],

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $picklistValue = ['all' => 'LBL_ALL'];

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $params['typeofdata'] = 'V~M';

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $value = $request->getByType($fieldName, $fieldInfo['purifyType']);

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $fieldModel = $this->getFieldInstanceByName($fieldName)->getUITypeModel();

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    switch ($fieldName) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */

    Spaces must be used to indent lines; tabs are not allowed
    Open

            foreach ($this->customFields as $fieldName => $fieldInfo) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $owners['default'] = $value;

    Spaces must be used to indent lines; tabs are not allowed
    Open

            'owners_all' => ['label' => 'LBL_FILTERS_AVAILABLE', 'purifyType' => \App\Purifier::STANDARD]

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $moduleName = 'Settings:WidgetsManagement';

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'tooltip' => $this->getEditFields()[$name]['tooltip'] ?? ''

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $value = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public $customFields = [

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $params['uitype'] = 16;

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'name' => $name,

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $params = [

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $params['fieldvalue'] = $value['default'] ?? 'all';

    Spaces must be used to indent lines; tabs are not allowed
    Open

                case 'owners_all':

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            break;

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    break;

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $params['picklistValues'][$key] = \App\Language::translate($label, $moduleName);

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function setDataFromRequest(App\Request $request)

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $value = $value ? explode(' |##| ', $value) : [];

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }

    Spaces must be used to indent lines; tabs are not allowed
    Open

            parent::setDataFromRequest($request);

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'all' => 'LBL_ALL',

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $owners['available'] = $value;

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'groups' => 'LBL_GROUPS'

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $value = $owners['available'] ?? ['all'];

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    break;

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if ($request->has($fieldName)) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $this->set('owners', \App\Json::encode($owners));

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'users' => 'LBL_USERS',

    Spaces must be used to indent lines; tabs are not allowed
    Open

                default: break;

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $value = $fieldModel->getDBValue($value);

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        case 'default_owner':

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        case 'owners_all':

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $picklistValue = [

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $params['fieldvalue'] = implode(' |##| ', $value);

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        default: break;

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $fieldModel->validate($value, true);

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    foreach ($picklistValue as $key => $label) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            break;

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $this->set('owners', \App\Json::encode($owners));

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $params['uitype'] = 33;

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    ];

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return \Vtiger_Field_Model::init($moduleName, $params, $name);

    Class name "Vtiger_CreatedNotMineActivitiesModel_Dashboard" is not in camel caps format
    Open

    class Vtiger_CreatedNotMineActivitiesModel_Dashboard extends Vtiger_Widget_Model

    Closing brace must be on a line by itself
    Open

                default: break;

    Closing brace must be on a line by itself
    Open

                        default: break;

    There are no issues that match your filters.

    Category
    Status