Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Vtiger/dashboards/History.php

Summary

Maintainability
A
1 hr
Test Coverage
F
0%

Method process has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function process(App\Request $request)
    {
        $viewer = $this->getViewer($request);
        $data = $request->getAll();
        $moduleName = $request->getModule();
Severity: Minor
Found in modules/Vtiger/dashboards/History.php - About 1 hr to fix

    Missing class import via use statement (line '30', column '22').
    Open

            $pagingModel = new Vtiger_Paging_Model();
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            $viewer->view('dashboards/History.tpl', $moduleName);
        }
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class 'Vtiger_Module_Model' in method 'process'.
    Open

            $moduleModel = Vtiger_Module_Model::getInstance($moduleName);
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Vtiger_Module_Model' in method 'process'.
    Open

            $modCommentsModel = Vtiger_Module_Model::getInstance('ModComments');
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Vtiger_Widget_Model' in method 'process'.
    Open

            $widget = Vtiger_Widget_Model::getInstance($linkId, \App\User::getCurrentUserId());
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\User' in method 'process'.
    Open

            $widget = Vtiger_Widget_Model::getInstance($linkId, \App\User::getCurrentUserId());
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('PAGE', $page);
    Severity: Critical
    Found in modules/Vtiger/dashboards/History.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('WIDGET', $widget);
    Severity: Critical
    Found in modules/Vtiger/dashboards/History.php by phan

    Call to method getInstance from undeclared class \Vtiger_Widget_Model
    Open

            $widget = Vtiger_Widget_Model::getInstance($linkId, \App\User::getCurrentUserId());
    Severity: Critical
    Found in modules/Vtiger/dashboards/History.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('DATA', $data);
    Severity: Critical
    Found in modules/Vtiger/dashboards/History.php by phan

    Call to method getCurrentUserId from undeclared class \App\User (Did you mean class \Tests\App\User)
    Open

            $widget = Vtiger_Widget_Model::getInstance($linkId, \App\User::getCurrentUserId());
    Severity: Critical
    Found in modules/Vtiger/dashboards/History.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('MODULE_NAME', $moduleName);
    Severity: Critical
    Found in modules/Vtiger/dashboards/History.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('HISTORIES', $history);
    Severity: Critical
    Found in modules/Vtiger/dashboards/History.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('NEXTPAGE', (\count($history) < $limit) ? 0 : $page + 1);
    Severity: Critical
    Found in modules/Vtiger/dashboards/History.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('COMMENTS_MODULE_MODEL', $modCommentsModel);
    Severity: Critical
    Found in modules/Vtiger/dashboards/History.php by phan

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class Vtiger_History_Dashboard extends Vtiger_IndexAjax_View
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    The class Vtiger_History_Dashboard is not named in CamelCase.
    Open

    class Vtiger_History_Dashboard extends Vtiger_IndexAjax_View
{
    public function process(App\Request $request)
    {
        $viewer = $this->getViewer($request);
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('COMMENTS_MODULE_MODEL', $modCommentsModel);
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $limit = (int) $widget->get('limit');
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('PAGE', $page);
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $page = 1;
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $modCommentsModel = Vtiger_Module_Model::getInstance('ModComments');
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('NEXTPAGE', (\count($history) < $limit) ? 0 : $page + 1);
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (empty($limit)) {
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            } else {
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $pagingModel = new Vtiger_Paging_Model();
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($request->has('content')) {
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $limit = 10;
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('DATA', $data);
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $viewer->view('dashboards/History.tpl', $moduleName);
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $type = $request->getByType('type');
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer = $this->getViewer($request);
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $pagingModel->set('limit', $limit);
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $data = $request->getAll();
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function process(App\Request $request)
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $moduleName = $request->getModule();
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $page = $request->getInteger('page');
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $widget = Vtiger_Widget_Model::getInstance($linkId, \App\User::getCurrentUserId());
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $linkId = $request->getInteger('linkid');
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (empty($page)) {
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $pagingModel->set('page', $page);
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('WIDGET', $widget);
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('HISTORIES', $history);
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $viewer->view('dashboards/HistoryContents.tpl', $moduleName);
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $moduleModel = Vtiger_Module_Model::getInstance($moduleName);
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $history = $moduleModel->getHistory($pagingModel, $type);
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('MODULE_NAME', $moduleName);
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    Class name "Vtiger_History_Dashboard" is not in camel caps format
    Open

    class Vtiger_History_Dashboard extends Vtiger_IndexAjax_View
    Severity: Minor
    Found in modules/Vtiger/dashboards/History.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status