Method getFieldInstanceByName has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getFieldInstanceByName($name)
{
if (!isset($this->customFields[$name])) {
return parent::getFieldInstanceByName($name);
}Function getValueForEditView has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function getValueForEditView(string $name)
{
$value = '';
switch ($name) {
case 'title':- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function setDataFromRequest has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function setDataFromRequest(App\Request $request)
{
parent::setDataFromRequest($request);
foreach ($this->customFields as $fieldName => $fieldInfo) {
if ($request->has($fieldName)) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method getValueForEditView() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open
public function getValueForEditView(string $name)
{
$value = '';
switch ($name) {
case 'title':- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Missing class import via use statement (line '24', column '25'). Open
$miniListModel = new Vtiger_MiniList_Model();- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class '\App\Json' in method 'isViewable'. Open
}- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Json' in method 'setDataFromRequest'. Open
$owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Layout' in method 'getSettingsLinks'. Open
'modalId' => \App\Layout::getUniqueId('MiniList')- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method getTitle uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$miniListModel = new Vtiger_MiniList_Model();
$miniListModel->setWidgetModel($this);
$title = $miniListModel->getTitle();
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\App\CustomView' in method 'isViewable'. Open
return $userPrivModel->hasModulePermission($moduleName) && \App\CustomView::isPermitted((int) $this->get('filterid'));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Language' in method 'getFieldInstanceByName'. Open
$params['picklistValues'][$key] = \App\Language::translate($label, $moduleName);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Link_Model' in method 'getSettingsLinks'. Open
$links[] = Vtiger_Link_Model::getInstanceFromValues([
'linklabel' => 'LBL_SHOW_COMPLETE_DETAILS',
'linkclass' => 'btn btn-default btn-xs js-show-modal',
'linkicon' => 'fas fa-th-list',
'linkdata' => [- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Vtiger_Field_Model' in method 'getFieldInstanceByName'. Open
return \Vtiger_Field_Model::init($moduleName, $params, $name);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Users_Privileges_Model' in method 'isViewable'. Open
$userPrivModel = Users_Privileges_Model::getCurrentUserPrivilegesModel();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Module' in method 'getSettingsLinks'. Open
'module' => \App\Module::getModuleName($this->get('tabid')),- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Users_Privileges_Model' in method 'isCreatable'. Open
$userPrivModel = Users_Privileges_Model::getCurrentUserPrivilegesModel();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Json' in method 'getFieldInstanceByName'. Open
$owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Json' in method 'setDataFromRequest'. Open
$this->set('owners', \App\Json::encode($owners));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Define a constant instead of duplicating this literal "title" 4 times. Open
$title = $this->get('title');- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "module" 4 times. Open
'module' => \App\Module::getModuleName($this->get('tabid')),- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "owners" 5 times. Open
$owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "tabid" 3 times. Open
'module' => \App\Module::getModuleName($this->get('tabid')),- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "label" 6 times. Open
'owners_all' => ['label' => 'LBL_FILTERS_AVAILABLE', 'purifyType' => \App\Purifier::STANDARD]- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "owners_all" 3 times. Open
'owners_all' => ['label' => 'LBL_FILTERS_AVAILABLE', 'purifyType' => \App\Purifier::STANDARD]- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "purifyType" 5 times. Open
'owners_all' => ['label' => 'LBL_FILTERS_AVAILABLE', 'purifyType' => \App\Purifier::STANDARD]- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Reference to undeclared property \Vtiger_MiniListModel_Dashboard->editFields Open
$this->editFields + $fields + $this->customFields +- Exclude checks
Call to undeclared method \Vtiger_MiniListModel_Dashboard::getId Open
if (empty($title) && !$this->getId()) {- Exclude checks
Reference to undeclared class \Vtiger_Widget_Model Open
return parent::isDeletable() && Users_Privileges_Model::getCurrentUserPrivilegesModel()->hasModuleActionPermission($this->get('tabid'), 'CreateDashboardFilter');- Exclude checks
Reference to undeclared class \Vtiger_Widget_Model Open
return parent::getFieldInstanceByName($name);- Exclude checks
Call to undeclared method \Vtiger_MiniListModel_Dashboard::getId Open
if ($this->getId() && \App\User::getCurrentUserModel()->isAdmin()) {- Exclude checks
Call to undeclared method \Vtiger_MiniListModel_Dashboard::get Open
return $userPrivModel->hasModulePermission($moduleName) && \App\CustomView::isPermitted((int) $this->get('filterid'));- Exclude checks
Call to undeclared method \Vtiger_MiniListModel_Dashboard::get Open
'module' => \App\Module::getModuleName($this->get('tabid')),- Exclude checks
Class extends undeclared class \Vtiger_Widget_Model Open
class Vtiger_MiniListModel_Dashboard extends Vtiger_Widget_Model- Exclude checks
Call to undeclared method \Vtiger_MiniListModel_Dashboard::get Open
$value = $this->get('title') ?: '';- Exclude checks
Call to undeclared method \Vtiger_MiniListModel_Dashboard::get Open
$value = $this->get($name) ?: 0;- Exclude checks
Call to undeclared method \Vtiger_MiniListModel_Dashboard::get Open
return $this->isViewable() && $userPrivModel->hasModuleActionPermission($this->get('module') ?: $this->get('tabid'), 'CreateDashboardFilter');- Exclude checks
Call to undeclared method \Vtiger_MiniListModel_Dashboard::get Open
$title = $this->get('title');- Exclude checks
Call to undeclared method \Vtiger_MiniListModel_Dashboard::get Open
'url' => "index.php?module=Home&view=MiniListWizard&step=step1&linkId={$this->get('linkid')}&templateId={$this->getId()}",- Exclude checks
Call to undeclared method \Vtiger_MiniListModel_Dashboard::getDataValue Open
$value = $this->getDataValue($name) ?: '';- Exclude checks
Call to undeclared method \Vtiger_MiniListModel_Dashboard::get Open
return parent::isDeletable() && Users_Privileges_Model::getCurrentUserPrivilegesModel()->hasModuleActionPermission($this->get('tabid'), 'CreateDashboardFilter');- Exclude checks
Call to undeclared method \Vtiger_MiniListModel_Dashboard::get Open
$moduleName = \App\Json::decode($this->get('data'))['module'];- Exclude checks
Call to undeclared method \Vtiger_MiniListModel_Dashboard::get Open
$owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];- Exclude checks
Call to undeclared method \Vtiger_MiniListModel_Dashboard::getDataValue Open
$value = $this->getDataValue($name) ?: [];- Exclude checks
Reference to undeclared class \Vtiger_Widget_Model Open
parent::setDataFromRequest($request);- Exclude checks
Call to undeclared method \Vtiger_MiniListModel_Dashboard::set Open
$this->set('owners', \App\Json::encode($owners));- Exclude checks
Reference to undeclared class \Vtiger_Widget_Model Open
return array_merge($links, parent::getSettingsLinks());- Exclude checks
Call to undeclared method \Vtiger_MiniListModel_Dashboard::get Open
$title = $this->get('linklabel');- Exclude checks
Call to undeclared method \Vtiger_MiniListModel_Dashboard::get Open
$owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];- Exclude checks
Call to undeclared method \Vtiger_MiniListModel_Dashboard::getId Open
'url' => "index.php?module=Home&view=MiniListWizard&step=step1&linkId={$this->get('linkid')}&templateId={$this->getId()}",- Exclude checks
Call to method getCurrentUserModel from undeclared class \App\User (Did you mean class \Tests\App\User) Open
if ($this->getId() && \App\User::getCurrentUserModel()->isAdmin()) {- Exclude checks
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function getSettingsLinks()
{
$links = [];
if ($this->getId() && \App\User::getCurrentUserModel()->isAdmin()) {
$links[] = Vtiger_Link_Model::getInstanceFromValues([- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 135.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
case 'owners_all':
$value = $value ? explode(' |##| ', $value) : [];
$owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];
$owners['available'] = $value;
$this->set('owners', \App\Json::encode($owners));- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 92.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Each class must be in a namespace of at least one level (a top-level vendor name) Open
class Vtiger_MiniListModel_Dashboard extends Vtiger_Widget_Model- Exclude checks
The class Vtiger_MiniListModel_Dashboard is not named in CamelCase. Open
class Vtiger_MiniListModel_Dashboard extends Vtiger_Widget_Model
{
/** {@inheritdoc} */
public function getTitle()
{- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
The DEFAULT body must start on the line following the statement Open
default: break;- Exclude checks
The DEFAULT body must start on the line following the statement Open
default: break;- Exclude checks
Terminating statement must be on a line by itself Open
default: break;- Exclude checks
Terminating statement must be on a line by itself Open
default: break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'roleUsers' => 'LBL_ROLE_USERS',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'url' => "index.php?module=Home&view=MiniListWizard&step=step1&linkId={$this->get('linkid')}&templateId={$this->getId()}",- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->editFields + $fields + $this->customFields +- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!isset($this->customFields[$name])) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'name' => $name,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'users' => 'LBL_USERS',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'rsUsers' => 'LBL_ROLE_AND_SUBORDINATES_USERS'- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($request->has($fieldName)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$links[] = Vtiger_Link_Model::getInstanceFromValues([- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'modalId' => \App\Layout::getUniqueId('MiniList')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return $title;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$value = $owners['available'] ?? [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
foreach ($this->customFields as $fieldName => $fieldInfo) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function isCreatable(): bool- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
case 'owners_all':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
foreach ($picklistValue as $key => $label) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
parent::setDataFromRequest($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
case 'filterFields':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function isDeletable(): bool- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getEditFields(): array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'label' => $this->getEditFields()[$name]['label'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$value = $fieldModel->getDBValue($value);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'linklabel' => 'LBL_SHOW_COMPLETE_DETAILS',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'linkicon' => 'fas fa-th-list',- Exclude checks
Line exceeds 120 characters; contains 142 characters Open
'url' => "index.php?module=Home&view=MiniListWizard&step=step1&linkId={$this->get('linkid')}&templateId={$this->getId()}",- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
case 'fieldHref':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$value = $this->getDataValue($name) ?: [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return $this->isViewable() && $userPrivModel->hasModuleActionPermission($this->get('module') ?: $this->get('tabid'), 'CreateDashboardFilter');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (empty($title) && !$this->getId()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return ['title' => ['label' => 'LBL_WIDGET_NAME', 'purifyType' => \App\Purifier::TEXT]] +- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'all' => 'LBL_ALL',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return \Vtiger_Field_Model::init($moduleName, $params, $name);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$fieldModel = $this->getFieldInstanceByName($fieldName)->getUITypeModel();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getSettingsLinks()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'linkclass' => 'btn btn-default btn-xs js-show-modal',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'owners_all' => ['label' => 'LBL_FILTERS_AVAILABLE', 'purifyType' => \App\Purifier::STANDARD]- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
switch ($name) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$picklistValue = [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* Get value by field for edit view.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$userPrivModel = Users_Privileges_Model::getCurrentUserPrivilegesModel();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'mine' => 'LBL_MINE',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function setDataFromRequest(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'linkdata' => [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @param string $name- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$userPrivModel = Users_Privileges_Model::getCurrentUserPrivilegesModel();- Exclude checks
Line exceeds 120 characters; contains 150 characters Open
return $this->isViewable() && $userPrivModel->hasModuleActionPermission($this->get('module') ?: $this->get('tabid'), 'CreateDashboardFilter');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$title = $this->get('title');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$miniListModel->setWidgetModel($this);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$fields = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$params['typeofdata'] = 'V~M';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
default: break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return parent::isDeletable() && Users_Privileges_Model::getCurrentUserPrivilegesModel()->hasModuleActionPermission($this->get('tabid'), 'CreateDashboardFilter');- Exclude checks
Line exceeds 120 characters; contains 169 characters Open
return parent::isDeletable() && Users_Privileges_Model::getCurrentUserPrivilegesModel()->hasModuleActionPermission($this->get('tabid'), 'CreateDashboardFilter');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return $userPrivModel->hasModulePermission($moduleName) && \App\CustomView::isPermitted((int) $this->get('filterid'));- Exclude checks
Line exceeds 120 characters; contains 126 characters Open
return $userPrivModel->hasModulePermission($moduleName) && \App\CustomView::isPermitted((int) $this->get('filterid'));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
['limit' => ['label' => 'LBL_NUMBER_OF_RECORDS_DISPLAYED', 'purifyType' => App\Purifier::INTEGER]];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$moduleName = \App\Json::decode($this->get('data'))['module'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getTitle()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$params['uitype'] = 33;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($this->getId() && \App\User::getCurrentUserModel()->isAdmin()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
case 'title':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
case 'fields':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$moduleName = 'Settings:WidgetsManagement';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$value = $value ? explode(' |##| ', $value) : [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$value = '';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$title = $this->get('linklabel');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public $customFields = [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$fields['default_owner'] = ['label' => 'LBL_DEFAULT_FILTER', 'purifyType' => \App\Purifier::STANDARD];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return parent::getFieldInstanceByName($name);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$value = $request->getByType($fieldName, $fieldInfo['purifyType']);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
case 'filterid':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$title = $miniListModel->getTitle();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getFieldInstanceByName($name)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'groups' => 'LBL_GROUPS',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$params['picklistValues'][$key] = \App\Language::translate($label, $moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
case 'owners_all':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$owners['available'] = $value;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->set('owners', \App\Json::encode($owners));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$links = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$value = $this->getDataValue($name) ?: '';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return $value;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function isViewable(): bool- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$miniListModel = new Vtiger_MiniList_Model();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$params = [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'tooltip' => $this->getEditFields()[$name]['tooltip'] ?? ''- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$params['fieldvalue'] = implode(' |##| ', $value);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
default: break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return array_merge($links, parent::getSettingsLinks());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
switch ($name) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'groupUsers' => 'LBL_GROUP_USERS',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$fieldModel->validate($value, true);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
switch ($fieldName) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'module' => \App\Module::getModuleName($this->get('tabid')),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
case 'module':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$value = $this->get($name) ?: 0;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
default:- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
]- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getValueForEditView(string $name)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$value = $this->get('title') ?: '';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
break;- Exclude checks
Closing brace must be on a line by itself Open
default: break;- Exclude checks
Class name "Vtiger_MiniListModel_Dashboard" is not in camel caps format Open
class Vtiger_MiniListModel_Dashboard extends Vtiger_Widget_Model- Exclude checks
Closing brace must be on a line by itself Open
default: break;- Exclude checks