Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Vtiger/handlers/Meetings.php

Summary

Maintainability
A
2 hrs
Test Coverage
F
22%

Function entityBeforeSave has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function entityBeforeSave(App\EventHandler $eventHandler)
    {
        $recordModel = $eventHandler->getRecordModel();
        $meeting = \App\MeetingService::getInstance();
        if ($meeting->isActive()) {
Severity: Minor
Found in modules/Vtiger/handlers/Meetings.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

                if (($url = $recordModel->get($fieldName)) &&
                    0 === strpos($url, $meeting->get('url')) &&
                    ($expFieldName = $fieldModel->getFieldParams()['exp'] ?? '') &&
                    $recordModel->getField($expFieldName) &&
                    ($recordModel->isNew() || false !== $recordModel->getPreviousValue($expFieldName))
Severity: Major
Found in modules/Vtiger/handlers/Meetings.php - About 40 mins to fix

    The method entityBeforeSave() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
    Open

        public function entityBeforeSave(App\EventHandler $eventHandler)
    {
        $recordModel = $eventHandler->getRecordModel();
        $meeting = \App\MeetingService::getInstance();
        if ($meeting->isActive()) {
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Avoid assigning values to variables in if clauses and the like (line '28', column '10').
    Open

        public function entityBeforeSave(App\EventHandler $eventHandler)
    {
        $recordModel = $eventHandler->getRecordModel();
        $meeting = \App\MeetingService::getInstance();
        if ($meeting->isActive()) {
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    The method entityBeforeSave uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                        } else {
                        $expDate = date('Y-m-d') . ' 23:59:59';
                    }
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid assigning values to variables in if clauses and the like (line '30', column '7').
    Open

        public function entityBeforeSave(App\EventHandler $eventHandler)
    {
        $recordModel = $eventHandler->getRecordModel();
        $meeting = \App\MeetingService::getInstance();
        if ($meeting->isActive()) {
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid using static access to class '\App\MeetingService' in method 'entityBeforeSave'.
    Open

            $meeting = \App\MeetingService::getInstance();
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class Vtiger_Meetings_Handler
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    The class Vtiger_Meetings_Handler is not named in CamelCase.
    Open

    class Vtiger_Meetings_Handler
{
    /**
     * EntityBeforeSave function.
     *
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $url = $meeting->getUrl(['room' => $room, 'exp' => strtotime($expDate)]);
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $room = $meeting->getRoomFromUrl($url);
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        ($expFieldName = $fieldModel->getFieldParams()['exp'] ?? '') &&
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $recordModel->getField($expFieldName) &&
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $expDate = $recordModel->get($expFieldName);
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $expDate = date('Y-m-d', strtotime($expDate)) . ' 23:59:59';
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        if ($expDate) {
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        } else {
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        }
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $recordModel->setDataForSave([$fieldModel->getTableName() => [$fieldModel->getColumnName() => $url]]);
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Line exceeds 120 characters; contains 122 characters
    Open

                        $recordModel->setDataForSave([$fieldModel->getTableName() => [$fieldModel->getColumnName() => $url]]);
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * EntityBeforeSave function.
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        0 === strpos($url, $meeting->get('url')) &&
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        ($recordModel->isNew() || false !== $recordModel->getPreviousValue($expFieldName))
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    ) {
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $expDate = date('Y-m-d') . ' 23:59:59';
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $recordModel->set($fieldModel->getName(), $url);
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($meeting->isActive()) {
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                foreach ($recordModel->getModule()->getFieldsByType(['meetingUrl'], true) as $fieldName => $fieldModel) {
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $recordModel = $eventHandler->getRecordModel();
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $meeting = \App\MeetingService::getInstance();
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param App\EventHandler $eventHandler
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function entityBeforeSave(App\EventHandler $eventHandler)
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if (($url = $recordModel->get($fieldName)) &&
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    Class name "Vtiger_Meetings_Handler" is not in camel caps format
    Open

    class Vtiger_Meetings_Handler
    Severity: Minor
    Found in modules/Vtiger/handlers/Meetings.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status