Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Vtiger/inventoryfields/Name.php

Summary

Maintainability
A
1 hr
Test Coverage
F
45%

Function validate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function validate($value, string $columnName, bool $isUserFormat, $originalValue = null)
    {
        if ((empty($value) && $this->isMandatory()) || ($value && !is_numeric($value))) {
            throw new \App\Exceptions\Security("ERR_ILLEGAL_FIELD_VALUE||$columnName||$value", 406);
        }
Severity: Minor
Found in modules/Vtiger/inventoryfields/Name.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return "<span class=\"yfm-{$referenceModuleName} mr-1\"></span>" . \App\Record::getHtmlLink($value, $referenceModuleName, \App\Config::main('href_max_length'));
Severity: Major
Found in modules/Vtiger/inventoryfields/Name.php - About 30 mins to fix

    Function getReferenceModule has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getReferenceModule($record): ?Vtiger_Module_Model
    {
        if (!empty($record)) {
            $referenceModuleList = $this->getParamsConfig()['modules'] ?? [];
            $referenceModuleList = !\is_array($referenceModuleList) ? [$referenceModuleList] : $referenceModuleList;
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Reduce the number of returns of this function 5, down to the maximum allowed 3.
    Open

        public function getDisplayValue($value, array $rowData = [], bool $rawText = false)
    Severity: Major
    Found in modules/Vtiger/inventoryfields/Name.php by sonar-php

    Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.

    Noncompliant Code Example

    With the default threshold of 3:

    function myFunction(){ // Noncompliant as there are 4 return statements
  if (condition1) {
    return true;
  } else {
    if (condition2) {
      return false;
    } else {
      return true;
    }
  }
  return false;
}

    Missing class import via use statement (line '123', column '14').
    Open

                throw new \App\Exceptions\AppException("ERR_RECORD_NOT_FOUND||$value||$columnName", 406);
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '127', column '14').
    Open

                throw new \App\Exceptions\AppException("ERR_VALUE_IS_TOO_LONG||$columnName||$value", 406);
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '120', column '14').
    Open

                throw new \App\Exceptions\Security("ERR_ILLEGAL_FIELD_VALUE||$columnName||$value", 406);
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The method getDisplayValue has a boolean flag argument $rawText, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function getDisplayValue($value, array $rowData = [], bool $rawText = false)
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    Avoid using static access to class '\App\Fields\Owner' in method 'getDisplayValue'.
    Open

                return \App\Fields\Owner::getLabel($value);
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Purifier' in method 'getDisplayValue'.
    Open

                return '<i class="color-red-500" title="' . \App\Purifier::encodeHtml($value) . '">' . \App\Language::translate('LBL_RECORD_DOES_NOT_EXIST', 'ModTracker') . '</i>';
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Config' in method 'getUrlForMassSelection'.
    Open

            if (\App\Config::module($moduleName, 'inventoryMassAddEntriesTreeView') && ($field = current(Vtiger_Module_Model::getInstance($moduleName)->getFieldsByType('tree', true))) && $field->isViewable()) {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Record' in method 'validate'.
    Open

            if (!\App\Record::isExists($value)) {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Vtiger_Module_Model' in method 'getReferenceModule'.
    Open

                    return Vtiger_Module_Model::getInstance($referenceEntityType);
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Language' in method 'getDisplayValue'.
    Open

                return '<i class="color-red-500" title="' . \App\Purifier::encodeHtml($value) . '">' . \App\Language::translate('LBL_RECORD_DOES_NOT_EXIST', 'ModTracker') . '</i>';
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Record' in method 'getDisplayValue'.
    Open

                return \App\Record::getLabel($value, $rawText);
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Record' in method 'getDisplayValue'.
    Open

            return "<span class=\"yfm-{$referenceModuleName} mr-1\"></span>" . \App\Record::getHtmlLink($value, $referenceModuleName, \App\Config::main('href_max_length'));
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Config' in method 'getDisplayValue'.
    Open

            return "<span class=\"yfm-{$referenceModuleName} mr-1\"></span>" . \App\Record::getHtmlLink($value, $referenceModuleName, \App\Config::main('href_max_length'));
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid assigning values to variables in if clauses and the like (line '36', column '9').
    Open

        public function getDisplayValue($value, array $rowData = [], bool $rawText = false)
    {
        if (empty($value)) {
            return '';
        }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid using static access to class '\App\Record' in method 'getEditValue'.
    Open

            return \App\Record::getLabel($value);
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'vtlib\Functions' in method 'getReferenceModule'.
    Open

    }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Vtiger_Module_Model' in method 'getReferenceModule'.
    Open

                    return Vtiger_Module_Model::getInstance('Users');
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid assigning values to variables in if clauses and the like (line '148', column '79').
    Open

        public function getUrlForMassSelection(string $moduleName): string
    {
        $view = 'RecordsList';
        if (\App\Config::module($moduleName, 'inventoryMassAddEntriesTreeView') && ($field = current(Vtiger_Module_Model::getInstance($moduleName)->getFieldsByType('tree', true))) && $field->isViewable()) {
            $view = 'TreeInventoryModal';
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Define a constant instead of duplicating this literal "Users" 3 times.
    Open

            if ('Users' === $referenceModuleName || 'Groups' === $referenceModuleName) {
    Severity: Critical
    Found in modules/Vtiger/inventoryfields/Name.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "mandatory" 3 times.
    Open

        protected $params = ['modules', 'limit', 'mandatory'];
    Severity: Critical
    Found in modules/Vtiger/inventoryfields/Name.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Argument 2 (moduleName) is false but \App\Record::getHtmlLink() takes null|string defined at /code/app/Record.php:394
    Open

            return "<span class=\"yfm-{$referenceModuleName} mr-1\"></span>" . \App\Record::getHtmlLink($value, $referenceModuleName, \App\Config::main('href_max_length'));
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phan

    Call to method getLabel from undeclared class \App\Fields\Owner
    Open

                return \App\Fields\Owner::getLabel($value);
    Severity: Critical
    Found in modules/Vtiger/inventoryfields/Name.php by phan

    Suspicious type false of a variable or expression used to build a string. (Expected type to be able to cast to a string)
    Open

            return "<span class=\"yfm-{$referenceModuleName} mr-1\"></span>" . \App\Record::getHtmlLink($value, $referenceModuleName, \App\Config::main('href_max_length'));
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phan

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class Vtiger_Name_InventoryField extends Vtiger_Basic_InventoryField
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    The class Vtiger_Name_InventoryField is not named in CamelCase.
    Open

    class Vtiger_Name_InventoryField extends Vtiger_Basic_InventoryField
{
    protected $type = 'Name';
    protected $defaultLabel = 'LBL_ITEM_NAME';
    protected $columnName = 'name';
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return 'inventoryTypes/Name.tpl';
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                return \App\Fields\Owner::getLabel($value);
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return null;
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ['id' => 'false', 'name' => 'LBL_NO'],
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return (int) $value;
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function isRequired()
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        protected $columnName = 'name';
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return "<span class=\"yfm-{$referenceModuleName} mr-1\"></span>" . \App\Record::getHtmlLink($value, $referenceModuleName, \App\Config::main('href_max_length'));
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getEditValue($value)
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (empty($value)) {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                return '<i class="color-red-500" title="' . \App\Purifier::encodeHtml($value) . '">' . \App\Language::translate('LBL_RECORD_DOES_NOT_EXIST', 'ModTracker') . '</i>';
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $referenceModuleName = $referenceModule->getName();
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Function to get the Display Value, for the current field type with given DB Insert Value.
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Getting value to display.
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $referenceModuleList = !\is_array($referenceModuleList) ? [$referenceModuleList] : $referenceModuleList;
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ['id' => 'true', 'name' => 'LBL_YES'],
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return true;
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return "index.php?module={$moduleName}&view={$view}&src_module={$this->getModuleName()}&multi_select=true";
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        protected $type = 'Name';
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        protected $maximumLength = '-2147483648,2147483647';
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        protected $purifyType = \App\Purifier::INTEGER;
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $referenceEntityType = vtlib\Functions::getCRMRecordMetadata($record)['setype'] ?? '';
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $config = $this->getParamsConfig();
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getDBValue($value, ?string $name = '')
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                throw new \App\Exceptions\AppException("ERR_VALUE_IS_TOO_LONG||$columnName||$value", 406);
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Gets URL for mass selection.
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getUrlForMassSelection(string $moduleName): string
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Line exceeds 120 characters; contains 168 characters
    Open

            return "<span class=\"yfm-{$referenceModuleName} mr-1\"></span>" . \App\Record::getHtmlLink($value, $referenceModuleName, \App\Config::main('href_max_length'));
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $rangeValues = explode(',', $this->maximumLength);
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $view = 'RecordsList';
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        protected $colSpan = 30;
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getEditTemplateName()
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param mixed $record
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function limitValues()
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ];
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return [
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Line exceeds 120 characters; contains 206 characters
    Open

            if (\App\Config::module($moduleName, 'inventoryMassAddEntriesTreeView') && ($field = current(Vtiger_Module_Model::getInstance($moduleName)->getFieldsByType('tree', true))) && $field->isViewable()) {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $view = 'TreeInventoryModal';
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        protected $params = ['modules', 'limit', 'mandatory'];
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if (!empty($referenceModuleList) && \in_array('Users', $referenceModuleList)) {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return \App\Record::getLabel($value);
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    return Vtiger_Module_Model::getInstance('Users');
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if (!empty($referenceModuleList) && \in_array($referenceEntityType, $referenceModuleList)) {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ];
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function validate($value, string $columnName, bool $isUserFormat, $originalValue = null)
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        protected $dbType = 'int DEFAULT 0';
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $referenceModuleList = $this->getParamsConfig()['modules'] ?? [];
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    return Vtiger_Module_Model::getInstance($referenceEntityType);
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return array
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function mandatoryValues()
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!\App\Record::isExists($value)) {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                throw new \App\Exceptions\AppException("ERR_RECORD_NOT_FOUND||$value||$columnName", 406);
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (\App\Config::module($moduleName, 'inventoryMassAddEntriesTreeView') && ($field = current(Vtiger_Module_Model::getInstance($moduleName)->getFieldsByType('tree', true))) && $field->isViewable()) {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Line exceeds 120 characters; contains 176 characters
    Open

                return '<i class="color-red-500" title="' . \App\Purifier::encodeHtml($value) . '">' . \App\Language::translate('LBL_RECORD_DOES_NOT_EXIST', 'ModTracker') . '</i>';
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ('Users' === $referenceModuleName || 'Groups' === $referenceModuleName) {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($rawText) {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getReferenceModule($record): ?Vtiger_Module_Model
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return isset($config['mandatory']) ? 'false' !== $config['mandatory'] : true;
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!($referenceModule = $this->getReferenceModule($value))) {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                return \App\Record::getLabel($value, $rawText);
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty($record)) {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Getting value to display.
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ((empty($value) && $this->isMandatory()) || ($value && !is_numeric($value))) {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        protected $defaultLabel = 'LBL_ITEM_NAME';
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                return '';
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return Vtiger_Module_Model|null
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ['id' => 0, 'name' => 'LBL_NO'],
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ['id' => 1, 'name' => 'LBL_YES'],
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return array
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                throw new \App\Exceptions\Security("ERR_ILLEGAL_FIELD_VALUE||$columnName||$value", 406);
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param string $moduleName
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getDisplayValue($value, array $rowData = [], bool $rawText = false)
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return [
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function isMandatory()
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($value && ($rangeValues[1] < $value || $rangeValues[0] > $value)) {
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return string
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    Class name "Vtiger_Name_InventoryField" is not in camel caps format
    Open

    class Vtiger_Name_InventoryField extends Vtiger_Basic_InventoryField
    Severity: Minor
    Found in modules/Vtiger/inventoryfields/Name.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status