modules/Vtiger/models/EditView.php
Avoid using static access to class 'Vtiger_Link_Model' in method 'getEditViewLinks'. Open
Open
return Vtiger_Link_Model::getAllByType($this->getModule()->getId(), ['EDIT_VIEW_HEADER', 'EDIT_VIEW_RECORD_COLLECTOR'], $linkParams);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Loader' in method 'getInstance'. Open
Open
$modelClassName = Vtiger_Loader::getComponentClassName('Model', 'EditView', $moduleName);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Module_Model' in method 'getInstance'. Open
Open
$moduleModel = Vtiger_Module_Model::getInstance($moduleName);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid unused parameters such as '$recordId'. Open
Open
public static function getInstance($moduleName, $recordId)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Saw unextractable annotation for comment '* @return <array> - Associate array of Link Type to List of Vtiger_Link_Model instances'</array> Open
Open
* @return <Array> - Associate array of Link Type to List of Vtiger_Link_Model instances- Exclude checks
Saw unextractable annotation for comment '* @param <array> $linkParams'</array> Open
Open
* @param <Array> $linkParams- Exclude checks
Saw unextractable annotation for comment '* @return <vtiger_detailview_model>'</vtiger_detailview_model> Open
Open
* @return <Vtiger_DetailView_Model>- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Vtiger_EditView_Model extends \App\Base- Exclude checks
The class Vtiger_EditView_Model is not named in CamelCase. Open
Open
class Vtiger_EditView_Model extends \App\Base
{
/**
* Function to get the instance.
*- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return <Vtiger_DetailView_Model>- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $recordId - record id- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $moduleName - module name- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the instance.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $instance->set('module', $moduleModel);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getModule()- Exclude checks
Line exceeds 120 characters; contains 141 characters Open
Open
return Vtiger_Link_Model::getAllByType($this->getModule()->getId(), ['EDIT_VIEW_HEADER', 'EDIT_VIEW_RECORD_COLLECTOR'], $linkParams);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getEditViewLinks($linkParams)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return Vtiger_Link_Model::getAllByType($this->getModule()->getId(), ['EDIT_VIEW_HEADER', 'EDIT_VIEW_RECORD_COLLECTOR'], $linkParams);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return Vtiger_Module_Model instance- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the list of listview links for the module.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public static function getInstance($moduleName, $recordId)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleModel = Vtiger_Module_Model::getInstance($moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$instance = new $modelClassName();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->get('module');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$modelClassName = Vtiger_Loader::getComponentClassName('Model', 'EditView', $moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the Module Model.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return <Array> - Associate array of Link Type to List of Vtiger_Link_Model instances- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param <Array> $linkParams- Exclude checks
Class name "Vtiger_EditView_Model" is not in camel caps format Open
Open
class Vtiger_EditView_Model extends \App\Base- Exclude checks