YetiForceCompany/YetiForceCRM

Method getTreeList has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function getTreeList()
    {
        $trees = [];
        $lastId = 0;
        $dataReader = (new App\Db\Query())

Missing class import via use statement (line '59', column '22').

Open

        $dataReader = (new App\Db\Query())

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid using static access to class 'Vtiger_Loader' in method 'getInstance'.

Open

        $modelClassName = Vtiger_Loader::getComponentClassName('Model', 'TreeInventoryModal', $moduleName);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'Vtiger_ListView_Model' in method 'getRecords'.

Open

        $listViewModel = Vtiger_ListView_Model::getInstanceForPopup($this->getModuleName(), $this->get('srcModule'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Language' in method 'getTreeList'.

Open

                'text' => \App\Language::translate($row['name'], $this->getModuleName()),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Define a constant instead of duplicating this literal "category" 3 times.

Open

                'type' => 'category',

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "parent" 5 times.

Open

                'parent' => 0 === $parent ? '#' : $parent,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Reference to undeclared property \Vtiger_TreeInventoryModal_Model->lastTreeId

Open

        $this->lastTreeId = $lastId;

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

        $dataReader = (new App\Db\Query())

• Exclude checks
  • Disable engine
  • Disable check

Call to method setFields from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)

Open

        $listViewModel->getQueryGenerator()->setFields(['id', $this->getTreeField()['fieldname']]);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Vtiger_TreeInventoryModal_Model->lastTreeId

Open

                'id' => $this->lastTreeId,

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Vtiger_TreeInventoryModal_Model->lastTreeId

Open

            ++$this->lastTreeId;

• Exclude checks
  • Disable engine
  • Disable check

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class Vtiger_TreeInventoryModal_Model extends Vtiger_TreeCategoryModal_Model

• Exclude checks
  • Disable engine
  • Disable check

The class Vtiger_TreeInventoryModal_Model is not named in CamelCase.

Open

class Vtiger_TreeInventoryModal_Model extends Vtiger_TreeCategoryModal_Model
{
    /**
     * @var bool Auto register events
     */

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class class_name {
}

Spaces must be used to indent lines; tabs are not allowed

Open

     * @return array

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'record_id' => $item->getId(),

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'category' => ['checked' => false]

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return $tree;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ++$this->lastTreeId;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'text' => \App\Language::translate($row['name'], $this->getModuleName()),

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $modelClassName = Vtiger_Loader::getComponentClassName('Model', 'TreeInventoryModal', $moduleName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        foreach ($listViewModel->getAllEntries() as $item) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $parent = (int) ltrim($item->get($this->getTreeField()['fieldname']), 'T');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            end($pieces);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $parent = (int) ltrim(prev($pieces), 'T');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->lastTreeId = $lastId;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $tree[] = [

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'type' => 'category',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @return array

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    private function getTreeList()

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $tree = [

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if ($treeID > $lastId) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Retrieves all records and categories.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @return array

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $treeID = (int) ltrim($row['tree'], 'T');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return $trees;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $trees = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'record_id' => $row['tree'],

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $instance->set('module', $moduleModel)->set('moduleName', $moduleName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'text' => $item->getName(),

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $treeList = $this->getTreeList();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'attr' => 'record',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $pieces = explode('::', $row['parentTree']);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var bool Auto register events

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $autoRegisterEvents = false;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Creates a tree for records.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $listViewModel->getQueryGenerator()->setFields(['id', $this->getTreeField()['fieldname']]);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'parent' => 0 === $parent ? '#' : $parent,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $lastId = 0;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        while ($row = $dataReader->read()) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return $instance;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $treeData = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $tree = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'id' => $treeID,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $lastId = $treeID;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static function getInstance(Vtiger_Module_Model $moduleModel)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function getTreeData()

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    private function getRecords()

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'id' => $this->lastTreeId,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ->from('vtiger_trees_templates_data')

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $trees[$treeID] = $tree;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            while (isset($treeList[$tree['parent']]) && !\in_array($treeList[$tree['parent']], $treeData)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'state' => ['disabled' => true]

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if (!empty($row['icon'])) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $treeData[] = $tree;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $tree = $treeList[$tree['parent']];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'parent' => 0 === $parent ? '#' : $parent,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'icon' => "js-detail__icon yfm-{$this->getModuleName()}",

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Creates a tree for category.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $dataReader = (new App\Db\Query())

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ->createCommand()->query();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $tree['icon'] = $row['icon'];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $moduleName = $moduleModel->get('name');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $instance = new $modelClassName();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $listViewModel = Vtiger_ListView_Model::getInstanceForPopup($this->getModuleName(), $this->get('srcModule'));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ->where(['templateid' => $this->getTemplate()])

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'type' => 'category',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /** {@inheritdoc} */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return array_merge($treeData, $records);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $records = $this->getRecords();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        foreach ($records as $tree) {

• Exclude checks
  • Disable engine
  • Disable check

Class name "Vtiger_TreeInventoryModal_Model" is not in camel caps format

Open

class Vtiger_TreeInventoryModal_Model extends Vtiger_TreeCategoryModal_Model

• Exclude checks
  • Disable engine
  • Disable check