modules/Vtiger/models/Utility.php
Missing class import via use statement (line '28', column '15'). Open
Open
return (new App\Db\Query())->from('vtiger_profile2utility')- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Call to undeclared method \App\Db\Query::from Open
Open
return (new App\Db\Query())->from('vtiger_profile2utility')- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Vtiger_Utility_Model extends Vtiger_Action_Model- Exclude checks
The class Vtiger_Utility_Model is not named in CamelCase. Open
Open
class Vtiger_Utility_Model extends Vtiger_Action_Model
{
public function isUtilityTool()
{
return true;- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function isUtilityTool()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return true;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->where(['tabid' => $tabId, 'activityid' => $this->getId()])- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function isModuleEnabled($module)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$tabId = $module->getId();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!$module->isEntityModule() && !$module->isUtilityActionEnabled()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return (new App\Db\Query())->from('vtiger_profile2utility')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->exists();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Class name "Vtiger_Utility_Model" is not in camel caps format Open
Open
class Vtiger_Utility_Model extends Vtiger_Action_Model- Exclude checks