YetiForceCompany/YetiForceCRM

Method process has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function process(App\Request $request)
    {
        $moduleName = $request->getModule();
        $viewId = $entityState = false;
        $selectedIds = $request->getArray('selected_ids', 2);

Missing class import via use statement (line '25', column '14').

Open

            throw new \App\Exceptions\NoPermitted('LBL_PERMISSION_DENIED', 406);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid using static access to class '\App\Condition' in method 'process'.

Open

        $viewer->assign('ALPHABET_VALUE', \App\Condition::validSearchValue($request->getByType('search_value', 'Text'), $moduleName, $request->getByType('search_key', 'Alnum'), $request->getByType('operator')));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'Users_Privileges_Model' in method 'checkPermission'.

Open

        $userPrivilegesModel = Users_Privileges_Model::getCurrentUserPrivilegesModel();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'Import_Module_Model' in method 'process'.

Open

        $viewer->assign('XML_TPL_LIST', Import_Module_Model::getListTplForXmlType($moduleName));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Condition' in method 'process'.

Open

        $viewer->assign('SEARCH_PARAMS', \App\Condition::validSearchParams($moduleName, $request->getArray('search_params'), false));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Export\Records' in method 'process'.

Open

        $viewer->assign('EXPORT_TYPE', \App\Export\Records::getSupportedFileFormats($moduleName));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Condition' in method 'process'.

Open

            \App\Condition::validAdvancedConditions($advancedConditions);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('ALPHABET_VALUE', \App\Condition::validSearchValue($request->getByType('search_value', 'Text'), $moduleName, $request->getByType('search_key', 'Alnum'), $request->getByType('operator')));

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('PAGE', $page);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('SEARCH_KEY', $request->getByType('search_key', 'Alnum'));

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('MODULE', 'Export');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('EXCLUDED_IDS', $excludedIds);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('ENTITY_STATE', $entityState);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('VIEWID', $viewId);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('EXPORT_TYPE', \App\Export\Records::getSupportedFileFormats($moduleName));

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('OPERATOR', $request->getByType('operator'));

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('SELECTED_IDS', $selectedIds);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('MODULE_NAME', $moduleName);

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (moduleName) is string but \Import_Module_Model::getListTplForXmlType() takes \type defined at /code/modules/Import/models/Module.php:140

Open

        $viewer->assign('XML_TPL_LIST', Import_Module_Model::getListTplForXmlType($moduleName));

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('XML_TPL_LIST', Import_Module_Model::getListTplForXmlType($moduleName));

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('SEARCH_PARAMS', \App\Condition::validSearchParams($moduleName, $request->getArray('search_params'), false));

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Vtiger_Viewer::assign

Open

        $viewer->assign('ADVANCED_CONDITIONS', $advancedConditions);

• Exclude checks
  • Disable engine
  • Disable check

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class Vtiger_Export_View extends Vtiger_Index_View

• Exclude checks
  • Disable engine
  • Disable check

The class Vtiger_Export_View is not named in CamelCase.

Open

class Vtiger_Export_View extends Vtiger_Index_View
{
    /**
     * Function to check permission.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class class_name {
}

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewId = $entityState = false;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ($advancedConditions) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $userPrivilegesModel = Users_Privileges_Model::getCurrentUserPrivilegesModel();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /** {@inheritdoc} */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $selectedIds = $request->getArray('selected_ids', 2);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $advancedConditions = $request->has('advancedConditions') ? $request->getArray('advancedConditions') : [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param \App\Request $request

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer = $this->getViewer($request);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('EXCLUDED_IDS', $excludedIds);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('VIEWID', $viewId);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('OPERATOR', $request->getByType('operator'));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Function to check permission.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function checkPermission(App\Request $request)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $page = $request->getInteger('page');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('XML_TPL_LIST', Import_Module_Model::getListTplForXmlType($moduleName));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            \App\Condition::validAdvancedConditions($advancedConditions);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $viewId = $request->getByType('viewname', 2);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->view('Export.tpl', $moduleName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('MODULE', 'Export');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('ALPHABET_VALUE', \App\Condition::validSearchValue($request->getByType('search_value', 'Text'), $moduleName, $request->getByType('search_key', 'Alnum'), $request->getByType('operator')));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('PAGE', $page);

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 211 characters

Open

        $viewer->assign('ALPHABET_VALUE', \App\Condition::validSearchValue($request->getByType('search_value', 'Text'), $moduleName, $request->getByType('search_key', 'Alnum'), $request->getByType('operator')));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!$userPrivilegesModel->hasModuleActionPermission($request->getModule(), 'Export')) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function process(App\Request $request)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('EXPORT_TYPE', \App\Export\Records::getSupportedFileFormats($moduleName));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('SEARCH_KEY', $request->getByType('search_key', 'Alnum'));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!$request->isEmpty('viewname')) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!$request->isEmpty('entityState')) {

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 133 characters

Open

        $viewer->assign('SEARCH_PARAMS', \App\Condition::validSearchParams($moduleName, $request->getArray('search_params'), false));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            throw new \App\Exceptions\NoPermitted('LBL_PERMISSION_DENIED', 406);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $moduleName = $request->getModule();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('ENTITY_STATE', $entityState);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('SEARCH_PARAMS', \App\Condition::validSearchParams($moduleName, $request->getArray('search_params'), false));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('SELECTED_IDS', $selectedIds);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('ADVANCED_CONDITIONS', $advancedConditions);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @throws \App\Exceptions\NoPermitted

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $excludedIds = $request->getArray('excluded_ids', 2);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $entityState = $request->getByType('entityState');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $viewer->assign('MODULE_NAME', $moduleName);

• Exclude checks
  • Disable engine
  • Disable check

Class name "Vtiger_Export_View" is not in camel caps format

Open

class Vtiger_Export_View extends Vtiger_Index_View

• Exclude checks
  • Disable engine
  • Disable check