modules/Vtiger/views/GenerateModal.php
The method preProcess has a boolean flag argument $display, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function preProcess(App\Request $request, $display = true)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid using static access to class 'Vtiger_Loader' in method 'process'. Open
Open
$handlerClass = Vtiger_Loader::getComponentClassName('Model', 'MappedFields', $moduleName);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Mass_Action' in method 'process'. Open
Open
$allRecords = Vtiger_Mass_Action::getRecordsListFromRequest($request);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$recordId = $request->getInteger('record');
$templates = $mfModel->getActiveTemplatesForRecord($recordId, $view, $moduleName);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused parameters such as '$request'. Open
Open
public function preProcess(App\Request $request, $display = true)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$display'. Open
Open
public function preProcess(App\Request $request, $display = true)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('TEMPLATES', $templates);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('VIEW', $view);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('BASE_MODULE_NAME', 'Vtiger');- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('RECORD', $recordId ?? '');- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('MODULE_NAME', $moduleName);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('ALL_RECORDS', $allRecords);- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Vtiger_GenerateModal_View extends Vtiger_BasicModal_View- Exclude checks
The class Vtiger_GenerateModal_View is not named in CamelCase. Open
Open
class Vtiger_GenerateModal_View extends Vtiger_BasicModal_View
{
public function preProcess(App\Request $request, $display = true)
{
echo '<div class="generateMappingModal modal fade"><div class="modal-dialog"><div class="modal-content">';- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function process(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function preProcess(App\Request $request, $display = true)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
echo '<div class="generateMappingModal modal fade"><div class="modal-dialog"><div class="modal-content">';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$mfModel = new $handlerClass();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('BASE_MODULE_NAME', 'Vtiger');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$templates = $mfModel->getActiveTemplatesForModule($moduleName, $view);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->postProcess($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleName = $request->getModule();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$recordId = $request->getInteger('record');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('MODULE_NAME', $moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ('List' === $view) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('RECORD', $recordId ?? '');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->preProcess($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$handlerClass = Vtiger_Loader::getComponentClassName('Model', 'MappedFields', $moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->view('GenerateModal.tpl', $moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$view = $request->getByType('fromview', 1);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer = $this->getViewer($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$allRecords = Vtiger_Mass_Action::getRecordsListFromRequest($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('ALL_RECORDS', $allRecords);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$templates = $mfModel->getActiveTemplatesForRecord($recordId, $view, $moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('VIEW', $view);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('TEMPLATES', $templates);- Exclude checks
Class name "Vtiger_GenerateModal_View" is not in camel caps format Open
Open
class Vtiger_GenerateModal_View extends Vtiger_BasicModal_View- Exclude checks