Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Vtiger/views/IndexAjax.php

Summary

Maintainability
A
2 hrs
Test Coverage
F
0%

Function getRecordsListFromRequest has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function getRecordsListFromRequest(App\Request $request)
    {
        $cvId = $request->getByType('cvid', 2);
        $selectedIds = $request->getArray('selected_ids', 2);
        $excludedIds = $request->getArray('excluded_ids', 2);
Severity: Minor
Found in modules/Vtiger/views/IndexAjax.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getRecordsListFromRequest has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getRecordsListFromRequest(App\Request $request)
    {
        $cvId = $request->getByType('cvid', 2);
        $selectedIds = $request->getArray('selected_ids', 2);
        $excludedIds = $request->getArray('excluded_ids', 2);
Severity: Minor
Found in modules/Vtiger/views/IndexAjax.php - About 1 hr to fix

    The method getRecordsListFromRequest() has an NPath complexity of 204. The configured NPath complexity threshold is 200.
    Open

        public function getRecordsListFromRequest(App\Request $request)
    {
        $cvId = $request->getByType('cvid', 2);
        $selectedIds = $request->getArray('selected_ids', 2);
        $excludedIds = $request->getArray('excluded_ids', 2);
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
    function bar() {
        // lots of complicated code
    }
}

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method getRecordsListFromRequest() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
    Open

        public function getRecordsListFromRequest(App\Request $request)
    {
        $cvId = $request->getByType('cvid', 2);
        $selectedIds = $request->getArray('selected_ids', 2);
        $excludedIds = $request->getArray('excluded_ids', 2);
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Avoid using static access to class 'CustomView_Record_Model' in method 'getRecordsListFromRequest'.
    Open

            $customViewModel = CustomView_Record_Model::getInstanceById($cvId);
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid assigning values to variables in if clauses and the like (line '42', column '8').
    Open

        public function getRecordsListFromRequest(App\Request $request)
    {
        $cvId = $request->getByType('cvid', 2);
        $selectedIds = $request->getArray('selected_ids', 2);
        $excludedIds = $request->getArray('excluded_ids', 2);
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid using static access to class 'App\Condition' in method 'getRecordsListFromRequest'.
    Open

                    $customViewModel->set('search_value', App\Condition::validSearchValue($request->getByType('search_value', 'Text'), $request->getModule(), $searchKey, $operator));
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'App\Condition' in method 'getRecordsListFromRequest'.
    Open

                    $customViewModel->set('search_params', App\Condition::validSearchParams($request->getModule(), $request->getArray('search_params')));
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Condition' in method 'getRecordsListFromRequest'.
    Open

                    $customViewModel->set('advancedConditions', \App\Condition::validAdvancedConditions($advancedConditions));
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Define a constant instead of duplicating this literal "advancedConditions" 3 times.
    Open

                if ($advancedConditions = $request->has('advancedConditions') ? $request->getArray('advancedConditions') : []) {
    Severity: Critical
    Found in modules/Vtiger/views/IndexAjax.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "search_params" 3 times.
    Open

                if ($request->has('search_params')) {
    Severity: Critical
    Found in modules/Vtiger/views/IndexAjax.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "operator" 3 times.
    Open

                if (!$request->isEmpty('operator', true)) {
    Severity: Critical
    Found in modules/Vtiger/views/IndexAjax.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Argument 1 (skipRecords) is array but \CustomView_Record_Model::getRecordIds() takes bool|false defined at /code/modules/CustomView/models/Record.php:509
    Open

                return $customViewModel->getRecordIds($excludedIds);
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phan

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class Vtiger_IndexAjax_View extends Vtiger_Index_View
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    The class Vtiger_IndexAjax_View is not named in CamelCase.
    Open

    class Vtiger_IndexAjax_View extends Vtiger_Index_View
{
    use App\Controller\ClearProcess;
    use \App\Controller\ExposeMethod;
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $cvId = CustomView_Record_Model::getAllFilterByModule($sourceModule)->getId();
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Line exceeds 120 characters; contains 178 characters
    Open

                    $customViewModel->set('search_value', App\Condition::validSearchValue($request->getByType('search_value', 'Text'), $request->getModule(), $searchKey, $operator));
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if ($request->has('search_params')) {
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if ($advancedConditions = $request->has('advancedConditions') ? $request->getArray('advancedConditions') : []) {
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $cvId = $request->getByType('cvid', 2);
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $searchKey = $request->getByType('search_key', 'Alnum');
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $selectedIds = $request->getArray('selected_ids', 2);
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getRecordsListFromRequest(App\Request $request)
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                return $selectedIds;
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty($cvId) && 'undefined' == $cvId) {
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $customViewModel = CustomView_Record_Model::getInstanceById($cvId);
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($customViewModel) {
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $customViewModel->set('operator', $operator);
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Line exceeds 120 characters; contains 149 characters
    Open

                    $customViewModel->set('search_params', App\Condition::validSearchParams($request->getModule(), $request->getArray('search_params')));
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        use App\Controller\ClearProcess;
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty($selectedIds) && 'all' !== $selectedIds[0] && \count($selectedIds) > 0) {
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $sourceModule = $request->getByType('sourceModule', 2);
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $customViewModel->set('search_key', $searchKey);
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $customViewModel->set('search_params', App\Condition::validSearchParams($request->getModule(), $request->getArray('search_params')));
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if (!$request->isEmpty('operator', true)) {
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                return $customViewModel->getRecordIds($excludedIds);
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $excludedIds = $request->getArray('excluded_ids', 2);
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $customViewModel->set('search_value', App\Condition::validSearchValue($request->getByType('search_value', 'Text'), $request->getModule(), $searchKey, $operator));
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Line exceeds 120 characters; contains 124 characters
    Open

                if ($advancedConditions = $request->has('advancedConditions') ? $request->getArray('advancedConditions') : []) {
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $customViewModel->set('advancedConditions', \App\Condition::validAdvancedConditions($advancedConditions));
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        use \App\Controller\ExposeMethod;
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $operator = $request->getByType('operator');
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Line exceeds 120 characters; contains 122 characters
    Open

                    $customViewModel->set('advancedConditions', \App\Condition::validAdvancedConditions($advancedConditions));
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    Class name "Vtiger_IndexAjax_View" is not in camel caps format
    Open

    class Vtiger_IndexAjax_View extends Vtiger_Index_View
    Severity: Minor
    Found in modules/Vtiger/views/IndexAjax.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status