modules/Vtiger/views/MergeRecord.php
Avoid using undefined variables such as '$recordModels' which will lead to PHP notices. Open
Open
$viewer->assign('RECORDMODELS', $recordModels);- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$recordModels' which will lead to PHP notices. Open
Open
$recordModels[] = Vtiger_Record_Model::getInstanceById($recordId);- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using static access to class '\App\Privilege' in method 'process'. Open
Open
if (\App\Privilege::isPermitted($moduleName, 'DetailView', $recordId)) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Module_Model' in method 'process'. Open
Open
$moduleModel = Vtiger_Module_Model::getInstance($moduleName);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Record_Model' in method 'process'. Open
Open
$recordModels[] = Vtiger_Record_Model::getInstanceById($recordId);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid unused parameters such as '$request'. Open
Open
public function checkPermission(App\Request $request)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('FIELDS', $fieldModels);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('RECORDS', $records);- Exclude checks
Variable $recordModels was undeclared, but array fields are being added to it. Open
Open
$recordModels[] = Vtiger_Record_Model::getInstanceById($recordId);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('RECORDMODELS', $recordModels);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('MODULE', $moduleName);- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Vtiger_MergeRecord_View extends \App\Controller\View\Page- Exclude checks
The class Vtiger_MergeRecord_View is not named in CamelCase. Open
Open
class Vtiger_MergeRecord_View extends \App\Controller\View\Page
{
public function checkPermission(App\Request $request)
{
}- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Process.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($records as $recordId) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function process(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleName = $request->getModule();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fieldModels = $moduleModel->getFields();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleModel = Vtiger_Module_Model::getInstance($moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function checkPermission(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (\App\Privilege::isPermitted($moduleName, 'DetailView', $recordId)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('MODULE', $moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer = $this->getViewer($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('FIELDS', $fieldModels);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->view('MergeRecords.tpl', $moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param \App\Request $request- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$recordModels[] = Vtiger_Record_Model::getInstanceById($recordId);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$records = $request->getExploded('records');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('RECORDS', $records);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('RECORDMODELS', $recordModels);- Exclude checks
Class name "Vtiger_MergeRecord_View" is not in camel caps format Open
Open
class Vtiger_MergeRecord_View extends \App\Controller\View\Page- Exclude checks