modules/Vtiger/widgets/HistoryRelation.php
Method getQuery has 75 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public static function getQuery($recordId, $moduleName, $type)
{
$queries = [];
$db = App\Db::getInstance();
if (\in_array('Calendar', $type) && ($field = current(\Vtiger_Module_Model::getInstance('Calendar')->getReferenceFieldsForModule($moduleName)))) {Function getQuery has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
Open
public static function getQuery($recordId, $moduleName, $type)
{
$queries = [];
$db = App\Db::getInstance();
if (\in_array('Calendar', $type) && ($field = current(\Vtiger_Module_Model::getInstance('Calendar')->getReferenceFieldsForModule($moduleName)))) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getHistory has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public static function getHistory(App\Request $request, Vtiger_Paging_Model $pagingModel)
{
$recordId = $request->getInteger('record');
if ($request->isEmpty('type')) {
return [];Function getHistory has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
Open
public static function getHistory(App\Request $request, Vtiger_Paging_Model $pagingModel)
{
$recordId = $request->getInteger('record');
if ($request->isEmpty('type')) {
return [];- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The class Vtiger_HistoryRelation_Widget has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13. Open
Open
class Vtiger_HistoryRelation_Widget extends Vtiger_Basic_Widget
{
/**
* Names od classes that define color.
*- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}Source https://phpmd.org/rules/design.html#couplingbetweenobjects
Missing class import via use statement (line '139', column '33'). Open
Open
'attachments_exist' => new \yii\db\Expression($db->quoteValue('')),- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '172', column '18'). Open
Open
$query = (new \App\Db\Query())- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '136', column '18'). Open
Open
$query = (new \App\Db\Query())- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '158', column '20'). Open
Open
'type' => new \yii\db\Expression($db->quoteValue('ModComments')),- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '203', column '17'). Open
Open
$sql = (new \App\Db\Query())->from(['records' => $subQuery]);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '140', column '20'). Open
Open
'type' => new \yii\db\Expression($db->quoteValue('Calendar')),- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '156', column '20'). Open
Open
'body' => new \yii\db\Expression($db->quoteValue('')),- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '154', column '18'). Open
Open
$query = (new \App\Db\Query())- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '176', column '20'). Open
Open
'type' => new \yii\db\Expression('CONCAT(\'OSSMailView\', vtiger_ossmailview.ossmailview_sendtype)'),- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '144', column '20'). Open
Open
'time' => new \yii\db\Expression('CONCAT(vtiger_activity.date_start, ' . $db->quoteValue(' ') . ', vtiger_activity.time_start)'),- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '157', column '33'). Open
Open
'attachments_exist' => new \yii\db\Expression($db->quoteValue('')),- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '138', column '20'). Open
Open
'body' => new \yii\db\Expression($db->quoteValue('')),- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class '\App\Json' in method 'getUrl'. Open
Open
return 'module=' . $this->Module . '&view=Detail&record=' . $this->Record . '&mode=showRecentRelation&page=1&limit=' . $this->Data['limit'] . '&type=' . \App\Json::encode(self::getActions());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'App\Purifier' in method 'getHistory'. Open
Open
$body = str_replace(['<p></p>', '<p class="MsoNormal">'], ["\r\n", "\r\n"], App\Purifier::decodeHtml(App\Purifier::purify($body)));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'App\Db' in method 'getQuery'. Open
Open
$db = App\Db::getInstance();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method getHistory uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$row['url'] = Vtiger_Module_Model::getInstance($row['type'])->getDetailViewUrl($row['id']);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method getHistory uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$row['isGroup'] = false;
$row['userModel'] = Vtiger_Record_Model::getInstanceById($row['user'], 'Users');
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'Vtiger_Record_Model' in method 'getHistory'. Open
Open
$row['userModel'] = Vtiger_Record_Model::getInstanceById($row['user'], 'Users');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'App\TextUtils' in method 'getHistory'. Open
Open
$body = nl2br(App\TextUtils::textTruncate($body, 500), false);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Privilege' in method 'getActions'. Open
Open
if (!\App\Privilege::isPermitted($module)) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Settings_Groups_Record_Model' in method 'getHistory'. Open
Open
$groups = Settings_Groups_Record_Model::getAll();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'App\Purifier' in method 'getHistory'. Open
Open
$body = trim(App\Purifier::purify($row['body']));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method getHistory uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$body = str_replace(['<p></p>', '<p class="MsoNormal">'], ["\r\n", "\r\n"], App\Purifier::decodeHtml(App\Purifier::purify($body)));
$body = nl2br(App\TextUtils::textTruncate($body, 500), false);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method getQuery uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
return false;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid assigning values to variables in if clauses and the like (line '135', column '40'). Open
Open
public static function getQuery($recordId, $moduleName, $type)
{
$queries = [];
$db = App\Db::getInstance();
if (\in_array('Calendar', $type) && ($field = current(\Vtiger_Module_Model::getInstance('Calendar')->getReferenceFieldsForModule($moduleName)))) {- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid using static access to class 'App\TextUtils' in method 'getHistory'. Open
Open
$body = App\TextUtils::textTruncate($body, 100);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'App\Purifier' in method 'getHistory'. Open
Open
$body = str_replace(['<p></p>', '<p class="MsoNormal">'], ["\r\n", "\r\n"], App\Purifier::decodeHtml(App\Purifier::purify($body)));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\PrivilegeQuery' in method 'getQuery'. Open
Open
\App\PrivilegeQuery::getConditions($query, 'OSSMailView', false, $recordId);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\PrivilegeQuery' in method 'getQuery'. Open
Open
\App\PrivilegeQuery::getConditions($query, 'ModComments', false, $recordId);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method getQuery uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$subQuery = reset($queries);
$index = 0;
foreach ($queries as $query) {
if (0 !== $index) {- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\App\PrivilegeQuery' in method 'getQuery'. Open
Open
\App\PrivilegeQuery::getConditions($query, 'Calendar', false, $recordId);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Define a constant instead of duplicating this literal "vtiger_crmentity.deleted" 3 times. Open
Open
->where(['vtiger_crmentity.deleted' => 0])- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "vtiger_crmentity.smownerid" 3 times. Open
Open
'user' => 'vtiger_crmentity.smownerid',- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "Calendar" 6 times. Open
Open
'Calendar' => 'bg-warning',- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "OSSMailView" 6 times. Open
Open
$modules = ['ModComments', 'OSSMailView', 'Calendar'];- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "content" 3 times. Open
Open
'content' => 'vtiger_activity.subject',- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "vtiger_crmentity" 3 times. Open
Open
->innerJoin('vtiger_crmentity', 'vtiger_crmentity.crmid = vtiger_activity.activityid')- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "ModComments" 5 times. Open
Open
'ModComments' => 'bg-primary',- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "attachments_exist" 3 times. Open
Open
'attachments_exist' => new \yii\db\Expression($db->quoteValue('')),- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Call to undeclared method \App\Db::quoteValue Open
Open
'attachments_exist' => new \yii\db\Expression($db->quoteValue('')),- Exclude checks
Call to undeclared method \App\Db::quoteValue Open
Open
'attachments_exist' => new \yii\db\Expression($db->quoteValue('')),- Exclude checks
Call to undeclared method \App\Db::quoteValue Open
Open
'type' => new \yii\db\Expression($db->quoteValue('ModComments')),- Exclude checks
Call to method __construct from undeclared class \yii\db\Expression Open
Open
'type' => new \yii\db\Expression('CONCAT(\'OSSMailView\', vtiger_ossmailview.ossmailview_sendtype)'),- Exclude checks
Returning type false but getQuery() is declared to return \App\Db\Query Open
Open
return false;- Exclude checks
Call to method read from undeclared class \yii\db\DataReader Open
Open
while ($row = $dataReader->read()) {- Exclude checks
Call to method __construct from undeclared class \yii\db\Expression Open
Open
'attachments_exist' => new \yii\db\Expression($db->quoteValue('')),- Exclude checks
Call to undeclared method \App\Db::quoteValue Open
Open
'type' => new \yii\db\Expression($db->quoteValue('Calendar')),- Exclude checks
Call to undeclared method \App\Db::quoteValue Open
Open
'time' => new \yii\db\Expression('CONCAT(vtiger_activity.date_start, ' . $db->quoteValue(' ') . ', vtiger_activity.time_start)'),- Exclude checks
Reference to undeclared property \Vtiger_HistoryRelation_Widget->Data Open
Open
return 'module=' . $this->Module . '&view=Detail&record=' . $this->Record . '&mode=showRecentRelation&page=1&limit=' . $this->Data['limit'] . '&type=' . \App\Json::encode(self::getActions());- Exclude checks
Call to method __construct from undeclared class \yii\db\Expression Open
Open
'type' => new \yii\db\Expression($db->quoteValue('Calendar')),- Exclude checks
Call to undeclared method \App\Db\Query::select Open
Open
$query = (new \App\Db\Query())- Exclude checks
Call to undeclared method \App\Db\Query::select Open
Open
$query = (new \App\Db\Query())- Exclude checks
Call to undeclared method \App\Db\Query::from Open
Open
$sql = (new \App\Db\Query())->from(['records' => $subQuery]);- Exclude checks
Saw a token Phan may have failed to parse after '* @return \App\Db\Query()|false': after \App\Db\Query, saw '(' Open
Open
* @return \App\Db\Query()|false- Exclude checks
Call to method __construct from undeclared class \yii\db\Expression Open
Open
'attachments_exist' => new \yii\db\Expression($db->quoteValue('')),- Exclude checks
Call to method __construct from undeclared class \yii\db\Expression Open
Open
'type' => new \yii\db\Expression($db->quoteValue('ModComments')),- Exclude checks
Suspicious type false of a variable or expression used to build a string. (Expected type to be able to cast to a string) Open
Open
return 'module=' . $this->Module . '&view=Detail&record=' . $this->Record . '&mode=showRecentRelation&page=1&limit=' . $this->Data['limit'] . '&type=' . \App\Json::encode(self::getActions());- Exclude checks
Call to method __construct from undeclared class \yii\db\Expression Open
Open
'body' => new \yii\db\Expression($db->quoteValue('')),- Exclude checks
Call to method __construct from undeclared class \yii\db\Expression Open
Open
'body' => new \yii\db\Expression($db->quoteValue('')),- Exclude checks
Call to undeclared method \App\Db\Query::limit Open
Open
$query->limit($pageLimit)->offset($startIndex);- Exclude checks
Call to undeclared method \App\Db\Query::select Open
Open
$query = (new \App\Db\Query())- Exclude checks
Call to method __construct from undeclared class \yii\db\Expression Open
Open
'time' => new \yii\db\Expression('CONCAT(vtiger_activity.date_start, ' . $db->quoteValue(' ') . ', vtiger_activity.time_start)'),- Exclude checks
Call to undeclared method \App\Db::quoteValue Open
Open
'body' => new \yii\db\Expression($db->quoteValue('')),- Exclude checks
Call to undeclared method \Vtiger_Module_Model::getPreviewViewUrl Open
Open
$row['url'] = Vtiger_Module_Model::getInstance('OSSMailView')->getPreviewViewUrl($row['id']);- Exclude checks
Call to undeclared method \App\Db::quoteValue Open
Open
'body' => new \yii\db\Expression($db->quoteValue('')),- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Vtiger_HistoryRelation_Widget extends Vtiger_Basic_Widget- Exclude checks
The class Vtiger_HistoryRelation_Widget is not named in CamelCase. Open
Open
class Vtiger_HistoryRelation_Widget extends Vtiger_Basic_Widget
{
/**
* Names od classes that define color.
*- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Avoid variables with short names like $db. Configured minimum length is 3. Open
Open
$db = App\Db::getInstance();- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string[]- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public static function getActions()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
unset($modules[$key]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Names od classes that define color.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'ModComments' => 'bg-primary',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'OSSMailViewSent' => 'bg-success',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'OSSMailViewReceived' => 'bg-danger',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $modules;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'OSSMailViewInternal' => 'bg-primary',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!\App\Privilege::isPermitted($module)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'Calendar' => 'bg-warning',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$modules = ['ModComments', 'OSSMailView', 'Calendar'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public static $colors = [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function gets modules name.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($modules as $key => $module) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return 'HistoryRelationConfig';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$startIndex = $pagingModel->getStartIndex();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$row['isGroup'] = false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$queries = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'body' => new \yii\db\Expression($db->quoteValue('')),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$queries[] = $query;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->where(['vtiger_crmentity.deleted' => 0])- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($queries as $query) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$query->limit($pageLimit)->offset($startIndex);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (\in_array($row['user'], $groupIds)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $moduleName- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param array $type- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'user' => 'vtiger_crmentity.smownerid',- Exclude checks
Line exceeds 120 characters; contains 149 characters Open
Open
'time' => new \yii\db\Expression('CONCAT(vtiger_activity.date_start, ' . $db->quoteValue(' ') . ', vtiger_activity.time_start)'),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->from('vtiger_activity')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$query = (new \App\Db\Query())- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'attachments_exist',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$sql = reset($queries);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @var string[]- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->Config['url'] = $this->getUrl();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function creates database query in order to get records for timeline widget.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (\in_array('Calendar', $type) && ($field = current(\Vtiger_Module_Model::getInstance('Calendar')->getReferenceFieldsForModule($moduleName)))) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
])- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
\App\PrivilegeQuery::getConditions($query, 'ModComments', false, $recordId);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$row['body'] = $body;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'body' => new \yii\db\Expression($db->quoteValue('')),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->where(['vtiger_crmentity.deleted' => 0])- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
])- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$queries[] = $query;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$row['url'] = Vtiger_Module_Model::getInstance($row['type'])->getDetailViewUrl($row['id']);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$body = trim(App\Purifier::purify($row['body']));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->select([- Exclude checks
Line exceeds 120 characters; contains 121 characters Open
Open
'type' => new \yii\db\Expression('CONCAT(\'OSSMailView\', vtiger_ossmailview.ossmailview_sendtype)'),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->from('vtiger_ossmailview')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$sql = (new \App\Db\Query())->from(['records' => $subQuery]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->Config;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getConfigTplName()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return array - List of records- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param int $recordId- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'attachments_exist' => new \yii\db\Expression($db->quoteValue('')),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'content' => 'vtiger_activity.subject',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
\App\PrivilegeQuery::getConditions($query, 'OSSMailView', false, $recordId);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$index = 0;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getUrl()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (empty($query)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$body = nl2br(App\TextUtils::textTruncate($body, 500), false);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
\App\PrivilegeQuery::getConditions($query, 'Calendar', false, $recordId);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'type' => new \yii\db\Expression($db->quoteValue('ModComments')),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'user' => 'vtiger_crmentity.smownerid',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'id' => 'vtiger_ossmailview.ossmailviewid',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'time' => 'vtiger_crmentity.createdtime',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
while ($row = $dataReader->read()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$row['class'] = self::$colors[$row['type']];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$row['url'] = Vtiger_Module_Model::getInstance('OSSMailView')->getPreviewViewUrl($row['id']);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->andWhere(['=', 'vtiger_activity.' . $field->getColumnName(), $recordId]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (0 !== $index) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$subQuery->union($query, true);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->Config['tpl'] = 'HistoryRelation.tpl';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$row['userModel'] = $groups[$row['user']];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$body = App\TextUtils::textTruncate($body, 100);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'id' => 'vtiger_crmentity.crmid',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$query = (new \App\Db\Query())- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->from('vtiger_modcomments')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$history = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'content' => 'vtiger_modcomments.commentcontent',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'user' => 'vtiger_crmentity.smownerid',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (1 == \count($queries)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$subQuery = reset($queries);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$recordId = $request->getInteger('record');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$pageLimit = $pagingModel->getPageLimit();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$groupIds = array_keys($groups);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (false !== strpos($row['type'], 'OSSMailView')) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $history;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return \App\Db\Query()|false- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'attachments_exist' => new \yii\db\Expression($db->quoteValue('')),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
])- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->select([- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($subQuery) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$query = static::getQuery($recordId, $request->getModule(), $request->getArray('type', 'Alnum'));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$groups = Settings_Groups_Record_Model::getAll();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$row['type'] = 'OSSMailView';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Get URL.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$query = (new \App\Db\Query())- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($request->isEmpty('type')) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'time' => 'vtiger_crmentity.createdtime',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$dataReader = $query->createCommand()->query();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->innerJoin('vtiger_crmentity', 'vtiger_crmentity.crmid = vtiger_modcomments.modcommentsid')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!$request->getBoolean('isFullscreen')) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->where(['vtiger_crmentity.deleted' => 0])- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$history[] = $row;- Exclude checks
Line exceeds 120 characters; contains 154 characters Open
Open
if (\in_array('Calendar', $type) && ($field = current(\Vtiger_Module_Model::getInstance('Calendar')->getReferenceFieldsForModule($moduleName)))) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'type' => new \yii\db\Expression('CONCAT(\'OSSMailView\', vtiger_ossmailview.ossmailview_sendtype)'),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
++$index;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $sql->orderBy(['time' => SORT_DESC]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public static function getHistory(App\Request $request, Vtiger_Paging_Model $pagingModel)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$row['isGroup'] = true;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$body = str_replace(['<p></p>', '<p class="MsoNormal">'], ["\r\n", "\r\n"], App\Purifier::decodeHtml(App\Purifier::purify($body)));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$queries[] = $query;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (\in_array('ModComments', $type)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->andWhere(['=', 'r.crmid', $recordId]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return 'module=' . $this->Module . '&view=Detail&record=' . $this->Record . '&mode=showRecentRelation&page=1&limit=' . $this->Data['limit'] . '&type=' . \App\Json::encode(self::getActions());- Exclude checks
Line exceeds 120 characters; contains 199 characters Open
Open
return 'module=' . $this->Module . '&view=Detail&record=' . $this->Record . '&mode=showRecentRelation&page=1&limit=' . $this->Data['limit'] . '&type=' . \App\Json::encode(self::getActions());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param Vtiger_Paging_Model $pagingModel- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public static function getQuery($recordId, $moduleName, $type)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$db = App\Db::getInstance();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->select([- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'time' => new \yii\db\Expression('CONCAT(vtiger_activity.date_start, ' . $db->quoteValue(' ') . ', vtiger_activity.time_start)'),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->innerJoin('vtiger_crmentity', 'vtiger_crmentity.crmid = vtiger_activity.activityid')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'id' => 'vtiger_modcomments.modcommentsid',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->andWhere(['=', 'vtiger_modcomments.related_to', $recordId]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (\in_array('OSSMailView', $type)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'body' => 'vtiger_ossmailview.content',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->innerJoin('vtiger_crmentity', 'vtiger_crmentity.crmid = vtiger_ossmailview.ossmailviewid')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->innerJoin('vtiger_ossmailview_relation r', 'r.ossmailviewid = vtiger_ossmailview.ossmailviewid ')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getWidget()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function gets records for timeline widget.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param \App\Request $request- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$row['userModel'] = Vtiger_Record_Model::getInstanceById($row['user'], 'Users');- Exclude checks
Line exceeds 120 characters; contains 147 characters Open
Open
$body = str_replace(['<p></p>', '<p class="MsoNormal">'], ["\r\n", "\r\n"], App\Purifier::decodeHtml(App\Purifier::purify($body)));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'type' => new \yii\db\Expression($db->quoteValue('Calendar')),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'content' => 'vtiger_ossmailview.subject',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Class name "Vtiger_HistoryRelation_Widget" is not in camel caps format Open
Open
class Vtiger_HistoryRelation_Widget extends Vtiger_Basic_Widget- Exclude checks