modules/Vtiger/widgets/RelatedModule.php
Function getWidget has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring. Open
Open
public function getWidget()
{
$widget = [];
$model = Vtiger_Module_Model::getInstance($this->Data['relatedmodule']);
if ($model && $model->isPermitted('DetailView')) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getWidget has 54 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function getWidget()
{
$widget = [];
$model = Vtiger_Module_Model::getInstance($this->Data['relatedmodule']);
if ($model && $model->isPermitted('DetailView')) {Function getUrl has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
public function getUrl()
{
$moduleName = is_numeric($this->Data['relatedmodule']) ? App\Module::getModuleName($this->Data['relatedmodule']) : $this->Data['relatedmodule'];
$url = 'module=' . $this->Module . '&view=Detail&record=' . $this->Record . '&mode=showRelatedRecords&relatedModule=' . $moduleName . '&page=1&limit=' . $this->Data['limit'] . '&viewType=' . $this->Data['viewtype'] . '&relationId=' . $this->Data['relation_id'];
if (isset($this->Data['no_result_text'])) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method getWidget() has an NPath complexity of 242. The configured NPath complexity threshold is 200. Open
Open
public function getWidget()
{
$widget = [];
$model = Vtiger_Module_Model::getInstance($this->Data['relatedmodule']);
if ($model && $model->isPermitted('DetailView')) {- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method getWidget() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10. Open
Open
public function getWidget()
{
$widget = [];
$model = Vtiger_Module_Model::getInstance($this->Data['relatedmodule']);
if ($model && $model->isPermitted('DetailView')) {- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Refactor this function to reduce its Cognitive Complexity from 31 to the 15 allowed. Open
Open
public function getWidget()- Read upRead up
- Exclude checks
Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.
See
Avoid using undefined variables such as '$whereOnCondition' which will lead to PHP notices. Open
Open
$this->Config['checkbox']['on'] = \App\Json::encode($whereOnCondition);- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$whereOnCondition' which will lead to PHP notices. Open
Open
$whereOnCondition[] = [$columnName, 'e', 1];- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$whereOnCondition' which will lead to PHP notices. Open
Open
$whereCondition = [$whereOnCondition];- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$whereOffCondition' which will lead to PHP notices. Open
Open
$whereOffCondition[] = [$columnName, 'e', 0];- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$whereOffCondition' which will lead to PHP notices. Open
Open
$this->Config['checkbox']['off'] = \App\Json::encode($whereOffCondition);- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using static access to class '\App\Json' in method 'getUrl'. Open
Open
$url .= '&orderby=' . \App\Json::encode($this->Data['orderby']);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'App\Module' in method 'getUrl'. Open
Open
$moduleName = is_numeric($this->Data['relatedmodule']) ? App\Module::getModuleName($this->Data['relatedmodule']) : $this->Data['relatedmodule'];- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Module_Model' in method 'getWidget'. Open
Open
$model = Vtiger_Module_Model::getInstance($this->Data['relatedmodule']);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method getWidget uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$url = $model->getQuickCreateUrl();
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\App\Json' in method 'getWidget'. Open
Open
$this->Config['switchHeader']['off'] = \App\Json::encode($whereConditionOff);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Language' in method 'getCheckboxLables'. Open
Open
$translateOff = \App\Language::translate($off, $model->getName());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Settings_Widgets_Module_Model' in method 'getWidget'. Open
Open
$switchHeaderData = Settings_Widgets_Module_Model::getHeaderSwitch($this->Module, [$this->Data['relatedmodule'], $this->Data['switchHeader']]);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Language' in method 'getCheckboxLables'. Open
Open
$translateOff = \App\Language::translate('LBL_NO', $model->getName());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'App\Module' in method 'getApiData'. Open
Open
$relModuleName = is_numeric($this->Data['relatedmodule']) ? App\Module::getModuleName($this->Data['relatedmodule']) : $this->Data['relatedmodule'];- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Json' in method 'getWidget'. Open
Open
$this->Config['switchHeader']['on'] = \App\Json::encode($whereCondition);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Json' in method 'getWidget'. Open
Open
$this->Config['url'] .= '&search_params=' . \App\Json::encode($whereCondition);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Json' in method 'getWidget'. Open
Open
$this->Config['checkbox']['on'] = \App\Json::encode($whereOnCondition);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Language' in method 'getCheckboxLables'. Open
Open
$translateOn = \App\Language::translate('LBL_YES', $model->getName());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Privilege' in method 'getApiData'. Open
Open
if (!\App\Privilege::isPermitted($row['data']['relatedModuleName'])) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Language' in method 'getCheckboxLables'. Open
Open
$translateOn = \App\Language::translate($on, $model->getName());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Json' in method 'getWidget'. Open
Open
$this->Config['checkbox']['off'] = \App\Json::encode($whereOffCondition);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method getWidget uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$columnName = $this->Data['checkbox'];
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\App\Language' in method 'getApiData'. Open
Open
$row['name'] = \App\Language::translate($row['label'] ?: $relModuleName, $relModuleName, false, false);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Define a constant instead of duplicating this literal "checkbox" 8 times. Open
Open
if (isset($this->Data['checkbox']) && '-' !== $this->Data['checkbox']) {- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "relatedmodule" 8 times. Open
Open
$moduleName = is_numeric($this->Data['relatedmodule']) ? App\Module::getModuleName($this->Data['relatedmodule']) : $this->Data['relatedmodule'];- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "relatedfields" 3 times. Open
Open
if (!empty($this->Data['relatedfields'])) {- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "switchHeader" 6 times. Open
Open
if (isset($this->Data['switchHeader']) && '-' != $this->Data['switchHeader']) {- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
if (!empty($this->Data['relatedfields'])) {- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
$url = 'module=' . $this->Module . '&view=Detail&record=' . $this->Record . '&mode=showRelatedRecords&relatedModule=' . $moduleName . '&page=1&limit=' . $this->Data['limit'] . '&viewType=' . $this->Data['viewtype'] . '&relationId=' . $this->Data['relation_id'];- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
if (!empty($this->Data['customView'])) {- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
$url .= '&orderby=' . \App\Json::encode($this->Data['orderby']);- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
$url .= '&no_result_text=' . $this->Data['no_result_text'];- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
if (!empty($this->Data['orderby'])) {- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
if (isset($this->Data['switchHeader']) && '-' != $this->Data['switchHeader']) {- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
$columnName = $this->Data['checkbox'];- Exclude checks
Argument 2 (moduleName) is false but \App\Language::translate() takes string defined at /code/app/Language.php:161 Open
Open
$translateOn = \App\Language::translate('LBL_YES', $model->getName());- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data (Did you mean $data) Open
Open
$relModuleName = is_numeric($this->Data['relatedmodule']) ? App\Module::getModuleName($this->Data['relatedmodule']) : $this->Data['relatedmodule'];- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
$moduleName = is_numeric($this->Data['relatedmodule']) ? App\Module::getModuleName($this->Data['relatedmodule']) : $this->Data['relatedmodule'];- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
$on = $prefix . 'ON_' . strtoupper($this->Data[$type]);- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
if (false !== strpos($this->Data['checkbox'], '.')) {- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
if (1 == $this->Data['action']) {- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
$model = Vtiger_Module_Model::getInstance($this->Data['relatedmodule']);- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
$this->Config['actionURL'] = $url . "&sourceRecord={$this->Record}&sourceModule={$this->Module}&relationOperation=true&relationId=" . $this->Data['relation_id'];- Exclude checks
Variable $whereOffCondition was undeclared, but array fields are being added to it. Open
Open
$whereOffCondition[] = [$columnName, 'e', 0];- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
$data = $this->Data;- Exclude checks
Suspicious type false of a variable or expression used to build a string. (Expected type to be able to cast to a string) Open
Open
$this->Config['actionURL'] = $url . "&sourceRecord={$this->Record}&sourceModule={$this->Module}&relationOperation=true&relationId=" . $this->Data['relation_id'];- Exclude checks
Variable $whereOnCondition was undeclared, but array fields are being added to it. Open
Open
$whereOnCondition[] = [$columnName, 'e', 1];- Exclude checks
Argument 2 (moduleName) is false but \App\Language::translate() takes string defined at /code/app/Language.php:161 Open
Open
$translateOff = \App\Language::translate('LBL_NO', $model->getName());- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
$cvId = reset($this->Data['customView']);- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
$off = $prefix . 'OFF_' . strtoupper($this->Data[$type]);- Exclude checks
Argument 2 (moduleName) is false but \App\Language::translate() takes string defined at /code/app/Language.php:161 Open
Open
$translateOn = \App\Language::translate($on, $model->getName());- Exclude checks
Argument 2 (moduleName) is false but \App\Language::translate() takes string defined at /code/app/Language.php:161 Open
Open
$translateOff = \App\Language::translate($off, $model->getName());- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
foreach ((array) $this->Data['relatedfields'] as $field) {- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
if (isset($this->Data['no_result_text'])) {- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
if (isset($this->Data['checkbox']) && '-' !== $this->Data['checkbox']) {- Exclude checks
Argument 3 (language) is false but \App\Language::translate() takes null|string defined at /code/app/Language.php:161 Open
Open
$row['name'] = \App\Language::translate($row['label'] ?: $relModuleName, $relModuleName, false, false);- Exclude checks
Suspicious type false of a variable or expression used to build a string. (Expected type to be able to cast to a string) Open
Open
$url = 'module=' . $this->Module . '&view=Detail&record=' . $this->Record . '&mode=showRelatedRecords&relatedModule=' . $moduleName . '&page=1&limit=' . $this->Data['limit'] . '&viewType=' . $this->Data['viewtype'] . '&relationId=' . $this->Data['relation_id'];- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
$separateData = explode('.', $this->Data['checkbox']);- Exclude checks
Reference to undeclared property \Vtiger_RelatedModule_Widget->Data Open
Open
$switchHeaderData = Settings_Widgets_Module_Model::getHeaderSwitch($this->Module, [$this->Data['relatedmodule'], $this->Data['switchHeader']]);- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Vtiger_RelatedModule_Widget extends Vtiger_Basic_Widget- Exclude checks
The class Vtiger_RelatedModule_Widget is not named in CamelCase. Open
Open
class Vtiger_RelatedModule_Widget extends Vtiger_Basic_Widget
{
public function getUrl()
{
$moduleName = is_numeric($this->Data['relatedmodule']) ? App\Module::getModuleName($this->Data['relatedmodule']) : $this->Data['relatedmodule'];- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Avoid variables with short names like $on. Configured minimum length is 3. Open
Open
$on = $prefix . 'ON_' . strtoupper($this->Data[$type]);- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!empty($this->Data['orderby'])) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!empty($this->Data['customView'])) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$url = 'module=' . $this->Module . '&view=Detail&record=' . $this->Record . '&mode=showRelatedRecords&relatedModule=' . $moduleName . '&page=1&limit=' . $this->Data['limit'] . '&viewType=' . $this->Data['viewtype'] . '&relationId=' . $this->Data['relation_id'];- Exclude checks
Line exceeds 120 characters; contains 269 characters Open
Open
$url = 'module=' . $this->Module . '&view=Detail&record=' . $this->Record . '&mode=showRelatedRecords&relatedModule=' . $moduleName . '&page=1&limit=' . $this->Data['limit'] . '&viewType=' . $this->Data['viewtype'] . '&relationId=' . $this->Data['relation_id'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleName = is_numeric($this->Data['relatedmodule']) ? App\Module::getModuleName($this->Data['relatedmodule']) : $this->Data['relatedmodule'];- Exclude checks
Line exceeds 120 characters; contains 152 characters Open
Open
$moduleName = is_numeric($this->Data['relatedmodule']) ? App\Module::getModuleName($this->Data['relatedmodule']) : $this->Data['relatedmodule'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$cvId = reset($this->Data['customView']);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$url .= '&cvId=' . $cvId;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getUrl()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$url .= '&no_result_text=' . $this->Data['no_result_text'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (isset($this->Data['no_result_text'])) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getWidget()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($model && $model->isPermitted('DetailView')) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->Config['tpl'] = 'Basic.tpl';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (isset($this->Data['switchHeader']) && '-' != $this->Data['switchHeader']) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($switchHeaderData && 1 === $switchHeaderData['type']) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$whereOnCondition[] = [$columnName, 'e', 1];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->Config['url'] .= '&search_params=' . \App\Json::encode($whereCondition);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$widget = $this->Config;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$widget['instance'] = $this;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$off = $prefix . 'OFF_' . strtoupper($this->Data[$type]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getConfigTplName()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$widget = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$whereConditionOff[] = [$name, 'e', implode('##', $value)];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$data['relatedModuleName'] = $relModuleName;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$whereConditionOff = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $widget;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$relModuleName = is_numeric($this->Data['relatedmodule']) ? App\Module::getModuleName($this->Data['relatedmodule']) : $this->Data['relatedmodule'];- Exclude checks
Line exceeds 120 characters; contains 155 characters Open
Open
$relModuleName = is_numeric($this->Data['relatedmodule']) ? App\Module::getModuleName($this->Data['relatedmodule']) : $this->Data['relatedmodule'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fields[] = $fieldName;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$model = Vtiger_Module_Model::getInstance($this->Data['relatedmodule']);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (1 == $this->Data['action']) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$switchHeaderData = Settings_Widgets_Module_Model::getHeaderSwitch($this->Module, [$this->Data['relatedmodule'], $this->Data['switchHeader']]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->getCheckboxLables($model, 'switchHeader', 'LBL_SWITCHHEADER_');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($switchHeaderData['value'] as $name => $value) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->Config['switchHeader']['off'] = \App\Json::encode($whereConditionOff);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$whereOffCondition[] = [$columnName, 'e', 0];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->Config['checkbox']['on'] = \App\Json::encode($whereOnCondition);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$translateOn = \App\Language::translate($on, $model->getName());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$translateOn = \App\Language::translate('LBL_YES', $model->getName());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($on === $translateOn) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$data = $this->Data;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$row['name'] = \App\Language::translate($row['label'] ?: $relModuleName, $relModuleName, false, false);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ((array) $this->Data['relatedfields'] as $field) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->Config['isQuickCreateSupport'] = $isQuickCreateSupport;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $row;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($isQuickCreateSupport) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$url = $model->getQuickCreateUrl();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->Config['switchHeader']['on'] = \App\Json::encode($whereCondition);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$on = $prefix . 'ON_' . strtoupper($this->Data[$type]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($off === $translateOff) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$translateOff = \App\Language::translate('LBL_NO', $model->getName());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$url .= '&fields=' . implode(',', $fields);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (isset($this->Data['checkbox']) && '-' !== $this->Data['checkbox']) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$columnName = $this->Data['checkbox'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$translateOff = \App\Language::translate($off, $model->getName());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($fields) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $url;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$whereCondition[] = [$name, 'n', implode('##', $value)];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fieldName = explode('::', $fieldName)[1];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$createPermission = $model->isPermitted('CreateView');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$url = $model->getCreateRecordUrl();- Exclude checks
Line exceeds 120 characters; contains 177 characters Open
Open
$this->Config['actionURL'] = $url . "&sourceRecord={$this->Record}&sourceModule={$this->Module}&relationOperation=true&relationId=" . $this->Data['relation_id'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->getCheckboxLables($model, 'checkbox', 'LBL_SWITCH_');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!empty($whereCondition)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getHeaderButtons()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getCheckboxLables($model, $type, $prefix)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->Config[$type . 'Lables'] = ['on' => $translateOn, 'off' => $translateOff];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return 'RelatedModuleConfig';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($data['relatedfields'] as &$fieldName) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fields = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->Config['action'] = (true === $createPermission) ? 1 : 0;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$columnName = $separateData[1];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$row = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$url .= '&orderby=' . \App\Json::encode($this->Data['orderby']);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->Config['url'] = $this->getUrl();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->Config['actionURL'] = $url . "&sourceRecord={$this->Record}&sourceModule={$this->Module}&relationOperation=true&relationId=" . $this->Data['relation_id'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$whereCondition = [$whereCondition];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (false !== strpos($this->Data['checkbox'], '.')) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$whereCondition = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$isQuickCreateSupport = !$model->isQuickCreateSupported();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$separateData = explode('.', $this->Data['checkbox']);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->Config['checkbox']['off'] = \App\Json::encode($whereOffCondition);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
[, $fieldName] = explode('::', $field);- Exclude checks
Line exceeds 120 characters; contains 159 characters Open
Open
$switchHeaderData = Settings_Widgets_Module_Model::getHeaderSwitch($this->Module, [$this->Data['relatedmodule'], $this->Data['switchHeader']]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$whereCondition = [$whereOnCondition];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->Config['buttonHeader'] = $this->getHeaderButtons();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getApiData(array $row): array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$row['data'] = $data;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!\App\Privilege::isPermitted($row['data']['relatedModuleName'])) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!empty($this->Data['relatedfields'])) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Gets buttons.- Exclude checks
Class name "Vtiger_RelatedModule_Widget" is not in camel caps format Open
Open
class Vtiger_RelatedModule_Widget extends Vtiger_Basic_Widget- Exclude checks